From 4e582a507df103e0ce26814bbd9080b8cf912490 Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Mon, 28 Sep 2015 13:18:54 +0200 Subject: [PATCH] Fix 3 PHPCS warnings in MessageCache.php Change-Id: I0970b8844fa89d3bdc4fec200d912ecf80a52176 --- includes/cache/MessageCache.php | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/includes/cache/MessageCache.php b/includes/cache/MessageCache.php index f22c860afa..ef70589f0f 100644 --- a/includes/cache/MessageCache.php +++ b/includes/cache/MessageCache.php @@ -394,21 +394,19 @@ class MessageCache { $saveSuccess = $this->saveToCaches( $cache, 'all', $code ); if ( !$saveSuccess ) { - # Cache save has failed. - # There are two main scenarios where this could be a problem: - # - # - The cache is more than the maximum size (typically - # 1MB compressed). - # - # - Memcached has no space remaining in the relevant slab - # class. This is unlikely with recent versions of - # memcached. - # - # Either way, if there is a local cache, nothing bad will - # happen. If there is no local cache, disabling the message - # cache for all requests avoids incurring a loadFromDB() - # overhead on every request, and thus saves the wiki from - # complete downtime under moderate traffic conditions. + /** + * Cache save has failed. + * + * There are two main scenarios where this could be a problem: + * - The cache is more than the maximum size (typically 1MB compressed). + * - Memcached has no space remaining in the relevant slab class. This is + * unlikely with recent versions of memcached. + * + * Either way, if there is a local cache, nothing bad will happen. If there + * is no local cache, disabling the message cache for all requests avoids + * incurring a loadFromDB() overhead on every request, and thus saves the + * wiki from complete downtime under moderate traffic conditions. + */ if ( !$wgUseLocalMessageCache ) { $this->mMemc->set( $statusKey, 'error', 60 * 5 ); $where[] = 'could not save cache, disabled globally for 5 minutes'; -- 2.20.1