From 34fb6297cdd897542647d4281bd4ec969367ee53 Mon Sep 17 00:00:00 2001 From: Ilmari Karonen Date: Mon, 1 Dec 2008 17:14:30 +0000 Subject: [PATCH] Step 2 in NS_IMAGE -> NS_FILE transition (bug 44) (WARNING: huge commit). This is a global search and replace of NS_IMAGE and NS_IMAGE_TALK with NS_FILE and NS_FILE_TALK respectively in all core files, excluding those already updated in step 1 (r44004). --- RELEASE-NOTES | 3 ++- img_auth.php | 2 +- includes/Article.php | 6 +++--- includes/Category.php | 2 +- includes/CategoryPage.php | 2 +- includes/DefaultSettings.php | 2 +- includes/EditPage.php | 4 ++-- includes/ImageGallery.php | 2 +- includes/ImagePage.php | 14 ++++++------- includes/ImageQueryPage.php | 4 ++-- includes/Linker.php | 4 ++-- includes/LinksUpdate.php | 2 +- includes/Namespace.php | 6 +++--- includes/PrefixSearch.php | 2 +- includes/SearchEngine.php | 8 ++++---- includes/Setup.php | 4 ++-- includes/Skin.php | 4 ++-- includes/SkinTemplate.php | 2 +- includes/Title.php | 20 +++++++++---------- includes/UploadBase.php | 4 ++-- includes/Wiki.php | 6 +++--- includes/api/ApiDelete.php | 2 +- includes/api/ApiQueryAllimages.php | 2 +- includes/api/ApiQueryBacklinks.php | 6 +++--- includes/api/ApiQueryDuplicateFiles.php | 6 +++--- includes/api/ApiQueryImageInfo.php | 12 +++++------ includes/api/ApiQueryImages.php | 4 ++-- includes/api/ApiQueryInfo.php | 8 ++++---- includes/filerepo/ArchivedFile.php | 4 ++-- includes/filerepo/File.php | 2 +- includes/filerepo/FileRepo.php | 12 +++++------ includes/filerepo/ForeignDBFile.php | 2 +- includes/filerepo/Image.php | 2 +- includes/filerepo/LocalFile.php | 2 +- includes/filerepo/LocalRepo.php | 2 +- includes/filerepo/OldLocalFile.php | 2 +- includes/filerepo/RepoGroup.php | 2 +- includes/filerepo/UnregisteredLocalFile.php | 2 +- includes/parser/Parser.php | 10 +++++----- includes/specials/SpecialExport.php | 2 +- .../specials/SpecialFileDuplicateSearch.php | 2 +- includes/specials/SpecialFilepath.php | 4 ++-- includes/specials/SpecialImagelist.php | 2 +- includes/specials/SpecialMIMEsearch.php | 2 +- includes/specials/SpecialMostimages.php | 2 +- includes/specials/SpecialNewimages.php | 2 +- .../specials/SpecialRecentchangeslinked.php | 6 +++--- includes/specials/SpecialSearch.php | 12 +++++------ .../specials/SpecialUncategorizedimages.php | 2 +- includes/specials/SpecialUndelete.php | 6 +++--- includes/specials/SpecialUnusedimages.php | 2 +- includes/specials/SpecialUpload.php | 10 +++++----- includes/specials/SpecialWantedfiles.php | 4 ++-- includes/specials/SpecialWhatlinkshere.php | 4 ++-- languages/classes/LanguageKk.php | 2 +- languages/classes/LanguageKu.php | 2 +- languages/classes/LanguageSr.php | 2 +- languages/messages/MessagesAf.php | 8 ++++---- languages/messages/MessagesAm.php | 4 ++-- languages/messages/MessagesAn.php | 4 ++-- languages/messages/MessagesAng.php | 4 ++-- languages/messages/MessagesAr.php | 8 ++++---- languages/messages/MessagesArz.php | 8 ++++---- languages/messages/MessagesAs.php | 8 ++++---- languages/messages/MessagesAst.php | 12 +++++------ languages/messages/MessagesAvk.php | 4 ++-- languages/messages/MessagesAz.php | 4 ++-- languages/messages/MessagesBa.php | 4 ++-- languages/messages/MessagesBat_smg.php | 8 ++++---- languages/messages/MessagesBcc.php | 8 ++++---- languages/messages/MessagesBcl.php | 4 ++-- languages/messages/MessagesBe.php | 4 ++-- languages/messages/MessagesBe_tarask.php | 8 ++++---- languages/messages/MessagesBg.php | 8 ++++---- languages/messages/MessagesBn.php | 8 ++++---- languages/messages/MessagesBpy.php | 4 ++-- languages/messages/MessagesBr.php | 4 ++-- languages/messages/MessagesBs.php | 8 ++++---- languages/messages/MessagesCa.php | 8 ++++---- languages/messages/MessagesCe.php | 4 ++-- languages/messages/MessagesCeb.php | 4 ++-- languages/messages/MessagesCh.php | 4 ++-- languages/messages/MessagesCrh_cyrl.php | 8 ++++---- languages/messages/MessagesCrh_latn.php | 8 ++++---- languages/messages/MessagesCs.php | 4 ++-- languages/messages/MessagesCsb.php | 4 ++-- languages/messages/MessagesCu.php | 12 +++++------ languages/messages/MessagesCv.php | 4 ++-- languages/messages/MessagesCy.php | 4 ++-- languages/messages/MessagesDa.php | 4 ++-- languages/messages/MessagesDe.php | 8 ++++---- languages/messages/MessagesDsb.php | 8 ++++---- languages/messages/MessagesEl.php | 4 ++-- languages/messages/MessagesEn.php | 4 ++-- languages/messages/MessagesEo.php | 4 ++-- languages/messages/MessagesEs.php | 8 ++++---- languages/messages/MessagesEt.php | 4 ++-- languages/messages/MessagesEu.php | 8 ++++---- languages/messages/MessagesFa.php | 8 ++++---- languages/messages/MessagesFi.php | 8 ++++---- languages/messages/MessagesFiu_vro.php | 4 ++-- languages/messages/MessagesFo.php | 6 +++--- languages/messages/MessagesFr.php | 4 ++-- languages/messages/MessagesFrp.php | 4 ++-- languages/messages/MessagesFur.php | 4 ++-- languages/messages/MessagesFy.php | 4 ++-- languages/messages/MessagesGa.php | 6 +++--- languages/messages/MessagesGl.php | 8 ++++---- languages/messages/MessagesGn.php | 4 ++-- languages/messages/MessagesGu.php | 4 ++-- languages/messages/MessagesGv.php | 4 ++-- languages/messages/MessagesHaw.php | 4 ++-- languages/messages/MessagesHe.php | 8 ++++---- languages/messages/MessagesHi.php | 4 ++-- languages/messages/MessagesHr.php | 8 ++++---- languages/messages/MessagesHsb.php | 8 ++++---- languages/messages/MessagesHt.php | 4 ++-- languages/messages/MessagesHu.php | 10 +++++----- languages/messages/MessagesHy.php | 4 ++-- languages/messages/MessagesIa.php | 8 ++++---- languages/messages/MessagesId.php | 10 +++++----- languages/messages/MessagesIo.php | 4 ++-- languages/messages/MessagesIs.php | 8 ++++---- languages/messages/MessagesIt.php | 8 ++++---- languages/messages/MessagesJa.php | 8 ++++---- languages/messages/MessagesJv.php | 6 +++--- languages/messages/MessagesKa.php | 8 ++++---- languages/messages/MessagesKaa.php | 4 ++-- languages/messages/MessagesKab.php | 4 ++-- languages/messages/MessagesKk_arab.php | 12 +++++------ languages/messages/MessagesKk_cyrl.php | 12 +++++------ languages/messages/MessagesKk_latn.php | 12 +++++------ languages/messages/MessagesKm.php | 10 +++++----- languages/messages/MessagesKn.php | 4 ++-- languages/messages/MessagesKo.php | 8 ++++---- languages/messages/MessagesKsh.php | 12 +++++------ languages/messages/MessagesKu_latn.php | 4 ++-- languages/messages/MessagesLa.php | 8 ++++---- languages/messages/MessagesLb.php | 8 ++++---- languages/messages/MessagesLbe.php | 4 ++-- languages/messages/MessagesLfn.php | 4 ++-- languages/messages/MessagesLi.php | 8 ++++---- languages/messages/MessagesLij.php | 8 ++++---- languages/messages/MessagesLo.php | 4 ++-- languages/messages/MessagesLt.php | 4 ++-- languages/messages/MessagesLv.php | 4 ++-- languages/messages/MessagesMdf.php | 8 ++++---- languages/messages/MessagesMg.php | 4 ++-- languages/messages/MessagesMk.php | 8 ++++---- languages/messages/MessagesMl.php | 8 ++++---- languages/messages/MessagesMn.php | 4 ++-- languages/messages/MessagesMr.php | 4 ++-- languages/messages/MessagesMs.php | 10 +++++----- languages/messages/MessagesMt.php | 4 ++-- languages/messages/MessagesMyv.php | 4 ++-- languages/messages/MessagesNah.php | 8 ++++---- languages/messages/MessagesNap.php | 8 ++++---- languages/messages/MessagesNds.php | 12 +++++------ languages/messages/MessagesNds_nl.php | 4 ++-- languages/messages/MessagesNew.php | 4 ++-- languages/messages/MessagesNl.php | 8 ++++---- languages/messages/MessagesNn.php | 4 ++-- languages/messages/MessagesNo.php | 8 ++++---- languages/messages/MessagesNso.php | 4 ++-- languages/messages/MessagesNv.php | 4 ++-- languages/messages/MessagesOc.php | 6 +++--- languages/messages/MessagesOs.php | 4 ++-- languages/messages/MessagesPa.php | 4 ++-- languages/messages/MessagesPl.php | 8 ++++---- languages/messages/MessagesPms.php | 4 ++-- languages/messages/MessagesPnt.php | 4 ++-- languages/messages/MessagesPs.php | 4 ++-- languages/messages/MessagesPt.php | 8 ++++---- languages/messages/MessagesPt_br.php | 8 ++++---- languages/messages/MessagesQu.php | 4 ++-- languages/messages/MessagesRmy.php | 4 ++-- languages/messages/MessagesRo.php | 8 ++++---- languages/messages/MessagesRu.php | 8 ++++---- languages/messages/MessagesSa.php | 4 ++-- languages/messages/MessagesSah.php | 4 ++-- languages/messages/MessagesSc.php | 4 ++-- languages/messages/MessagesScn.php | 8 ++++---- languages/messages/MessagesSd.php | 4 ++-- languages/messages/MessagesSdc.php | 4 ++-- languages/messages/MessagesSi.php | 8 ++++---- languages/messages/MessagesSk.php | 10 +++++----- languages/messages/MessagesSl.php | 4 ++-- languages/messages/MessagesSq.php | 4 ++-- languages/messages/MessagesSr_ec.php | 8 ++++---- languages/messages/MessagesSr_el.php | 8 ++++---- languages/messages/MessagesSrn.php | 8 ++++---- languages/messages/MessagesStq.php | 4 ++-- languages/messages/MessagesSu.php | 4 ++-- languages/messages/MessagesSv.php | 8 ++++---- languages/messages/MessagesTa.php | 6 +++--- languages/messages/MessagesTe.php | 10 +++++----- languages/messages/MessagesTet.php | 4 ++-- languages/messages/MessagesTg_cyrl.php | 4 ++-- languages/messages/MessagesTh.php | 8 ++++---- languages/messages/MessagesTl.php | 4 ++-- languages/messages/MessagesTlh.php | 4 ++-- languages/messages/MessagesTr.php | 4 ++-- languages/messages/MessagesTt_latn.php | 4 ++-- languages/messages/MessagesTyv.php | 4 ++-- languages/messages/MessagesUdm.php | 4 ++-- languages/messages/MessagesUk.php | 8 ++++---- languages/messages/MessagesUr.php | 4 ++-- languages/messages/MessagesUz.php | 4 ++-- languages/messages/MessagesVec.php | 8 ++++---- languages/messages/MessagesVi.php | 8 ++++---- languages/messages/MessagesVls.php | 4 ++-- languages/messages/MessagesVo.php | 8 ++++---- languages/messages/MessagesWa.php | 4 ++-- languages/messages/MessagesWo.php | 6 +++--- languages/messages/MessagesXal.php | 4 ++-- languages/messages/MessagesYi.php | 8 ++++---- languages/messages/MessagesYo.php | 4 ++-- languages/messages/MessagesYue.php | 20 +++++++++---------- languages/messages/MessagesZea.php | 4 ++-- languages/messages/MessagesZh.php | 8 ++++---- languages/messages/MessagesZh_hans.php | 8 ++++---- languages/messages/MessagesZh_hant.php | 8 ++++---- languages/messages/MessagesZh_tw.php | 4 ++-- maintenance/FiveUpgrade.inc | 2 +- maintenance/archives/patch-linktables.sql | 2 +- maintenance/cleanupImages.php | 8 ++++---- maintenance/deleteBatch.php | 2 +- maintenance/generateSitemap.php | 4 ++-- maintenance/importImages.php | 2 +- maintenance/tables.sql | 4 ++-- skins/Standard.php | 4 ++-- thumb.php | 2 +- 232 files changed, 654 insertions(+), 653 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index d8315158aa..428e567d14 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -64,7 +64,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN For backward compatibility purposes, Image still works. External tools may need to be updated. * The constants NS_FILE and NS_FILE_TALK can now be used instead of NS_IMAGE and - NS_IMAGE_TALK. The old constants are retained as aliases for compatibility. + NS_IMAGE_TALK. The old constants are retained as aliases for compatibility, + and should still be used in code meant to be compatible with v1.13 or older. * MediaWiki can be forced to use private IPs forwarded by a proxy server by using $wgUsePrivateIPs. diff --git a/img_auth.php b/img_auth.php index 4b625e3972..9141018103 100644 --- a/img_auth.php +++ b/img_auth.php @@ -48,7 +48,7 @@ if( preg_match( '!\d+px-(.*)!i', $name, $m ) ) $name = $m[1]; wfDebugLog( 'img_auth', "\$name is {$name}" ); -$title = Title::makeTitleSafe( NS_IMAGE, $name ); +$title = Title::makeTitleSafe( NS_FILE, $name ); if( !$title instanceof Title ) { wfDebugLog( 'img_auth', "Unable to construct a valid Title from `{$name}`" ); wfForbidden(); diff --git a/includes/Article.php b/includes/Article.php index fba1f82485..262806e26c 100644 --- a/includes/Article.php +++ b/includes/Article.php @@ -1219,7 +1219,7 @@ class Article { $where = array( 'rd_from' => $this->getId() ); $dbw->delete( 'redirect', $where, __METHOD__); } - if( $this->getTitle()->getNamespace() == NS_IMAGE ) { + if( $this->getTitle()->getNamespace() == NS_FILE ) { RepoGroup::singleton()->getLocalRepo()->invalidateImageRedirect( $this->getTitle() ); } wfProfileOut( __METHOD__ ); @@ -3172,7 +3172,7 @@ class Article { $wgMessageCache->replace( $title->getDBkey(), false ); } # Images - if( $title->getNamespace() == NS_IMAGE ) { + if( $title->getNamespace() == NS_FILE ) { $update = new HTMLCacheUpdate( $title, 'imagelinks' ); $update->doUpdate(); } @@ -3518,7 +3518,7 @@ class Article { if( $ns == NS_CATEGORY ) { $addFields[] = 'cat_subcats = cat_subcats + 1'; $removeFields[] = 'cat_subcats = cat_subcats - 1'; - } elseif( $ns == NS_IMAGE ) { + } elseif( $ns == NS_FILE ) { $addFields[] = 'cat_files = cat_files + 1'; $removeFields[] = 'cat_files = cat_files - 1'; } diff --git a/includes/Category.php b/includes/Category.php index ff4643c24c..78567adddc 100644 --- a/includes/Category.php +++ b/includes/Category.php @@ -257,7 +257,7 @@ class Category { } $cond1 = $dbw->conditional( 'page_namespace='.NS_CATEGORY, 1, 'NULL' ); - $cond2 = $dbw->conditional( 'page_namespace='.NS_IMAGE, 1, 'NULL' ); + $cond2 = $dbw->conditional( 'page_namespace='.NS_FILE, 1, 'NULL' ); $result = $dbw->selectRow( array( 'categorylinks', 'page' ), array( 'COUNT(*) AS pages', diff --git a/includes/CategoryPage.php b/includes/CategoryPage.php index 47393e5711..f150e372e9 100644 --- a/includes/CategoryPage.php +++ b/includes/CategoryPage.php @@ -234,7 +234,7 @@ class CategoryViewer { if( $title->getNamespace() == NS_CATEGORY ) { $cat = Category::newFromRow( $x, $title ); $this->addSubcategoryObject( $cat, $x->cl_sortkey, $x->page_len ); - } elseif( $this->showGallery && $title->getNamespace() == NS_IMAGE ) { + } elseif( $this->showGallery && $title->getNamespace() == NS_FILE ) { $this->addImage( $title, $x->cl_sortkey, $x->page_len, $x->page_is_redirect ); } else { $this->addPage( $title, $x->cl_sortkey, $x->page_len, $x->page_is_redirect ); diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index 3c9de2a7c9..6f48361595 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -1915,7 +1915,7 @@ $wgNamespacesWithSubpages = array( NS_USER => true, NS_USER_TALK => true, NS_PROJECT_TALK => true, - NS_IMAGE_TALK => true, + NS_FILE_TALK => true, NS_MEDIAWIKI_TALK => true, NS_TEMPLATE_TALK => true, NS_HELP_TALK => true, diff --git a/includes/EditPage.php b/includes/EditPage.php index a974ca7aac..ea4c056e27 100644 --- a/includes/EditPage.php +++ b/includes/EditPage.php @@ -738,7 +738,7 @@ class EditPage { } # Check image redirect - if ( $this->mTitle->getNamespace() == NS_IMAGE && + if ( $this->mTitle->getNamespace() == NS_FILE && Title::newFromRedirect( $this->textbox1 ) instanceof Title && !$wgUser->isAllowed( 'upload' ) ) { if ( $wgUser->isAnon() ) { @@ -1971,7 +1971,7 @@ END array( 'image' => $wgLang->getImageFile('button-image'), 'id' => 'mw-editbutton-image', - 'open' => '[['.$wgContLang->getNsText(NS_IMAGE).':', + 'open' => '[['.$wgContLang->getNsText(NS_FILE).':', 'close' => ']]', 'sample' => wfMsg('image_sample'), 'tip' => wfMsg('image_tip'), diff --git a/includes/ImageGallery.php b/includes/ImageGallery.php index 492a3e06e9..f3f525c11d 100644 --- a/includes/ImageGallery.php +++ b/includes/ImageGallery.php @@ -244,7 +244,7 @@ class ImageGallery $img = wfFindFile( $nt, $time ); - if( $nt->getNamespace() != NS_IMAGE || !$img ) { + if( $nt->getNamespace() != NS_FILE || !$img ) { # We're dealing with a non-image, spit out the name and be done with it. $thumbhtml = "\n\t\t\t".'
' . htmlspecialchars( $nt->getText() ) . '
'; diff --git a/includes/ImagePage.php b/includes/ImagePage.php index cd0ef0aae4..0638a5b869 100644 --- a/includes/ImagePage.php +++ b/includes/ImagePage.php @@ -57,7 +57,7 @@ class ImagePage extends Article { global $wgOut, $wgShowEXIF, $wgRequest, $wgUser; $this->loadFile(); - if( $this->mTitle->getNamespace() == NS_IMAGE && $this->img->getRedirected() ) { + if( $this->mTitle->getNamespace() == NS_FILE && $this->img->getRedirected() ) { if( $this->mTitle->getDBkey() == $this->img->getName() ) { // mTitle is the same as the redirect target so ask Article // to perform the redirect for us. @@ -66,7 +66,7 @@ class ImagePage extends Article { // mTitle is not the same as the redirect target so it is // probably the redirect page itself. Fake the redirect symbol $wgOut->setPageTitle( $this->mTitle->getPrefixedText() ); - $wgOut->addHTML( $this->viewRedirect( Title::makeTitle( NS_IMAGE, $this->img->getName() ), + $wgOut->addHTML( $this->viewRedirect( Title::makeTitle( NS_FILE, $this->img->getName() ), /* $appendSubtitle */ true, /* $forceKnown */ true ) ); $this->viewUpdates(); return; @@ -76,7 +76,7 @@ class ImagePage extends Article { $diff = $wgRequest->getVal( 'diff' ); $diffOnly = $wgRequest->getBool( 'diffonly', $wgUser->getOption( 'diffonly' ) ); - if( $this->mTitle->getNamespace() != NS_IMAGE || ( isset( $diff ) && $diffOnly ) ) + if( $this->mTitle->getNamespace() != NS_FILE || ( isset( $diff ) && $diffOnly ) ) return Article::view(); if( $wgShowEXIF && $this->displayImg->exists() ) { @@ -152,7 +152,7 @@ class ImagePage extends Article { if( $from == $to ) { return null; } - return $this->mRedirectTarget = Title::makeTitle( NS_IMAGE, $to ); + return $this->mRedirectTarget = Title::makeTitle( NS_FILE, $to ); } public function followRedirect() { $this->loadFile(); @@ -164,7 +164,7 @@ class ImagePage extends Article { if( $from == $to ) { return false; } - return Title::makeTitle( NS_IMAGE, $to ); + return Title::makeTitle( NS_FILE, $to ); } public function isRedirect( $text = false ) { $this->loadFile(); @@ -222,7 +222,7 @@ class ImagePage extends Article { protected function showTOC( $metadata ) { global $wgLang; $r = '