From 196c3f06624231f0b4a0fff76e3bcee3810987e1 Mon Sep 17 00:00:00 2001
From: Moriel Schottlender <moriel@gmail.com>
Date: Wed, 23 Aug 2017 16:10:23 -0700
Subject: [PATCH] RCFilters: Adjust pushpin 'default' icon behavior and style

Bug: T173264
Change-Id: I8d977bb97e91a19c24527c66120f142738135730
---
 .../mw.rcfilters.ui.SavedLinksListItemWidget.less   |  7 +++++--
 .../ui/mw.rcfilters.ui.SavedLinksListItemWidget.js  | 13 +++++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.SavedLinksListItemWidget.less b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.SavedLinksListItemWidget.less
index 2daa76e4a1..e7433e277d 100644
--- a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.SavedLinksListItemWidget.less
+++ b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.SavedLinksListItemWidget.less
@@ -17,8 +17,11 @@
 		// then the icon needs to be slightly smaller as well, so that
 		// when we toggle 'default' the icon doesn't bounce the option
 		// height up a little
-		width: 1.7em;
-		height: 1.7em;
+		width: 1.2em;
+		height: 1.2em;
+		min-width: 16px;
+		min-height: 16px;
+		opacity: 0.5;
 	}
 
 	&-icon span {
diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
index 3655c1647c..71e3b55c01 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
@@ -93,6 +93,7 @@
 		} );
 		this.$element.on( { click: this.onClick.bind( this ) } );
 		this.$label.on( { click: this.onClick.bind( this ) } );
+		this.$icon.on( { click: this.onDefaultIconClick.bind( this ) } );
 		// Prevent propagation on mousedown for the save button
 		// so the menu doesn't close
 		this.saveButton.$element.on( { mousedown: function () { return false; } } );
@@ -178,6 +179,18 @@
 			this.emit( 'click' );
 		}
 	};
+
+	/**
+	 * Respond to click on the 'default' icon. Open the submenu where the
+	 * default state can be changed.
+	 *
+	 * @return {boolean} false
+	 */
+	mw.rcfilters.ui.SavedLinksListItemWidget.prototype.onDefaultIconClick = function () {
+		this.menu.toggle();
+		return false;
+	};
+
 	/**
 	 * Respond to popup button click event
 	 */
-- 
2.20.1