From: S Page <spage@wikimedia.org>
Date: Sat, 12 Oct 2013 08:10:24 +0000 (-0700)
Subject: Revert visibility change to HTMLForm $typeMappings
X-Git-Tag: 1.31.0-rc.0~18533^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/journal.php?a=commitdiff_plain;h=f5980507cb19bb66b40ad508196b61a7c05b2bfa;p=lhc%2Fweb%2Fwiklou.git

Revert visibility change to HTMLForm $typeMappings

Change Id5668141835e22e3e1b043109e50d73ccd6b1229 changed the visibility
of static $typeMappings to private.  It turns out this breaks
http://www.blue-spice.org/ who want to add their own HTMLForm types and
have no way to extend or override this except by changing it.  So set it
to public static.

As https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP says,
"It's generally a good idea to avoid visibility changes unless you're
making changes to the function which would break old uses of it anyway."
That trumps PHP CodeSniffer warnings.

Change-Id: Ife82596e96a4650b977422aae6b32f24a392d5fb
---

diff --git a/includes/HTMLForm.php b/includes/HTMLForm.php
index 5de34d6712..70dc7c72db 100644
--- a/includes/HTMLForm.php
+++ b/includes/HTMLForm.php
@@ -94,7 +94,7 @@
 class HTMLForm extends ContextSource {
 
 	// A mapping of 'type' inputs onto standard HTMLFormField subclasses
-	private static $typeMappings = array(
+	public static $typeMappings = array(
 		'api' => 'HTMLApiField',
 		'text' => 'HTMLTextField',
 		'textarea' => 'HTMLTextAreaField',