From: Bryan Davis <bd808@wikimedia.org>
Date: Thu, 14 Apr 2016 20:08:38 +0000 (-0600)
Subject: SpecialRunJobs: delegate error handling to MWExceptionHandler
X-Git-Tag: 1.31.0-rc.0~7287^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/journal.php?a=commitdiff_plain;h=e827f9969738a7676082cd8ffa03f2462afe30dd;p=lhc%2Fweb%2Fwiklou.git

SpecialRunJobs: delegate error handling to MWExceptionHandler

Make the custom error handler that is installed to suppress Cookie
header errors delegate unhandled errors to the default MediaWiki error
handler. This will preserve fatal error logging for errors raised by
jobs.

Bug: T89169
Change-Id: I52ef544fa18351bf310b04b17ab4e0239020fe20
---

diff --git a/includes/specials/SpecialRunJobs.php b/includes/specials/SpecialRunJobs.php
index 2312f76399..ce5533fbf0 100644
--- a/includes/specials/SpecialRunJobs.php
+++ b/includes/specials/SpecialRunJobs.php
@@ -94,8 +94,11 @@ class SpecialRunJobs extends UnlistedSpecialPage {
 				if ( strpos( $errstr, 'Cannot modify header information' ) !== false ) {
 					return true; // bug T115413
 				}
-				// Delegate unhandled errors to the default handlers
-				return false;
+				// Delegate unhandled errors to the default MediaWiki handler
+				// so that fatal errors get proper logging (T89169)
+				return call_user_func_array(
+					'MWExceptionHandler::handleError', func_get_args()
+				);
 			} );
 		}