From: Aaron Schulz <aaron@users.mediawiki.org>
Date: Mon, 31 Mar 2008 18:01:39 +0000 (+0000)
Subject: Return '' to avoid vague cryptic error message when a user lacks permissions
X-Git-Tag: 1.31.0-rc.0~48709
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/journal.php?a=commitdiff_plain;h=dd724a817b1f0360d470030a0d502ace15387ffa;p=lhc%2Fweb%2Fwiklou.git

Return '' to avoid vague cryptic error message when a user lacks permissions
---

diff --git a/includes/DifferenceEngine.php b/includes/DifferenceEngine.php
index 0671fa0057..ee870225bd 100644
--- a/includes/DifferenceEngine.php
+++ b/includes/DifferenceEngine.php
@@ -426,9 +426,9 @@ CONTROL;
 		wfProfileIn( $fname );
 		// Check if the diff should be hidden from this user
 		if ( $this->mOldRev && !$this->mOldRev->userCan(Revision::DELETED_TEXT) ) {
-		  	return false;
+		  	return '';
 		} else if ( $this->mNewRev && !$this->mNewRev->userCan(Revision::DELETED_TEXT) ) {
-		  	return false;
+		  	return '';
 		}
 		// Cacheable?
 		$key = false;