From: umherirrender <umherirrender_de.wp@web.de>
Date: Thu, 17 Jul 2014 08:39:40 +0000 (+0200)
Subject: Add missing rollback to LocalFile::recordUpload2
X-Git-Tag: 1.31.0-rc.0~14909
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/journal.php?a=commitdiff_plain;h=d5d37cd034634156c494e7f3dd565895b98205ca;p=lhc%2Fweb%2Fwiklou.git

Add missing rollback to LocalFile::recordUpload2

When begin was called, all returns should have rollback called to
close the transaction.

Change-Id: I8197f73fb45c2e2900db6d5e588623f9b0c46ea5
---

diff --git a/includes/filerepo/file/LocalFile.php b/includes/filerepo/file/LocalFile.php
index a01895f0ff..1f2defec72 100644
--- a/includes/filerepo/file/LocalFile.php
+++ b/includes/filerepo/file/LocalFile.php
@@ -1268,6 +1268,7 @@ class LocalFile extends File {
 		# Fail now if the file isn't there
 		if ( !$this->fileExists ) {
 			wfDebug( __METHOD__ . ": File " . $this->getRel() . " went missing!\n" );
+			$dbw->rollback( __METHOD__ );
 			wfProfileOut( __METHOD__ );
 
 			return false;