From: Mukunda Modell <mmodell@wikimedia.org>
Date: Mon, 26 Jun 2017 16:27:23 +0000 (-0500)
Subject: Downgrade 'found writes/callbacks pending.' from error to info
X-Git-Tag: 1.31.0-rc.0~2880^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/journal.php?a=commitdiff_plain;h=148faa9f54aa703857f0a362664f33d514e38b24;p=lhc%2Fweb%2Fwiklou.git

Downgrade 'found writes/callbacks pending.' from error to info

This generates useless logspam and should be logged with a lower
log level.

Bug: T149353
Change-Id: If5e84b89eca098ac7f8c788ca3b0d268adf799fb
---

diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
index 0fc00a8ecb..0b70010e19 100644
--- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php
+++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php
@@ -1257,7 +1257,7 @@ class LoadBalancer implements ILoadBalancer {
 				// This happens if onTransactionIdle() callbacks leave callbacks on *another* DB
 				// (which finished its callbacks already). Warn and recover in this case. Let the
 				// callbacks run in the final commitMasterChanges() in LBFactory::shutdown().
-				$this->queryLogger->error( __METHOD__ . ": found writes/callbacks pending." );
+				$this->queryLogger->info( __METHOD__ . ": found writes/callbacks pending." );
 				return;
 			} elseif ( $conn->trxLevel() ) {
 				// This happens for single-DB setups where DB_REPLICA uses the master DB,