From: Brian Wolff <bawolff+wn@gmail.com>
Date: Wed, 16 Apr 2014 20:45:26 +0000 (-0300)
Subject: Output info in update.php for skipped updates due to shared tables
X-Git-Tag: 1.31.0-rc.0~16190^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/journal.php?a=commitdiff_plain;h=0bf4b4ec4f93937a43816c92ae7ae4cdda8e67d9;p=lhc%2Fweb%2Fwiklou.git

Output info in update.php for skipped updates due to shared tables

Can be kind of confusing for people to figure out why certain
updates didn't happen. I just had an irc conversation with
someone who didn't realize why their db wasn't fully updated.

Change-Id: I56223e70bdac8baaf079c28cbb1f0e20ef0336b8
---

diff --git a/includes/installer/DatabaseUpdater.php b/includes/installer/DatabaseUpdater.php
index 5223cd3319..b7a718f2bf 100644
--- a/includes/installer/DatabaseUpdater.php
+++ b/includes/installer/DatabaseUpdater.php
@@ -531,7 +531,12 @@ abstract class DatabaseUpdater {
 			return true;
 		}
 
-		return !in_array( $name, $wgSharedTables );
+		if ( in_array( $name, $wgSharedTables ) ) {
+			$this->output( "...skipping update to shared table $name.\n" );
+			return false;
+		} else {
+			return true;
+		}
 	}
 
 	/**