From be4e2e82600dd967fd055d5acee9b78f80d8b409 Mon Sep 17 00:00:00 2001 From: Alexandre Emsenhuber Date: Thu, 28 Jul 2011 20:42:56 +0000 Subject: [PATCH] Removed useless $out variable from Skin::getCopyright() --- includes/Skin.php | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/includes/Skin.php b/includes/Skin.php index 0871f2f7bc..dfdb2104f2 100644 --- a/includes/Skin.php +++ b/includes/Skin.php @@ -741,8 +741,6 @@ abstract class Skin extends ContextSource { $msg = 'copyright'; } - $out = ''; - if ( $wgRightsPage ) { $title = Title::newFromText( $wgRightsPage ); $link = Linker::linkKnown( $title, $wgRightsText ); @@ -752,7 +750,7 @@ abstract class Skin extends ContextSource { $link = $wgRightsText; } else { # Give up now - return $out; + return ''; } // Allow for site and per-namespace customization of copyright notice. @@ -761,12 +759,10 @@ abstract class Skin extends ContextSource { wfRunHooks( 'SkinCopyrightFooter', array( $this->getTitle(), $type, &$msg, &$link, &$forContent ) ); if ( $forContent ) { - $out .= wfMsgForContent( $msg, $link ); + return wfMsgForContent( $msg, $link ); } else { - $out .= wfMsg( $msg, $link ); + return wfMsg( $msg, $link ); } - - return $out; } function getCopyrightIcon() { -- 2.20.1