jenkins-bot [Mon, 11 Mar 2013 04:15:06 +0000 (04:15 +0000)]
Merge "Lots of spelling mistakes and phpdoc attributes"
Yuri Astrakhan [Mon, 11 Mar 2013 03:16:28 +0000 (23:16 -0400)]
Lots of spelling mistakes and phpdoc attributes
@throw->@throws
@returns->@return
@seealso->@see
@cover->@covers
etc
Change-Id: I9ae6bc3034e9790e2d66cd96473b923fe9ee7953
jenkins-bot [Sun, 10 Mar 2013 22:52:40 +0000 (22:52 +0000)]
Merge "Add "User rights management" link on user page toolbox"
JuneHyeon Bae [Sun, 10 Mar 2013 09:55:14 +0000 (18:55 +0900)]
Add "User rights management" link on user page toolbox
Bug: 34040
Change-Id: I507962161581c3d9ae928594d8d280be9a4ffbdd
jenkins-bot [Sun, 10 Mar 2013 22:23:03 +0000 (22:23 +0000)]
Merge "(bug 25325) fix wlexcludeuser for ApiFeedWatchlist"
Aaron Schulz [Sat, 9 Mar 2013 21:00:16 +0000 (13:00 -0800)]
More job queue doc tweaks.
Change-Id: I06bae67f67da23190c0576902767dc38a0d8ca5b
MatmaRex [Sun, 10 Mar 2013 21:08:22 +0000 (22:08 +0100)]
(bug 25325) fix wlexcludeuser for ApiFeedWatchlist
The effect of setting this option was later overwritten in the code; I
just moved an if a few lines down.
Also some null comparison cleanup.
Change-Id: I2a85673330681c6ff7facc25a7bbfb6972fe8fd5
Translation updater bot [Sun, 10 Mar 2013 20:16:52 +0000 (20:16 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I5efb53366137b0e6dceccf76a9cdaa3f7d77194f
jenkins-bot [Sun, 10 Mar 2013 14:13:29 +0000 (14:13 +0000)]
Merge "Kill off numerous unused variables"
jenkins-bot [Sat, 9 Mar 2013 22:41:41 +0000 (22:41 +0000)]
Merge "API param validation: Add wrong value to error message on user params"
jenkins-bot [Sat, 9 Mar 2013 21:40:12 +0000 (21:40 +0000)]
Merge "createaccount api action didn't handle no token and no cookie"
umherirrender [Sat, 9 Mar 2013 21:14:03 +0000 (22:14 +0100)]
API param validation: Add wrong value to error message on user params
It is always nice to get the wrong value back to know it.
Refactor a bit to avoid the array wrapping and unwrapping for non-multi
params.
Adjust another variable, add doc comments, removed a empty line and
reorder a condition for easy reading.
Change-Id: Ia91aa5908b82ad1209dc7da1139f91e1f2b45fac
Alexandre Emsenhuber [Sat, 9 Mar 2013 20:00:14 +0000 (21:00 +0100)]
Remove the page from the LinkCache before adding it again in WikiPage::loadFromRow()
This makes sure the LinkCache doesn't list a page both as good and bad link at the
same time, e.g. when a page gets created or deleted in the request.
Change-Id: I6774132ba8e4d28deed1908150c02fbaa42111a5
jenkins-bot [Sat, 9 Mar 2013 18:40:19 +0000 (18:40 +0000)]
Merge "Return user ID as userid in watchlist API module"
umherirrender [Sat, 9 Mar 2013 16:02:44 +0000 (17:02 +0100)]
Use ContextSource::getLanguage instead of $wgLang
Found two places, where $wgLang is used inside a ContextSource.
Change-Id: I1881a20d3cd9b50eb4af0cd588451ed941f936fa
Translation updater bot [Sat, 9 Mar 2013 15:09:18 +0000 (15:09 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I60a4f38e6b3459cbc2fb758615a311d67800d54d
jenkins-bot [Sat, 9 Mar 2013 14:40:24 +0000 (14:40 +0000)]
Merge "Use TargetLanguage of the Parser in ImageGallery"
jenkins-bot [Sat, 9 Mar 2013 14:04:58 +0000 (14:04 +0000)]
Merge "(Bug 34798) Synced the FeedUtils.php page with mediawiki.action.history.diff.css"
umherirrender [Sat, 9 Mar 2013 13:59:36 +0000 (14:59 +0100)]
Use TargetLanguage of the Parser in ImageGallery
If there is a parser set on ImageGallery, the target language of the
parser should be used, because this parsed piece of html can get into
the parser cache.
Change-Id: I2e47b316e3dcc6a3db4fb5d13f5065e35fc369dd
raymond [Sat, 9 Mar 2013 08:42:56 +0000 (09:42 +0100)]
Sync messages.inc with MessagesEn.php
rotate: Followup to Id15a92d19cda8256917e7e1e5ee4241012214102
pageswith props: sometimes earlier...
Change-Id: I8da23c89d5b1ebe669b4e4ef1e0d67ce8064a860
Brian Wolff [Sat, 9 Mar 2013 08:38:02 +0000 (04:38 -0400)]
createaccount api action didn't handle no token and no cookie
If you made a request to action=createaccount and this was
the first time (so no account creation token had yet been
generated for you) a "nocookiesfornew" error was returned.
This is incorrect, what is supposed to happen in that
case is the api returns what token to use. This is
how users are supposed to request tokens, so the
issue is very confusing.
No release notes since this module was introduced in
this version.
Also removed sessionfailure from possible errors,
as it isn't one (that status triggers the needtoken
result).
Change-Id: Ibfc3879fa89b1e11303aef65feb45a91afc215e6
Aaron Schulz [Sat, 9 Mar 2013 04:00:28 +0000 (20:00 -0800)]
Updated job queue README.
Change-Id: I8f884823cc5396e38bc5cd2f803f062a2dbdfac8
Matthew Bowker [Sat, 9 Mar 2013 06:35:03 +0000 (23:35 -0700)]
(bug 45922) Fix arbitrary inconsistency in page title and headings for message accmailtitle
bug: 459222
Change-Id: If582242f0473bce81a80f05d77421bdf6e5a3f29
rahul21 [Mon, 11 Feb 2013 19:22:24 +0000 (00:52 +0530)]
(Bug 34798) Synced the FeedUtils.php page with mediawiki.action.history.diff.css
->Added the background,border in diff-context,diff-addedline,diff-deleted line in $styles array in the FeedUtils.php
Change-Id: Icbfb6cfc659652c146e565b760d0815640fdad64
jenkins-bot [Fri, 8 Mar 2013 23:34:15 +0000 (23:34 +0000)]
Merge "(Bug 45854) Unset the cgroup if we don't have a memory limit"
jenkins-bot [Fri, 8 Mar 2013 22:54:28 +0000 (22:54 +0000)]
Merge "Fix more UnitTests for databases that do not use integer timestamps"
Translation updater bot [Fri, 8 Mar 2013 21:47:00 +0000 (21:47 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Icec7f2891935766ba5406d7932198b0f07a8a6d9
jenkins-bot [Fri, 8 Mar 2013 21:11:00 +0000 (21:11 +0000)]
Merge "Add the global correctly"
Brent Garber [Mon, 21 Jan 2013 23:01:05 +0000 (23:01 +0000)]
Fix more UnitTests for databases that do not use integer timestamps
Change-Id: I6f8b19aa6e6a9efc3320bb18fa8c7ec8b72a0c17
jenkins-bot [Fri, 8 Mar 2013 19:00:20 +0000 (19:00 +0000)]
Merge "Fixed $vCallback comment and removed unused return value."
Aaron Schulz [Fri, 8 Mar 2013 18:20:54 +0000 (10:20 -0800)]
[JobQueue] Made supportedOrders() protected.
Change-Id: I7237472d8281c06aff11c4644e9a59848c325263
Aaron Schulz [Fri, 8 Mar 2013 17:49:13 +0000 (09:49 -0800)]
Fixed $vCallback comment and removed unused return value.
Change-Id: If438d83e1b43c110b3c23e8d0a7705fa0795049f
umherirrender [Fri, 8 Mar 2013 16:09:06 +0000 (17:09 +0100)]
fix MessageCacheTest for non-english wikis
MessageCacheTest::addDBData is called before setUp, so wgLanguageCode
and wgContLang are not set to 'en', which result in mediawiki pages
created as $key/en. When the test runs, the language is set correctly
and mediawiki is searching under $key, and does not find anything.
Set wgLanguageCode and wgContLang at the begin of addDBData
1) MessageCacheTest::testMessageFallbacks with data set #0
('FallbackLanguageTest-Full', 'ab', 'ab')
Message fallback failed.
Failed asserting that false matches expected 'ab'.
Change-Id: I8e70b7b424df6a9ad98bfb6c228809f4b4437d1e
jenkins-bot [Fri, 8 Mar 2013 15:40:58 +0000 (15:40 +0000)]
Merge "Use output/error maintenance functions"
Platonides [Fri, 8 Mar 2013 11:59:56 +0000 (12:59 +0100)]
Add the global correctly
Change-Id: I03be0cf1e82fc9f8f00727bed5aca9d9d2758c2e
Platonides [Fri, 8 Mar 2013 09:51:55 +0000 (10:51 +0100)]
(Bug 45854) Unset the cgroup if we don't have a memory limit
We only create the cgroup if there's a memory limit, but it
tried to always cleanup it, regardless if it was used or not,
resulting in a «/sys/fs/cgroup/memory/mediawiki/job/32466/tasks:
No such file or directory» error, when run with MW_CGROUP='mediawiki';
MW_MEM_LIMIT=0
Change-Id: I7fdb545b336ead62aa743b1bc3afdbfba2c3113f
jenkins-bot [Fri, 8 Mar 2013 06:59:00 +0000 (06:59 +0000)]
Merge "Add SpecialPage::getGroupName and use it"
Aaron Schulz [Sun, 3 Mar 2013 04:41:38 +0000 (20:41 -0800)]
[JobQueue] Cleaned up handling of orders a bit.
Change-Id: I83d060e0db97d5bebf042041b0bd20563b093418
Aaron Schulz [Thu, 7 Mar 2013 06:45:59 +0000 (22:45 -0800)]
Removed "poolSize" option from RedisConnectionPool.
* The size is now automatically based on the number of servers.
Change-Id: I6ea53378c9c8254e8556c0a1e4efe64fd71ba356
Aaron Schulz [Thu, 21 Feb 2013 01:19:38 +0000 (17:19 -0800)]
[JobQueue] Added JobQueue::getAllQueuedJobs() function.
* Also added a small MappedIterator class for convenience.
Change-Id: I7dac1001a8e048cb524f7fbfee50a20a32e598ba
Reedy [Sat, 2 Feb 2013 18:15:47 +0000 (18:15 +0000)]
Use output/error maintenance functions
Change-Id: I9f9ebee9e577ab3cc7a042e5280161d2b2bad57a
Reedy [Sun, 9 Dec 2012 03:27:02 +0000 (03:27 +0000)]
Kill off numerous unused variables
Change-Id: I7039f1328f37ee669b694f73ee282602186bffd1
jenkins-bot [Fri, 8 Mar 2013 01:29:59 +0000 (01:29 +0000)]
Merge "mw.loader: Buffer cssText in addEmbeddedCSS."
jenkins-bot [Fri, 8 Mar 2013 01:28:06 +0000 (01:28 +0000)]
Merge "mw.loader: Create new style tags instead of appending text"
Kaldari [Thu, 7 Mar 2013 22:35:48 +0000 (14:35 -0800)]
Adding validation for checkmatrix (same as for multiselect)
Change-Id: I825ec8a6094405cf7d74597a0eeda3898981763b
Translation updater bot [Thu, 7 Mar 2013 22:02:23 +0000 (22:02 +0000)]
Merge "Localisation updates from translatewiki.net."
jenkins-bot [Thu, 7 Mar 2013 21:49:43 +0000 (21:49 +0000)]
Merge "Few more message parameter type hints"
Jan Gerber [Tue, 8 Jan 2013 11:35:55 +0000 (11:35 +0000)]
(bug 33186) image rotate api
add api action imagerotate to rotate images.
rotations are stored as a new version of the image.
Change-Id: Id15a92d19cda8256917e7e1e5ee4241012214102
Translation updater bot [Thu, 7 Mar 2013 21:32:10 +0000 (21:32 +0000)]
Localisation updates from translatewiki.net.
Change-Id: If4f63fa6338b3c1938b54a88857dfc5014d75372
Yuri Astrakhan [Thu, 7 Mar 2013 20:31:43 +0000 (15:31 -0500)]
Two typo-bugs, credits update
* ApiMain::addFormat() had a missed bug for custom formatters.
* ApiPageSet used incorrect variable
* Marked Roan as leading until 2009 (per IRC discussion)
* Updated my involvement to present
Change-Id: I5964bcdd3f82fedad06732df39f420796abe972b
umherirrender [Thu, 7 Mar 2013 20:15:54 +0000 (21:15 +0100)]
Add SpecialPage::getGroupName and use it
Having all group mapping for Special:SpecialPages in the global
$wgSpecialPageGroups is not a good OO style.
Created a method SpecialPage::getGroupName, which than can be overridden
by each subclasses to the featured group name.
Added also SpecialPage::getFinalGroupName to get the groupname on
Special:SpecialPages to handle the customization and
to keep $wgSpecialPageGroups for b/c
Change-Id: I1de3a186f0a59ec5ecb8996c5f805cf164e9637f
jenkins-bot [Thu, 7 Mar 2013 18:07:43 +0000 (18:07 +0000)]
Merge "Docs for gerrit 47419"
Reedy [Thu, 7 Mar 2013 17:59:48 +0000 (17:59 +0000)]
Merge "[FileBackend] Added a "ttl" option to getFileHttpUrl()."
Matthias Mullie [Thu, 7 Mar 2013 17:54:12 +0000 (18:54 +0100)]
Docs for gerrit 47419
Change-Id: I021b7250418e60397127e1778107ee3da77ffb18
jenkins-bot [Thu, 7 Mar 2013 17:34:05 +0000 (17:34 +0000)]
Merge "Read full memcached response before manipulating data"
jenkins-bot [Thu, 7 Mar 2013 17:13:27 +0000 (17:13 +0000)]
Merge "fix some spacing"
umherirrender [Thu, 7 Mar 2013 16:50:43 +0000 (17:50 +0100)]
fix some spacing
Added/removed spaces around logical/arithmetic operator
Reduced multiple empty lines to one empty line
Removed wrong tabs before comments at end of line
Removed too many spaces in assigments
Change-Id: I2bba4e72f9b5f88c53324d7b70e6042f1aad8f6b
umherirrender [Thu, 7 Mar 2013 16:27:38 +0000 (17:27 +0100)]
Fix align of block comments
Change-Id: I88ea33a125a71671886b49e4ebf4c1d0a1cce572
jenkins-bot [Thu, 7 Mar 2013 15:27:36 +0000 (15:27 +0000)]
Merge "(bug 1495) Enable on-wiki message language fallbacks"
Matthias Mullie [Mon, 4 Feb 2013 16:54:53 +0000 (17:54 +0100)]
Read full memcached response before manipulating data
Memcached response when fetching data typically looks like this:
VALUE <the stored value for whatever key you requested>
END
What the code used to do is read the first line (the VALUE) and re-
assemble the data being fetched there (like unserializing serialized
data). After that, it will read the next line (END).
The value could be a serialized object, which could have a __wakeup.
This __wakeup could have code which in turn executes Memcached-
related stuff. The problem is that, while that object is being
unserialized already, it's wakeup code is attempting to read new
stuff from Memcached, but we have yet to read the END of the data
we're attempting to unserialize (when we'll read a new value from
Memcached, the first thing we'd get is the END we have not yet read..)
The correct way to go about this would be to first read the full
Memcached response, and only unserialize the read data after that.
This is exactly what this patchset does.
Change-Id: I902809c6dde657091c8161a09df823170bd41f7a
shirayuki [Thu, 7 Mar 2013 10:59:24 +0000 (19:59 +0900)]
Changing position of colon
Change-Id: I5a973a04221f730c3b6cb4e1abf1a6d0bd95d107
raymond [Thu, 7 Mar 2013 08:27:02 +0000 (09:27 +0100)]
Add full stop to full sentences
Change-Id: I3182c093ce582fb24db1fd8216aa9b9e756edf9a
Alex Monk [Sun, 3 Mar 2013 22:51:27 +0000 (22:51 +0000)]
Remove the mediawiki.api.titleblacklist module
Moved to the TitleBlacklist extension in I5bf7064a.
Bug: 38244
Change-Id: Ia595085371615da057aaa358d76929916a3e2186
Krinkle [Thu, 7 Mar 2013 06:19:33 +0000 (06:19 +0000)]
Merge "Revert "(bug 45677) CSSJanus: support text-shadow and box-shadow flipping""
Krinkle [Thu, 7 Mar 2013 06:19:26 +0000 (06:19 +0000)]
Revert "(bug 45677) CSSJanus: support text-shadow and box-shadow flipping"
See I5d24c7d8456e2. This is a wontfix per Trevor and myself.
This reverts commit
e457d804eb6f854baf5edfd022ce217d53d6e946
Change-Id: I886a078cbeedd5a742e9c6dfedc9bd718bab089c
Aaron Schulz [Thu, 7 Mar 2013 04:47:30 +0000 (20:47 -0800)]
[FileBackend] Added a "ttl" option to getFileHttpUrl().
Change-Id: Ifc7b9c012276ed1f1e436ffafbd5615689680054
Timo Tijhof [Thu, 7 Mar 2013 00:24:05 +0000 (01:24 +0100)]
mw.loader: Buffer cssText in addEmbeddedCSS.
I52252e699a improved the repaint situation (bug 45810) a
bit, but not as much as we hoped. Inserting a stylesheet and
applying it to the page is a fairly expensive operation.
Invalidating the previous one in the process didn't help, but
fixing that didn't make a lot of difference.
This is a much more significant improvement by reducing the
number of <style> tags in the first place.
When a load.php request is handled, it reponds with many
mw.loader.implement() calls, one directly after the other
(not asynchronous in any way).
In the long term we could change the server side to combine
these better but for now the easiest fix with the largest gain
is to buffer it, yield once, and then insert it all at once.
This means we insert only one <style> for each load.php request.
Bug: 45810
Change-Id: I430fba9998b133a85dd3ac38237dc44b38630a9c
Timo Tijhof [Wed, 6 Mar 2013 23:02:51 +0000 (00:02 +0100)]
mw.loader: Create new style tags instead of appending text
As brought to our attention by Chromium/WebKit developers at Google,
when we fixed bug 31676 (IE stylesheet limit) by appending to
<style> whenever we can (i.e. whenever the received stylesheet
does not involve @import which only works on top of the a
stylesheet) – this is causing several slowdowns.
Which build up on mobile to several dozen seconds in pages
with a lot of content and many modules being loaded.
Appending a text node to a <style> tag, while it doesn't require
the DOM to do anything fancy (no need to reparse the contents).
The stylesheet handler of the browser has to re-parse the css text
after each modification as the css syntax is too tolerant to be
able to just pick up parsing again (at least, as of writing
neither Gecko or WebKit are able to do so).
As a result, the stylesheet is invalidated, re-parsed and
re-applied to the page.
So instead default the other way around and only re-use a <style>
tag if we have to do so for IE.
Bug: 45810
Change-Id: I52252e699a518dc1c1327ee598a9e023cc2555e2
Brad Jorsch [Wed, 30 Jan 2013 00:57:56 +0000 (19:57 -0500)]
(bug 33304) Fix ApiQueryAllPages and old indef protections
In the query to find only protected pages, ApiQueryAllPages includes a
clause to make sure it doesn't find expired protections. But it doesn't
take into account the possibility that the protection might be an old
infinite protection where the expiry is represented as NULL instead of
'infinity'.
Note this may not close the whole bug; that remains to be determined.
Bug: 33304
Change-Id: If85591986a19bf78f7d56ad60d251fbc450ac451
jenkins-bot [Thu, 7 Mar 2013 01:01:39 +0000 (01:01 +0000)]
Merge "Few minor parameter type hints in documentation"
Aaron Schulz [Wed, 6 Mar 2013 23:19:23 +0000 (15:19 -0800)]
Made syncFileBackend.php clearer with handling --postime.
Change-Id: I9462fb2aeef0597c3a7a0d1b0b4856ffea2460f6
jenkins-bot [Wed, 6 Mar 2013 22:50:39 +0000 (22:50 +0000)]
Merge "Resolve config defaults in RedisConnectionPool in the singleton()."
jenkins-bot [Wed, 6 Mar 2013 22:26:42 +0000 (22:26 +0000)]
Merge "Don't set wgPostEdit for null edits."
jenkins-bot [Wed, 6 Mar 2013 21:28:11 +0000 (21:28 +0000)]
Merge "Maintain the page ID in WikiPage instead of relying on Title"
Reedy [Wed, 6 Mar 2013 01:25:45 +0000 (01:25 +0000)]
Few more message parameter type hints
Change-Id: I9017170a434b8924692e04410acc88831237ef8d
Translation updater bot [Wed, 6 Mar 2013 21:02:21 +0000 (21:02 +0000)]
Merge "Localisation updates from translatewiki.net."
Translation updater bot [Wed, 6 Mar 2013 20:44:33 +0000 (20:44 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I34195aefb7ae833e983cd0e2612d3af6c29414c1
jenkins-bot [Wed, 6 Mar 2013 20:39:42 +0000 (20:39 +0000)]
Merge "Force $wgCategoryCollation to be uppercase in tests"
Matthew Flaschen [Wed, 6 Mar 2013 20:32:56 +0000 (12:32 -0800)]
Don't set wgPostEdit for null edits.
Bug: 45781
Change-Id: Ia2c3e02304fad07425af520850fe30ca5eab0c8e
jenkins-bot [Wed, 6 Mar 2013 20:13:37 +0000 (20:13 +0000)]
Merge changes I97273c52,I560d766f
* changes:
adjusted comments for IcuCollation::$tailoringFirstLetters
language-specific collations: be-tarask added; be, be-tarask, ru verified
Trevor Parscal [Wed, 6 Mar 2013 20:00:36 +0000 (20:00 +0000)]
Merge "Vector: Don't create an extra request for skins.vector module"
Matthew Walker [Wed, 16 Jan 2013 07:28:54 +0000 (23:28 -0800)]
(bug 1495) Enable on-wiki message language fallbacks
The core function behind wfMessage() (MessageCache->get()) did not
apply the language fallback chain to on-wiki messages.
This patch has changed the behavior to iterate over all possible
on-wiki fallbacks (starting with the user's language) before
using the built-in language cache (CDB files). Previously we only looked
for the existence of an on-wiki message in the users's language.
Performance wise, using the 'ab' language ('ru', 'en' fallbacks)
MessageCache::get (Averaged over runs and calls)
New Code: ~8.5% TET (110us/call)
Old Code: ~6.5% TET ( 90us/call)
TET: Total Execution Time
Change-Id: Iaaf6ccebd8c40c9602748c58c3a5c73c29e7aa4d
umherirrender [Wed, 6 Mar 2013 19:15:43 +0000 (20:15 +0100)]
Remove german special page alias for 'Version'
The english alias was also used years in german, because it means the
same, so there is no need for a alias/translation. But translatewiki.net
does not allow aliases, which are the same than the english word. That
means the field on Special:AdvancedTranslate is empty and animated
people to fill it.
Follow up Id1400249 (same release, so removing should not be a problem)
Change-Id: I7a451b5cf1c973b0b04270335ff31f81271f27a2
jenkins-bot [Wed, 6 Mar 2013 15:19:45 +0000 (15:19 +0000)]
Merge "American spelling - recognize/customize"
shirayuki [Tue, 5 Mar 2013 23:28:07 +0000 (08:28 +0900)]
American spelling - recognize/customize
Change-Id: I41b2f8113cf84e16430c1f59a76acbb539269833
jenkins-bot [Wed, 6 Mar 2013 11:50:28 +0000 (11:50 +0000)]
Merge "Changing position of colon for consistency"
jenkins-bot [Wed, 6 Mar 2013 09:00:26 +0000 (09:00 +0000)]
Merge "Use American English spelling for behavior"
Ori Livneh [Sat, 2 Mar 2013 00:34:09 +0000 (16:34 -0800)]
Make default params to CategoryViewer usable as defaults.
If the '$from' and '$to' parameters to the CategoryViewer constructor are left
off, they default to empty arrays. This makes later checks for $from['page'],
etc. issue an 'Undefined index' notice.
Using 'empty' would be more concise but could hide bugs.
Change-Id: I78793d13745d1fc1010b8e6861bdc3a89a39a87f
mwjames [Mon, 5 Nov 2012 10:24:52 +0000 (19:24 +0900)]
Extend the SpecialStatsAddExtra hook for a more distinct display of extra items
The current approach leaves not much room for a meaningful
display of varying extra statistical items nor its ability to display
a special page link as item name.
The change proposed allows for varying header titles as well as
item descriptions using the standard language parser. The proposed
change uses is similar approach as in the InfoAction hook. A item
now is specified as [<header-message>][<item-message>] = number
Use === array() check instead of a count() and continue legacy support
for the single array structure used prio 1.21.
Change-Id: I78107c72953878c86d221fb6f83baff5f6c11f09
jenkins-bot [Wed, 6 Mar 2013 06:15:27 +0000 (06:15 +0000)]
Merge "normalize filenames of maintenance scripts"
jenkins-bot [Wed, 6 Mar 2013 06:06:10 +0000 (06:06 +0000)]
Merge "(bug 45201) Add option to pass defaultNamespace to ApiPageSet"
jenkins-bot [Wed, 6 Mar 2013 04:22:57 +0000 (04:22 +0000)]
Merge "Add CategoryAfterPageAdded / CategoryAfterPageRemoved hooks"
jenkins-bot [Wed, 6 Mar 2013 04:21:10 +0000 (04:21 +0000)]
Merge "Made runJobs.php wait for slave lag."
jenkins-bot [Wed, 6 Mar 2013 04:14:08 +0000 (04:14 +0000)]
Merge "(bug 40326) Check if files exist with a different extension during uploading"
Ori Livneh [Tue, 5 Mar 2013 22:43:03 +0000 (14:43 -0800)]
Add CategoryAfterPageAdded / CategoryAfterPageRemoved hooks
My first instinct was to derive the hook signature from the implementation and
have a generic 'PageCategoriesUpdated' hook that receives the WikiPage object
and two arrays ($added, $deleted). After some reflection I decided to iterate
through each array and call the hook once per category. I like this way of
doing things because a change in page membership could be thought of from two
directions: it is either the category that is gaining or losing a member, or
the page that is gaining or losing a category.
The category name is sufficient for instantiating a Category object without
additional queries being needed, so my preference was to pass objects rather
than string identifiers.
If implementors of handlers happen to be interested in the set of categories or
pages being updated, it is still the case that they only need to write one
function, and track state using a class property.
Change-Id: Ica4c5fb3acdea6c00678ec0794808fa50a1dd39a
Aaron Schulz [Mon, 25 Feb 2013 17:55:32 +0000 (09:55 -0800)]
Made runJobs.php wait for slave lag.
* Relying on waitForBackups() alone will not work with non DB queues.
Change-Id: I2124c5cd11a70d183cfde00ad21d6642a3a0ee9e
Waldir Pimenta [Mon, 11 Feb 2013 09:58:42 +0000 (09:58 +0000)]
normalize filenames of maintenance scripts
Use lowerCamelCase.php format for all files (per [[mw:CC#File_naming]]),
and make filenames more specific:
- clear_stats.php -> clearCacheStats.php
- clear_interwiki_cache.php -> clearInterwikiCache.php
- initStats.php -> initSiteStats.php
- proxy_check.php -> proxyCheck.php
- stats.php -> showCacheStats.php
- showStats.php -> showSiteStats.php
Also changed the class names accordingly (per [[mw:CC/PHP#Naming]]),
and make class names more specific:
- clear_stats -> ClearCacheStats
- InitStats -> InitSiteStats
- CacheStats -> ShowCacheStats
- ShowStats -> ShowSiteStats
Updated files that made references to the changed files/classes:
- DefaultSettings.php and SpecialBlockme.php (proxy_check.php -> proxyCheck.php)
- maintenance/showSiteStats.php (initStats.php -> initSiteStats.php)
- maintenance/README and docs/memcached.txt (stats.php -> showCacheStats.php)
- docs/maintenance.txt and docs/memcached.txt (clear_stats.php -> clearCacheStats.php)
Thanks Hashar for the initial help and encouragement :)
Change-Id: I60f76fc971e06e1b710dcda35f9c2d931b93bdd7
jenkins-bot [Wed, 6 Mar 2013 03:55:07 +0000 (03:55 +0000)]
Merge "(bug 37352) Boolean issue when using sqlite."
btongminh [Wed, 6 Feb 2013 20:15:07 +0000 (21:15 +0100)]
(bug 40326) Check if files exist with a different extension during
uploading
Added FileRepo::findFilesByPrefix( $prefix ), which does a img_name LIKE
'$prefix%' search and use this in UploadBase::getExistsWarning().
Change-Id: I21eddc5d08ca3c23b342ebc1c6947e36c4201a45
nischayn22 [Tue, 22 Jan 2013 04:28:14 +0000 (09:58 +0530)]
(bug 37352) Boolean issue when using sqlite.
using a type cast instead, otherwise an empty string gets converted to
true when set with bool type.
Change-Id: I4161de32151a649161ab4084e80cafe4a462c7d5