Merge "(bug 38093) Gender of changed user groups missing in log"

diff --combined RELEASE-NOTES-1.20
index a9bdeb7,7b073aa..0fc818d
--- 1/RELEASE-NOTES-1.20
--- 2/RELEASE-NOTES-1.20
+++ b/RELEASE-NOTES-1.20
@@@ -23,15 -23,11 +23,15 @@@ upgrade PHP if you have not done so pri
  * The user right 'upload_by_url' is no longer given to sysops by default.
    This only affects installations which have $wgAllowCopyUploads set to true.
  * Removed f-prot support from $wgAntivirusSetup.
 +* $wgDBerrorLogInUTC to log error in $wgDBerrorLog using an UTC date instead
 +  of the wiki timezone set by $wgLocalTimezone.
  
  === New features in 1.20 ===
  * Added TitleIsAlwaysKnown hook which gets called when determining if a page exists.
  * Added NamespaceIsMovable hook which gets called when determining if pages in a
    certain namespace can be moved.
 +* Added SpecialPageBeforeExecute hook which gets called before SpecialPage::execute.
 +* Added SpecialPageAfterExecute hook which gets called after SpecialPage::execute.
  * (bug 32341) Add upload by URL domain limitation.
  * &useskin=default will now always display the default skin. Useful for users with a
    preference for the non-default skin to look at something using the default skin.
@@@ -94,7 -90,6 +94,7 @@@
    replacement, and so on.
  * (bug 34678) Added InternalParseBeforeSanitize hook which gets called during Parser's
    internalParse method just before the parser removes unwanted/dangerous HTML tags.
 +* (bug 36783) Implement jQuery Promise interface in mediawiki.api module.
  
  === Bug fixes in 1.20 ===
  * (bug 30245) Use the correct way to construct a log page title.
@@@ -163,6 -158,7 +163,7 @@@
  * (bug 38152) jquery.tablesorter: Use .data() instead of .attr(), so that live
    values are used instead of just the fixed values from when the tablesorter
    was initialized.
+ * (bug 38093) Gender of changed user groups missing in Special:Log/rights
  
  === API changes in 1.20 ===
  * (bug 34316) Add ability to retrieve maximum upload size from MediaWiki API.
@@@ -174,21 -170,21 +175,21 @@@
  * (bug 32497) API now allows changing of protection level using pageid.
  * (bug 32498) API now allows comparing pages using pageids.
  * (bug 30975) API import of pages with invalid characters in this wiki leads to Fatal Error.
 -* (bug 30488) API now allows listing of backlinks/embeddedin/imageusage per pageid
 -* (bug 34927) Output media_type for list=filearchive
 -* (bug 28814) add properties to output of action=parse
 -* (bug 33224) add variants of content language to meta=siteinfo
 -* (bug 36761) "Mark pages as visited" now submits previously established filter options
 -* (bug 32643) action=purge with forcelinkupdate no longer crashes when ratelimit is reached
 -* The paraminfo module now also contains result properties for most modules
 -* (bug 32348) Allow descending order for list=alllinks
 -* (bug 31777) Upload unknown error ``fileexists-forbidden''
 -* (bug 32382) Allow descending order for list=iwbacklinks
 -* (bug 32381) Allow descending order for list=backlinks, list=embeddedin and list=imageusage
 -* (bug 32383) Allow descending order for list=langbacklinks
 -* API meta=siteinfo can now return the list of known variable IDs
 -* (bug 30836) siteinfo prop=specialpagealiases will no longer return nonexistent special pages
 -* (bug 35980) list=deletedrevs now honors drdir correctly in "all" mode (mode #3)
 +* (bug 30488) API now allows listing of backlinks/embeddedin/imageusage per pageid.
 +* (bug 34927) Output media_type for list=filearchive.
 +* (bug 28814) add properties to output of action=parse.
 +* (bug 33224) add variants of content language to meta=siteinfo.
 +* (bug 36761) "Mark pages as visited" now submits previously established filter options.
 +* (bug 32643) action=purge with forcelinkupdate no longer crashes when ratelimit is reached.
 +* The paraminfo module now also contains result properties for most modules.
 +* (bug 32348) Allow descending order for list=alllinks.
 +* (bug 31777) Upload unknown error ``fileexists-forbidden''.
 +* (bug 32382) Allow descending order for list=iwbacklinks.
 +* (bug 32381) Allow descending order for list=backlinks, list=embeddedin and list=imageusage.
 +* (bug 32383) Allow descending order for list=langbacklinks.
 +* API meta=siteinfo can now return the list of known variable IDs.
 +* (bug 30836) siteinfo prop=specialpagealiases will no longer return nonexistent special pages.
 +* (bug 35980) list=deletedrevs now honors drdir correctly in "all" mode (mode #3).
  
  === Languages updated in 1.20 ===
  

diff --combined includes/logging/LogPage.php
index 9bb7eb1,351e9f4..cf921b0
--- 1/includes/logging/LogPage.php
--- 2/includes/logging/LogPage.php
+++ b/includes/logging/LogPage.php
@@@ -255,9 -255,12 +255,12 @@@ class LogPage 
                                        $rightsnone = wfMsgExt( 'rightsnone', array( 'parsemag', 'language' => $langObj ) );
  
                                        if( $skin ) {
+                                               $username = $title->getText();
                                                foreach ( $params as &$param ) {
                                                        $groupArray = array_map( 'trim', explode( ',', $param ) );
-                                                       $groupArray = array_map( array( 'User', 'getGroupMember' ), $groupArray );
+                                                       foreach( $groupArray as &$group ) {
+                                                               $group = User::getGroupMember( $group, $username );
+                                                       }
                                                        $param = $wgLang->listToText( $groupArray );
                                                }
                                        }
@@@ -417,8 -420,7 +420,8 @@@
                                        # Use the language name for log titles, rather than Log/X
                                        if( $name == 'Log' ) {
                                                $titleLink = Linker::link( $title, LogPage::logName( $par ) );
 -                                              $titleLink = wfMessage( 'parentheses' )->rawParams( $titleLink )->escaped();
 +                                              $titleLink = wfMessage( 'parentheses' )->inLanguage( $lang )
 +                                                      ->rawParams( $titleLink )->escaped();
                                        } else {
                                                $titleLink = Linker::link( $title );
                                        }
@@@ -552,8 -554,7 +555,8 @@@
                        for( $i = 0; $i < count( $flags ); $i++ ) {
                                $flags[$i] = self::formatBlockFlag( $flags[$i], $lang );
                        }
 -                      return wfMessage( 'parentheses' )->rawParams( $lang->commaList( $flags ) )->escaped();
 +                      return wfMessage( 'parentheses' )->inLanguage( $lang )
 +                              ->rawParams( $lang->commaList( $flags ) )->escaped();
                } else {
                        return '';
                }