From b5d46d22b5e49b76fb51fdd7e666c69efb4e1afe Mon Sep 17 00:00:00 2001 From: Geoffrey Mon Date: Sat, 6 Jun 2015 21:03:37 -0400 Subject: [PATCH] Disable Preferences save button before setting change Disable the Special:Preferences 'Save' button if no settings have been changed (uses keydown and mousedown events as an alternative to change event, so is not perfect) This prevents unnecessary saving when you can't remember if you saved the settings or not. Bug: T89457 Change-Id: I7c2e11302099280c561e435425b23afb9fb760b5 --- .../src/mediawiki.special/mediawiki.special.preferences.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/resources/src/mediawiki.special/mediawiki.special.preferences.js b/resources/src/mediawiki.special/mediawiki.special.preferences.js index fa9e45275a..a385ad31af 100644 --- a/resources/src/mediawiki.special/mediawiki.special.preferences.js +++ b/resources/src/mediawiki.special/mediawiki.special.preferences.js @@ -110,6 +110,12 @@ jQuery( function ( $ ) { $preftoc.append( $li ); } ); + // Disable the button to save preferences unless preferences have changed + $( '#prefcontrol' ).prop( 'disabled', true ); + $( '.prefsection' ).one( 'change keydown mousedown', function () { + $( '#prefcontrol' ).prop( 'disabled', false); + } ); + // Enable keyboard users to use left and right keys to switch tabs $preftoc.on( 'keydown', function ( event ) { var keyLeft = 37, -- 2.20.1