From ae9c32b508dd8e3c6929c658d91542cbcdfbab5d Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Tue, 26 Jun 2018 16:24:31 +0100 Subject: [PATCH] resourceloader: Add test for getVersionHash parent-definition requirement Change-Id: I69cdfea96c1e64bd8a7495eb6e56d0aefbe37643 --- .../resourceloader/ResourceLoaderModuleTest.php | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php b/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php index 0ea4e2bd63..c9253392cb 100644 --- a/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php +++ b/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php @@ -64,6 +64,19 @@ class ResourceLoaderModuleTest extends ResourceLoaderTestCase { ); } + /** + * @covers ResourceLoaderModule::getVersionHash + */ + public function testGetVersionHash_parentDefinition() { + $context = $this->getResourceLoaderContext(); + $module = $this->getMockBuilder( ResourceLoaderModule::class ) + ->setMethods( [ 'getDefinitionSummary' ] )->getMock(); + $module->method( 'getDefinitionSummary' )->willReturn( [ 'a' => 'summary' ] ); + + $this->setExpectedException( LogicException::class, 'must call parent' ); + $module->getVersionHash( $context ); + } + /** * @covers ResourceLoaderModule::validateScriptFile */ -- 2.20.1