From 7dec3ae8477c4c62cee4a4a116f5f94bceeb0f85 Mon Sep 17 00:00:00 2001 From: Moriel Schottlender Date: Fri, 21 Jul 2017 14:50:30 -0700 Subject: [PATCH] RCFilters: Don't empty the changes list on first load jQuery.empty() apparently also unattaches event handlers. Only empty before we re-append if we are not in the first load of the changes list. Bug: T171085 Change-Id: I68754e99a6c5c821be47b1b1e8e22f23db85746c --- .../ui/mw.rcfilters.ui.ChangesListWrapperWidget.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js index 6512f04f68..0e9e843be1 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js @@ -125,7 +125,9 @@ this.$element.append( $message ); } else { this.$changesListContent = $changesListContent; - this.$element.empty().append( this.$changesListContent ); + if ( !isInitialDOM ) { + this.$element.empty().append( this.$changesListContent ); + } // Set up highlight containers this.setupHighlightContainers( this.$element ); -- 2.20.1