From 6bb00b92bbbf15359a770f26cd3dab5fb0d16ccd Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Wed, 17 Aug 2016 09:11:51 -0700 Subject: [PATCH] phpunit: Add @covers to ObjectFactoryTest * expandClosures() wasn't covered at all. Make the test dedicated to this feature cover that method. * constructClassInstance() coverage was almost complete except for the exception case. This was covered in a separate test, but it was missing its @covers tag. Change-Id: I73252849a92440fd7ae2c44f9ca58f7bf9c1f92c --- tests/phpunit/includes/libs/ObjectFactoryTest.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/phpunit/includes/libs/ObjectFactoryTest.php b/tests/phpunit/includes/libs/ObjectFactoryTest.php index a4871a64c4..043be4e17c 100644 --- a/tests/phpunit/includes/libs/ObjectFactoryTest.php +++ b/tests/phpunit/includes/libs/ObjectFactoryTest.php @@ -44,6 +44,7 @@ class ObjectFactoryTest extends PHPUnit_Framework_TestCase { /** * @covers ObjectFactory::getObjectFromSpec + * @covers ObjectFactory::expandClosures */ public function testClosureExpansionEnabled() { $obj = ObjectFactory::getObjectFromSpec( [ @@ -110,6 +111,7 @@ class ObjectFactoryTest extends PHPUnit_Framework_TestCase { } /** + * @covers ObjectFactory::constructClassInstance * @expectedException InvalidArgumentException */ public function testNamedArgs() { -- 2.20.1