Mark A. Hershberger [Sat, 2 Apr 2011 04:49:29 +0000 (04:49 +0000)]
Fix Bug#24308 where, on some platforms the date_create() function fails when the timezone isn't specified.
Sam Reed [Sat, 2 Apr 2011 00:27:03 +0000 (00:27 +0000)]
Remove unused global, fix double defined global
Sam Reed [Sat, 2 Apr 2011 00:26:40 +0000 (00:26 +0000)]
Fix casing of SpecialListUsers
Happy-melon [Fri, 1 Apr 2011 23:13:15 +0000 (23:13 +0000)]
Follow-up r85025: fix the you're-trying-to-block-yourself-you-twit warning, and make it an actual checkbox confirmation. Also use said confirmation for reblocks, and HideUser (bug 18678). Mark a static function from HTMLForm which is called from SpecialBlock as explicitly public.
Brion Vibber [Fri, 1 Apr 2011 21:14:52 +0000 (21:14 +0000)]
Memory stress test for UtfNormal issue re bug 28146
This pulls the source texts used for the UtfNormalBench.php benchmarks, repeats them into much larger strings, and attempts to reproduce an out-of-memory error in the middle of UtfNormal::cleanUp():
$ php
Testing testdata/washington.txt (English text)...
quickIsNFCVerify 1078.3ms 14,969,652 bytes/s (changed)
cleanUp 992.1ms 16,270,594 bytes/s (no change)
Testing testdata/berlin.txt (German text)...
PHP Fatal error: Allowed memory size of
136314880 bytes exhausted (tried to allocate 71 bytes) in /var/www/trunk/includes/normal/UtfNormal.php on line 285
Exact failure point may require adjustment depending on platform, etc.
Raimond Spekking [Fri, 1 Apr 2011 20:53:41 +0000 (20:53 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-01 20:38:00 UTC)
Trevor Parscal [Fri, 1 Apr 2011 20:48:50 +0000 (20:48 +0000)]
Added charset property to HTTP Content-Type fields when serving CSS and JavaScript via ResourceLoader - resolves bug #28208.
Niklas Laxström [Fri, 1 Apr 2011 19:30:08 +0000 (19:30 +0000)]
Reword this message per IRC cabbage
Max Semenik [Fri, 1 Apr 2011 18:24:37 +0000 (18:24 +0000)]
We developers are so elitist, running shiny machines with all PHP extensions in the world installed, that we couldn't notice that "no scaler found" message didn't work from the beginning! :P
Trevor Parscal [Fri, 1 Apr 2011 18:05:15 +0000 (18:05 +0000)]
Fixed issue where reference error can be thrown - response to comments on r84985
Sam Reed [Fri, 1 Apr 2011 17:29:15 +0000 (17:29 +0000)]
Followup r84825
Allow obtaining of an import token if users have the importupload right
Chad Horohoe [Fri, 1 Apr 2011 15:57:20 +0000 (15:57 +0000)]
Revert r64853 (add $wgLogAutocreatedAccounts to enable/disable account autocreation logging, bug 19161). Per the *extremely lengthy* discussion that is still ongoing, this fails to solve the underlying problem and has undesired side-effects.
I don't know what the proper solution is (other than introducing user preferences, like bug 28369 suggests, is not the answer)...but the status quo of what we had is better than this half-assed solution that *nobody* likes.
Aryeh Gregor [Fri, 1 Apr 2011 14:50:29 +0000 (14:50 +0000)]
Document what settings are disabled by $wgHtml5
Bug 28350.
Purodha B Blissenbach [Fri, 1 Apr 2011 11:28:18 +0000 (11:28 +0000)]
Fix for r85114, see code reviev
at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85114
Purodha B Blissenbach [Fri, 1 Apr 2011 10:46:56 +0000 (10:46 +0000)]
Fix r85110, see code review
at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85110
Alexandre Emsenhuber [Fri, 1 Apr 2011 09:50:09 +0000 (09:50 +0000)]
Drop 5.1 compatibility calls to session_set_cookie_params() and setcookie() since we require 5.2.3+ now
Purodha B Blissenbach [Fri, 1 Apr 2011 09:35:44 +0000 (09:35 +0000)]
Add optional PLURAL parameter to messages 'userrights-changeable-col' and 'userrights-unchangeable-col'
Alexandre Emsenhuber [Fri, 1 Apr 2011 09:35:39 +0000 (09:35 +0000)]
Moved constant initialisation to class definition instead of constructor
Brion Vibber [Thu, 31 Mar 2011 23:40:51 +0000 (23:40 +0000)]
* (bug 27893) Edit-on-doubleclick now applies only on view and purge actions;
no longer triggers unexpectedly on delete, history etc.
Purodha B Blissenbach [Thu, 31 Mar 2011 23:23:11 +0000 (23:23 +0000)]
Fix omission of r85007,
see code review at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85007
Happy-melon [Thu, 31 Mar 2011 23:09:02 +0000 (23:09 +0000)]
Fix for r85005: the getUserPermissionsErrors() calls were each returning a badaccess error when the user didn't have their particular permission, even if they had the other one, exclude these errors since they're already covered by the $user->isAllowedAny() check above. Also fix processForm() to check isAllowed('import') for transwiki; this wasn't being done which meant users with importupload but not import (an unlikely combination to be fair) could still spoof the form.
Brion Vibber [Thu, 31 Mar 2011 23:02:38 +0000 (23:02 +0000)]
Tweak doc comment per bug 28340
Ryan Lane [Thu, 31 Mar 2011 21:16:22 +0000 (21:16 +0000)]
This script didn't actually work, and was a live hack. This is a followup to the fixme in r79021.
Raimond Spekking [Thu, 31 Mar 2011 19:42:16 +0000 (19:42 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-31 19:24:00 UTC)
Max Semenik [Thu, 31 Mar 2011 14:11:42 +0000 (14:11 +0000)]
Follow-up r85021: fix comment
Happy-melon [Thu, 31 Mar 2011 10:29:10 +0000 (10:29 +0000)]
Document blocklist-target message, per TWN request translatewiki.net/wiki/Thread:Support/Please_document_MediaWiki:Blocklist-target
Niklas Laxström [Thu, 31 Mar 2011 10:21:30 +0000 (10:21 +0000)]
Don't differentiate between user accounts and IPs in special page names.
BTW: Special:Block says "Block user" in page title followed immediately "Block user" as legend for fieldset.
Siebrand Mazeland [Thu, 31 Mar 2011 07:12:16 +0000 (07:12 +0000)]
Fix grammar for singular. Spotted by McDutchie.
OverlordQ [Wed, 30 Mar 2011 20:56:03 +0000 (20:56 +0000)]
Followup to r85021, fix caller in updater maintenance script
Happy-melon [Wed, 30 Mar 2011 20:05:17 +0000 (20:05 +0000)]
Follow-up r85025 - use strict comparison
Raimond Spekking [Wed, 30 Mar 2011 20:03:22 +0000 (20:03 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-30 19:35:00 UTC)
Sam Reed [Wed, 30 Mar 2011 19:44:39 +0000 (19:44 +0000)]
Fixup a couple more undefined variables
Sam Reed [Wed, 30 Mar 2011 19:39:59 +0000 (19:39 +0000)]
Fixup undefined $stores in if like renamewiki does it
Sam Reed [Wed, 30 Mar 2011 19:00:11 +0000 (19:00 +0000)]
Fixup/add documentation
Remove some unused variables
Sam Reed [Wed, 30 Mar 2011 18:56:31 +0000 (18:56 +0000)]
Swap = to == in conditional
Max Semenik [Wed, 30 Mar 2011 18:45:13 +0000 (18:45 +0000)]
Fixed fatal in r84971
Sam Reed [Wed, 30 Mar 2011 18:40:36 +0000 (18:40 +0000)]
Move duplicated Site class into own class in Maintenance.php, include in 2 users
Sam Reed [Wed, 30 Mar 2011 18:37:25 +0000 (18:37 +0000)]
Fix class name
Sam Reed [Wed, 30 Mar 2011 18:34:38 +0000 (18:34 +0000)]
Fix missing parameter to cacheUpdate
Happy-melon [Wed, 30 Mar 2011 18:06:05 +0000 (18:06 +0000)]
Follow-up r85020 per CR - use strict comparison
Happy-melon [Wed, 30 Mar 2011 18:00:11 +0000 (18:00 +0000)]
(bug 23408) give admins a warning before letting them block themselves. Also tweak the logic so that loading the interface for one already-blocked user, then actually submitting a block on a different user, shows the confirmation again if the second user is already blocked.
Platonides [Wed, 30 Mar 2011 17:41:58 +0000 (17:41 +0000)]
Add a couple of brace test cases.
Happy-melon [Wed, 30 Mar 2011 17:37:25 +0000 (17:37 +0000)]
(bug 19942) remove deprecated HTML attributes (cellpadding, align, valign) from TablePager.
Max Semenik [Wed, 30 Mar 2011 17:32:20 +0000 (17:32 +0000)]
(bug 28237) Installer doesn't create extension tables
Happy-melon [Wed, 30 Mar 2011 17:04:03 +0000 (17:04 +0000)]
(bug 18937) avoid broken wikimarkup (four apostrophes together) in MediaWiki:Confirmrecreate when there is no deletion reason, by using a separate message.
Happy-melon [Wed, 30 Mar 2011 16:44:13 +0000 (16:44 +0000)]
(bug 17009) remove hiddenStructure. Wasn't even applied across all skins anyway, would have been broken in cologneblue, standard, etc.
Chad Horohoe [Wed, 30 Mar 2011 14:33:37 +0000 (14:33 +0000)]
Merge some deployment changes to trunk: r82738 (as HISTORY), r81962
Purodha B Blissenbach [Wed, 30 Mar 2011 13:52:32 +0000 (13:52 +0000)]
Add optional parameter $1 for PLURAL use to messages userrights-groupsmember and userrights-groupsmember-auto
Happy-melon [Wed, 30 Mar 2011 12:58:09 +0000 (12:58 +0000)]
Additional release notes for r85005, which I meant to commit as two separate revisions as one needs to be backported (grr...)
Happy-melon [Wed, 30 Mar 2011 12:53:13 +0000 (12:53 +0000)]
(bug 15641) tweak Title::checkUserBlock() so that Title::getUserPermissionsErrors() more comprehensively prevents blocked users from performing various actions; particularly prevents blocked admins from protecting or deleting their own talk page.
Sam Reed [Wed, 30 Mar 2011 12:04:54 +0000 (12:04 +0000)]
Fixup some ambiguously defined variables
Cast a substr back to int
Sam Reed [Wed, 30 Mar 2011 12:04:25 +0000 (12:04 +0000)]
Use unused $fallback_languages
Purodha B Blissenbach [Wed, 30 Mar 2011 06:35:32 +0000 (06:35 +0000)]
Fix new typos introduced in r84799.
Russ Nelson [Wed, 30 Mar 2011 01:49:38 +0000 (01:49 +0000)]
missing closedir() and ... protected the readdir against opendir() failing
Trevor Parscal [Tue, 29 Mar 2011 22:08:57 +0000 (22:08 +0000)]
Swtiched to using console.log if present so that when errors occur inside of modules they are shown, even if you aren't in debug mode. This helps avoid the common pitfall of forgetting to export a symbol to the global space, because in debug mode everything is exported to the global space whereas in production mode it's wrapped in a closure.
Raimond Spekking [Tue, 29 Mar 2011 20:19:59 +0000 (20:19 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-29 20:00:00 UTC)
Max Semenik [Tue, 29 Mar 2011 19:00:23 +0000 (19:00 +0000)]
Tweaks for key generation:
* Don't show that scary message for every key, just once with list of them all
* If we're on Windows, we will probably be unable to open /dev/urandom, right?
* Tweaked the meaning of warning message, previously it sounded a bit like "we couldn't generate the key at all"
Chad Horohoe [Tue, 29 Mar 2011 18:47:35 +0000 (18:47 +0000)]
Place a warning about Postgres, since we haven't quite ironed out the final problems
Krinkle [Tue, 29 Mar 2011 18:36:36 +0000 (18:36 +0000)]
using jQuery hide() and show() instead of accessing the dom element directly from the jQuery object (either use jQuery or dont..).
Chad Horohoe [Tue, 29 Mar 2011 17:34:00 +0000 (17:34 +0000)]
minor cleanup
Chad Horohoe [Tue, 29 Mar 2011 17:06:26 +0000 (17:06 +0000)]
(bug 26481) $wgUpgradeKey/$wgSecretKey values sometimes not filled - only happened when you upgrade without LocalSettings and tried to create a new one
Purodha B Blissenbach [Mon, 28 Mar 2011 22:02:23 +0000 (22:02 +0000)]
Acknowledge that the e-mail address of the initial wiki sysop is optional.
Aaron Schulz [Mon, 28 Mar 2011 21:40:50 +0000 (21:40 +0000)]
Reverted r84918 per CR
Raimond Spekking [Mon, 28 Mar 2011 20:30:46 +0000 (20:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-27 20:06:00 UTC)
Russ Nelson [Mon, 28 Mar 2011 19:57:48 +0000 (19:57 +0000)]
findFileFromKey, newFileFromKey, $fileFactoryKey, and $oldFileFactoryKey weren't used by anything in .../extensions nor .../phase3
Roan Kattouw [Mon, 28 Mar 2011 15:01:20 +0000 (15:01 +0000)]
BREAKING CHANGE: Ignore cmtype when cmsort=timestamp is set, and bypass the per-type queries in the sort=timestamp case; they were causing performance problems, reported as bug 28291. This breaks backwards compatibility (gracefully, the cltype parameter is silently ignored) with earlier deployed versions of 1.17wmf1 but not with any released version, hence no RELEASE-NOTES
Daniel Friesen [Mon, 28 Mar 2011 03:57:18 +0000 (03:57 +0000)]
Followup r79639, add a new parser test for gallery items not using a namespace prefix.
Daniel Friesen [Mon, 28 Mar 2011 03:38:43 +0000 (03:38 +0000)]
Followup r81928, make proper use of $this->output instead of echo.
Daniel Friesen [Mon, 28 Mar 2011 03:25:36 +0000 (03:25 +0000)]
Followup r79433, hide realname from output when realnames are a hidden pref.
Happy-melon [Sun, 27 Mar 2011 22:45:32 +0000 (22:45 +0000)]
Follow-up r83907: abstract the flatlist mode into a descriptor option, and make it so the label does not linewrap away from the checkbox.
Happy-melon [Sun, 27 Mar 2011 20:45:59 +0000 (20:45 +0000)]
Follow-up r84814: revert redundant summary message addition.
Brion Vibber [Sun, 27 Mar 2011 20:19:24 +0000 (20:19 +0000)]
Further cleanup on installer: fix visibility of CC selector results when returning to the options page.
Brion Vibber [Sun, 27 Mar 2011 20:13:30 +0000 (20:13 +0000)]
* (bug 27170) [Installer] Install now completes when choosing a CC license with the picker
There were two things breaking this:
* X-Frame-Options forbade our final step of the license selector, or the license selection shower, from being loaded properly. This lead to it looking wrong.
* The installation URL fingerprinting broke on the long query string that's on the final step. As a result, the user's selection got saved into a different session subkey, thinking it belonged to a different installation. It would then not get seen by the surrounding page's installer instance, causing the confusion.
Fix removes the X-Frame-Options for the CC bit, and drops query strings before the rest of URL normalization in the fingerprint check so the CC bits now see the same session key as the rest.
Raimond Spekking [Sun, 27 Mar 2011 20:12:23 +0000 (20:12 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-27 19:42:00 UTC)
Brion Vibber [Sun, 27 Mar 2011 19:22:14 +0000 (19:22 +0000)]
* (bug 26937) [Installer] Fix for Javascript-opened sections being incorrectly open or closed when returning to page
The sections whose visibility was being controlled by the checkbox had an initial visibility hardcoded in the page output, which had been manually set to match the expected initial default state. I've switched these to instead check what the variable is set to and base the initial style visibility on that.
Could be better to encapsulate these settings together in some way, but this'll do for now.
Note that the way these are all done now means that the sections can never be used when JS is off; if a fully-functional installer is desired in a JS-free environment, it may be necessary to change these further to default to shown, and do the initial hiding in JavaScript (could have 'flashing' issues though: the bits showing up, then quickly hiding. laaame but oh well)
Platonides [Sun, 27 Mar 2011 17:18:52 +0000 (17:18 +0000)]
Stop after replaceing the first instance
Sam Reed [Sun, 27 Mar 2011 17:09:26 +0000 (17:09 +0000)]
Swap 2 "and" for "&&"
Sam Reed [Sun, 27 Mar 2011 17:07:14 +0000 (17:07 +0000)]
Allow changePassword.php to use username or userid
Happy-melon [Sun, 27 Mar 2011 16:49:01 +0000 (16:49 +0000)]
Follow-up r84805: convert SpecialActiveusers to not use the now-absent UsersPager.
Aaron Schulz [Sun, 27 Mar 2011 14:41:11 +0000 (14:41 +0000)]
Don't assume newFileFromKey always returns a File object (some repos many not support fetch by time or sha1 and return false)
Roan Kattouw [Sun, 27 Mar 2011 14:13:57 +0000 (14:13 +0000)]
Fix default implementation of ResourceLoaderModule::getStyles() to return an array, not a string. Was causing problems with another function that was being fed the return value of getStyles() and used an array type hint
Ariel Glenn [Sun, 27 Mar 2011 13:27:05 +0000 (13:27 +0000)]
eta shows revs/pages per sec in current interval as well as overall; useful for investigating problems, now that we have logging
Happy-melon [Sun, 27 Mar 2011 12:21:45 +0000 (12:21 +0000)]
Revert r84706, r84709 (UtfNormal rewrite). Clearly more work needed to get these in line with our coding standards.
Sam Reed [Sun, 27 Mar 2011 01:27:02 +0000 (01:27 +0000)]
Fixup whitespace from r80445
Sam Reed [Sun, 27 Mar 2011 01:22:44 +0000 (01:22 +0000)]
Remove remaining empty() call in r79119
Sam Reed [Sun, 27 Mar 2011 01:14:57 +0000 (01:14 +0000)]
* (bug 28263) cannot import xml with the api, when have not "import" user right, but "importupload"
Normalised api user right checking to that of SpecialImport, by moving permission checks into specified code paths
Some documentation and explicit variables added while inspecting other code
Brian Wolff [Sat, 26 Mar 2011 21:06:37 +0000 (21:06 +0000)]
(bug 28242) Make url's of the form mediawiki.org/wiki/w:Somewhere_on_pedia give a 301 (permenant) redirect instead of a 302.
This is to make google when indexing a page like http://mediawiki.org/wiki/w:Somewhere_on_pedia to report its target, not the
original url as the url of the page. This only affects urls where the (local) interwiki target is directly in the url.
Pages that contain #Redirect[[w:Somewhere_on_pedia]] will still use 302 (Temporary) redirects since such pages are by
no means permenantly redirected.
Also clarify docs on $wgDisableHardRedirects since the setting confused me.
See also google's spiel on 301 redirects http://www.google.com/support/webmasters/bin/answer.py?answer=93633
Raimond Spekking [Sat, 26 Mar 2011 20:55:47 +0000 (20:55 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-26 20:26:00 UTC)
Alexandre Emsenhuber [Sat, 26 Mar 2011 19:29:03 +0000 (19:29 +0000)]
Restore calls to SpecialPage::outputHeader(), no longer called since the rewrite to subclass SpecialPage
Happy-melon [Sat, 26 Mar 2011 19:18:39 +0000 (19:18 +0000)]
Topple the last bastion of global-function-based special pages. Also fix HTMLCheckField to work with GET forms.
Sam Reed [Sat, 26 Mar 2011 18:52:07 +0000 (18:52 +0000)]
* (bug 28249) allow dupes in meta=allmessages&amargs
Sam Reed [Sat, 26 Mar 2011 18:51:33 +0000 (18:51 +0000)]
Add some documentation in w/c
Sam Reed [Sat, 26 Mar 2011 18:46:15 +0000 (18:46 +0000)]
Followup r84356, don't pass title string, pass a title object
Sam Reed [Sat, 26 Mar 2011 18:39:22 +0000 (18:39 +0000)]
Followup r84363
Looks like I made a complete hash of that commit. Commit correct version from vm working copy
Happy-melon [Sat, 26 Mar 2011 17:50:50 +0000 (17:50 +0000)]
Update SpecialListfiles to subclass SpecialPage. Nearly there!
Happy-melon [Sat, 26 Mar 2011 16:40:57 +0000 (16:40 +0000)]
Convert SpecialListusers to subclass SpecialPage. Only two left now!
Purodha B Blissenbach [Sat, 26 Mar 2011 15:18:16 +0000 (15:18 +0000)]
Minor: removed some typos in comment lines.
Happy-melon [Sat, 26 Mar 2011 13:27:50 +0000 (13:27 +0000)]
Follow-up r83336, r83460: abandon hardcoded styles altogether, and instead use a semantic element to pick up appropriate styles which are already in the global stylesheets. This makes it easier to keep track of where we have implemented this browser-specific tweak in case we have to modify it in future. By turning debugging on devs have already volunteered themselves to masses of gratuitous extra text-on-page, a few extra elements won't inconvenience them too much further.
Derk-Jan Hartman [Sat, 26 Mar 2011 13:20:41 +0000 (13:20 +0000)]
Followup r80772
I'm not bored enough to actually port these IE styles into the main Chick stylesheet. So better to re-enable them until someone else is bored enough to try.
Happy-melon [Sat, 26 Mar 2011 13:04:40 +0000 (13:04 +0000)]
Break svn blame on every single line of SpecialWatchlist.php by converting it to subclass SpecialPage and hence changing the indentation :D. SpecialInterwikiWatchlist.php is virtually a clone of this code, so make it subclass in turn and remove duplication; there is probably more that could be removed.
Only three more global-function special page implementations left. \o/