Sam Reed [Tue, 10 May 2011 23:46:27 +0000 (23:46 +0000)]
* (bug 27790) add query type for querymodules to action=paraminfo
Krinkle [Tue, 10 May 2011 23:24:09 +0000 (23:24 +0000)]
RELEASE-NOTES for r87856
Krinkle [Tue, 10 May 2011 23:17:13 +0000 (23:17 +0000)]
Creating a way to toggle mw.config LEGACY_GLOBALS from LocalSettings (bug 28916).
* I thought a while for a way to somehow get that global variable from php to the start of the main mediaWiki object creation. Considered using a (temporary) global variable and deleting afterwards, but that looked like a hack and wasn't sure about the cross-browser functioning of it. Instead ended up by moving it to the startUp module where other global variables are accessed as well. This seems to work pretty good.
* Can be toggled from LocalSettings by setting $wgLegacyJavaScriptGlobals.
* Changed some usages of mediaWiki to use the global mw alias instead.
Chad Horohoe [Tue, 10 May 2011 22:54:59 +0000 (22:54 +0000)]
Turn forUpdate() into an actual no-op
Krinkle [Tue, 10 May 2011 21:54:42 +0000 (21:54 +0000)]
Step 1 of QUnit/TestSwarm support (bug 26908)
* Add jQuery QUnit module
* Add a return value to mw.Map.prototype.set
* Add fallback to 'body' for options.parent in a new $.messageBox
(this is a re-do of r87830, but without breaking mw.config, see r87830 CR)
--
* Small whitespace fix (spaces to tabs) in Resources.php
Brion Vibber [Tue, 10 May 2011 21:37:15 +0000 (21:37 +0000)]
Revert r87830: broke ResourceLoader, MediaWiki config variables
Raimond Spekking [Tue, 10 May 2011 21:00:25 +0000 (21:00 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-10 20:34:00 UTC)
Brion Vibber [Tue, 10 May 2011 20:14:30 +0000 (20:14 +0000)]
* (bug 25262) Fix for minification of hardcoded data: URIs in CSS
CSSMin::minify()'s processing of url references for path adjustment or embedding had excluded explicit fully-qualified http: and https: URLs, but was damaging others such as data: URIs that were actually hardcoded into the original CSS.
This was affecting styles used on no.wikipedia.org which embedded a few icons directly into the style sheet.
Now checking for any URL scheme rather than hardcoding a check for http & https.
Max Semenik [Tue, 10 May 2011 19:45:47 +0000 (19:45 +0000)]
To prevent creepy errors like bug 28908, raised PHPUnit requirement to 3.5
Alexandre Emsenhuber [Tue, 10 May 2011 19:15:09 +0000 (19:15 +0000)]
Removed trailing whitespaces
Alexandre Emsenhuber [Tue, 10 May 2011 19:03:23 +0000 (19:03 +0000)]
Moved inclusion of UtfNormalDefines.php near other inclusions
Krinkle [Tue, 10 May 2011 17:53:21 +0000 (17:53 +0000)]
Step 1 of QUnit/TestSwarm support (bug 26908)
* Add jQuery QUnit module
* Add a return value to mw.Map.prototype.set
* Add fallback to 'body' for options.parent in a new $.messageBox
Brian Wolff [Tue, 10 May 2011 06:20:13 +0000 (06:20 +0000)]
(bug 28888) In Special:Search, Don't tell user the page [[:]] already exists
when they search for only a fragment identifer.
Brian Wolff [Tue, 10 May 2011 05:36:15 +0000 (05:36 +0000)]
Prevent user from trying to move a page to a title longer than 255 bytes.
This just puts a maxlength on the field (+ byte counter js) which is much
nicer and clearer feedback to the user if they went over the limit then:
"The requested page title was invalid, empty, or an incorrectly linked inter-language or inter-wiki title. It may contain one or more characters which cannot be used in titles"
Which doesn't exactly indicate a length error.
Brion Vibber [Tue, 10 May 2011 01:17:01 +0000 (01:17 +0000)]
* (bug 21279, bug 28820) Workaround for standard diff links to deleted revs; Special:Undelete links to deleted rev when allowed.
Adds links to Special:Undelete to view the requested revisions onto the 'revision data not found' error message, if they can be found via ar_rev_id and the user has permission to deletedhistory.
Follow-up to r87804; allows the 'diff' links on log entries for Special:RevisionDelete actions on deleted revs referenced by rev-id to continue to go someplace semi-sane.
Could benefit a more transparent forwarding -> bug 28820.
Brion Vibber [Tue, 10 May 2011 01:13:25 +0000 (01:13 +0000)]
* (bug 21279) Special:Undelete's 'change visibility' links now use forward-compatible format with revision ID when available
Requires r87804 updates for Special:RevisionDelete to accept incoming links with &type=revision for deleted revs.
Brion Vibber [Tue, 10 May 2011 01:11:52 +0000 (01:11 +0000)]
* (bug 21279) Special:RevisionDelete now uses revision ID for deleted-page revisions when ar_rev_id is available.
- saved Special:RevisionDelete links from before page deletion still work as-is after deletion
- old log entries for rev-delete adjustments no longer magically switch to linking to Special:RevisionDelete with archive & ar_timestamp (they remain the same, as the links continue to work)
If you call Special:RevisionDelete using the older-style &type=archive links (using ar_timestamp as id) it will still save the same form to log for now; this may be fixed later for cases where the ar_rev_id is available.
Requires FakeResultWrapper fixes from r87803.
Brion Vibber [Tue, 10 May 2011 01:04:41 +0000 (01:04 +0000)]
Fixes for FakeResultWrapper iteration -- the rewind/next/current stuff used in RevDelete's listings wasn't quite working right here. Also returned a bogus object from fetchObject() when going beyond the end, which was not pretty!
Brian Wolff [Mon, 9 May 2011 23:27:47 +0000 (23:27 +0000)]
(bug 28887) Do not re-use special page objects.
This causes bugs where if you do
{{special:recentchanges/3}} and {{special:recentchanges/15}} the first one is used for both
since the property is stored in a member variable of the class, which is then saved.
MediaWiki seems to have reused the special page classes since forever. I'm not sure why.
I can't imagine anyone relying on this behaviour, and it seems rather unexpected behaviour.
Jack Phoenix [Mon, 9 May 2011 22:57:44 +0000 (22:57 +0000)]
coding style tweaks
Raimond Spekking [Mon, 9 May 2011 21:32:46 +0000 (21:32 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-09 21:19:00 UTC)
Chad Horohoe [Mon, 9 May 2011 20:49:19 +0000 (20:49 +0000)]
More silly ternary true : false fixes
Max Semenik [Mon, 9 May 2011 18:49:56 +0000 (18:49 +0000)]
Column checks for updater
Krinkle [Mon, 9 May 2011 18:44:22 +0000 (18:44 +0000)]
* [mediaWiki] Using mw-alias where possible + adding missing semi-colons and other JSHint nags
* [mw.util.test] Moving CSS style check for div#js-message after the call to jsMessage(). In most skins this doesn't matter as the element already exists. But some skins this element isn't created untill the call to jsMessage().
Krinkle [Mon, 9 May 2011 17:51:17 +0000 (17:51 +0000)]
Fix fixme: r87340: Remove slashes from double quote escape in single quote string.
Brion Vibber [Mon, 9 May 2011 17:43:09 +0000 (17:43 +0000)]
(bug 28864) Fix UtfNormal benchmark & test case runners from regression in r85327, r85944
It's possible that this has some side effect on HipHop builds -- the require_once on UtfNormalDefines.php that had been moved from UtfNormalUtil.php to MediaWiki's Setup.php in r85944 had been previously damaged by r85327 sticking a MediaWiki-specific MWInit class static method call into it, making it break on all the generator & test & benchmark code which does not depend on MediaWiki.
With the require_once restored everything seems to work, though it's possible that it ends up trying to include twice on HipHop -- have not tested.
Krinkle [Mon, 9 May 2011 17:24:07 +0000 (17:24 +0000)]
.length has the same number of characters as length and saves a function all. whatever
Krinkle [Mon, 9 May 2011 17:21:35 +0000 (17:21 +0000)]
jquery.makeCollapsible improvements
* Check for validness of $defaultToggle only needed once (Follow-up r83309 CR)
* The new jQuery sortable plugin caused a minor breakage in other actions bound within table cells. Since, in contrary to the old wikibits script, the entire <th> is clickable and the triangle is a background image. This means anything that is clickable inside the <th> (such as [<a>Collapse</a>] propagates/bubbles up to the <th> and causes the column to be re-sorted. In other words, collapsing a table caused the last column to be sorted, and when expanded again in the opposite order. Fixed by adding event.stopPropagation(); (note, not "return false" as there may be custom events bound to the anchor tag which should be fired as well. We just need to stop propagation not all other event, such as for customToggles).
Max Semenik [Mon, 9 May 2011 16:41:51 +0000 (16:41 +0000)]
testing of SQLite updates from all (previoisly) supported versions
Alexandre Emsenhuber [Mon, 9 May 2011 15:57:38 +0000 (15:57 +0000)]
Follow-up r86155: also remove revisionmove from MediaWiki::getAction()
Max Semenik [Mon, 9 May 2011 15:56:34 +0000 (15:56 +0000)]
Use runChild() to pass useful stuff like quiet mode
Roan Kattouw [Mon, 9 May 2011 13:10:06 +0000 (13:10 +0000)]
(bug 28840) Commit patch by bawolff that encodes dots in ResourceLoader module names as exclamation marks in the generated URLs, so as to avoid triggering the recently added IE security measure and causing a blank 403 response. This broke RL in various ways for IE users.
This is by no means intended to be permanent, but it's the best way to unbreak RL for IE users while we work out how to fix this properly.
Max Semenik [Mon, 9 May 2011 11:03:36 +0000 (11:03 +0000)]
Revert SQLite-related part of r87357: sauses SLQ errors, not needed
Brian Wolff [Mon, 9 May 2011 06:42:48 +0000 (06:42 +0000)]
Make it so that when a special page is trancluded, the output won't vary by url parameter.
This stops severe ugliness http://test.wikipedia.org/wiki/User:Bawolff/special?feed=atom
where the rss feed and the html of the page is concated together.
This could potentially break stuff if someone was using a transcludable special page
with an html form, or if someone is actually passing parameters to the transcludable
special page via the url. I'm not aware of anyone who does that, and both those things
seem rather evil.
Brian Wolff [Mon, 9 May 2011 03:48:06 +0000 (03:48 +0000)]
(bug 28883) Add messages for compression types (metadata) commonly used by Tiffs.
I used the list of common compression schemes at 'pedia: http://en.wikipedia.org/wiki/TIFF#TIFF_Compression_Tag
Daniel Friesen [Mon, 9 May 2011 02:55:17 +0000 (02:55 +0000)]
Followup r87668, update hooks.txt
Sam Reed [Sun, 8 May 2011 21:47:01 +0000 (21:47 +0000)]
Whitespace fixes
Addition/tweak of documentation
Krinkle [Sun, 8 May 2011 20:48:20 +0000 (20:48 +0000)]
Fix exception thrown in mw.util.addPortletLink
* As of jQuery 1.4.4, Sizzle's query must be a string (it does a query.replace call before everything else). It fails otherwise.
* In REL1_17 and 1.17wmf1 this isn't a problem since jQuery 1.4.2 is there, in which Sizzle didn't fail on non-strings yet.
* Nonetheless this is undocumented support, we should make sure that the variable passed is a string on our side
* Adding a check for it in mw.util.addPortletLink's nextnode argument.
* Adding a test to mw.util.test that calls addPortletLink with three arguments, making nextnode implied undefined/null. This test returned "ERROR" before I made the fix in mw.util.addPortletLink.
Exact error: TypeError: Result of expression 'query' [undefined] is not an object.
Origin: line 4085 of jQuery/mediaWiki module load.
Line 4081: Sizzle = function( query, context, extra, seed ) {
Line 4085: query = query.replace(/\=\s*([^'"\]]*)\s*\]/g, "='$1']");
Krinkle [Sun, 8 May 2011 20:30:29 +0000 (20:30 +0000)]
Remove second argument in str.substr() in $.ucFirst, not needed, defaults to full length of string
Raimond Spekking [Sun, 8 May 2011 19:45:53 +0000 (19:45 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-09 19:42:00 UTC)
Sam Reed [Sun, 8 May 2011 16:48:30 +0000 (16:48 +0000)]
Documentation
Remove long deprecated isBot()/isSysop() in ApiMain
Krinkle [Sun, 8 May 2011 13:22:42 +0000 (13:22 +0000)]
mw.util.test update
* Remove isMainPage() from test suite (r87360 r87586)
* Use mw.config for wgVars (follow-up r80792 CR)
* Rename skinLinksText variable to skinLinksHtml
* Wrap lines
* removing !important from addCSS test, instead using the same selector as the original background-color declaration and letting it cascade.
* Adding css('background-color') test to verify.
Alexandre Emsenhuber [Sun, 8 May 2011 08:50:11 +0000 (08:50 +0000)]
$wgOut can no longer be a stub since r85278, so there's no need to check this with StubObject::isRealObject()
Siebrand Mazeland [Sun, 8 May 2011 07:39:13 +0000 (07:39 +0000)]
Add placeholder for "bh" code. Falls back to "bho" per r87676.
Siebrand Mazeland [Sun, 8 May 2011 07:37:07 +0000 (07:37 +0000)]
Change language code from "bh" which is the code for the Bihari macro language to "bho", the correct code for Bhojpuri.
Daniel Friesen [Sun, 8 May 2011 00:10:31 +0000 (00:10 +0000)]
Change $text to $html. This has been bothering me for awhile. It's stupid, counterintuitive, we call it text making people think of it as text then note (oh, this isn't text, it's html, you'd better escape it yourself or you'll screw yourself over with an XSS vector).
Sam Reed [Sat, 7 May 2011 23:46:16 +0000 (23:46 +0000)]
* (bug 24711) MV_EditPageAjax.php uses deprecated LogReader and LogViewer
Not fixing usage, just SVN copy'd it from trunk into MetavidWiki extension as it's the only place still using it
Raimond Spekking [Sat, 7 May 2011 21:26:26 +0000 (21:26 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-07 20:56:00 UTC)
Raimond Spekking [Sat, 7 May 2011 19:42:47 +0000 (19:42 +0000)]
Follow-up r87651: PLURAL is needed for other languages with more than 1 plural forms
Brian Wolff [Sat, 7 May 2011 19:37:52 +0000 (19:37 +0000)]
(follow-up r87651) whoops, forgot release notes.
Brian Wolff [Sat, 7 May 2011 19:34:14 +0000 (19:34 +0000)]
(bug 28868) Include the number of pages in the default getLongDesc for multipaged documents
This will only include the number of pages if there is at least two pages.
If you have a pdf with a single page, it won't say 1 page. I modeled this
on how animated images will only say x frames if x > 1.
(For reference, this will affect extensions like pdfHandler, but it won't
affect extensions like PagedTiffHandler since that one totally overrides
the default method)
Niklas Laxström [Sat, 7 May 2011 17:04:00 +0000 (17:04 +0000)]
Followup r87578:
PHP Notice: Use of Linker::makeLinkObj is deprecated. [Called from call_user_func_array in (internal function)] for /w/i.php?title=Special:RecentChanges&translations=filter<ul>
<li>- line - calls Linker::makeLinkObj()</li>
<li>Skin.php line 1552 calls call_user_func_array()</li>
<li>- line - calls Skin::__call()</li>
<li>Renameuser.php line 58 calls SkinVector::makeLinkObj()</li>
<li>- line - calls wfRenameUserLogActionText()</li>
Niklas Laxström [Sat, 7 May 2011 16:50:36 +0000 (16:50 +0000)]
Sigh, syntax terror in r87640
Happy-melon [Sat, 7 May 2011 15:37:23 +0000 (15:37 +0000)]
Follow-up r87637: the terrors of copy-and-paste.
Happy-melon [Sat, 7 May 2011 15:30:46 +0000 (15:30 +0000)]
Autoloader entries for r86041.
Happy-melon [Sat, 7 May 2011 15:28:55 +0000 (15:28 +0000)]
Fix E_STRICT reported on r86273 CR.
Siebrand Mazeland [Sat, 7 May 2011 15:27:28 +0000 (15:27 +0000)]
Localisation updates for namespace names from translatewiki.net.
Happy-melon [Sat, 7 May 2011 15:25:27 +0000 (15:25 +0000)]
Move minimum database versions to Defines.php
Happy-melon [Sat, 7 May 2011 15:16:01 +0000 (15:16 +0000)]
Centralise the minimum-required-php-version in a MW_MIN_PHP_VERSION constant in Defines.php. This requires loading Defines.php before the PHP4 version checks, so include a big note reminding people not to include anything other than vanilla define() statements in there.
I have a sneaking suspicion that including Defines.php in the entry points might not play nicely with HipHop, but I can't test it (wrong OS).
Siebrand Mazeland [Sat, 7 May 2011 14:57:19 +0000 (14:57 +0000)]
Localisation updates for magic words from translatewiki.net.
Happy-melon [Sat, 7 May 2011 14:53:08 +0000 (14:53 +0000)]
* Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been loaded anywhere that DefaultSettings.php has been loaded.
* Move the declaration of $wgFeedClasses from Defines.php to WebStart.php
Platonides [Sat, 7 May 2011 14:45:48 +0000 (14:45 +0000)]
Revert r87542 and rename RELEASE-NOTES to keep them both in trunk and branch
per http://thread.gmane.org/gmane.science.linguistics.wikipedia.technical/53208
Siebrand Mazeland [Sat, 7 May 2011 14:19:48 +0000 (14:19 +0000)]
Localisation updates for special page aliases from translatewiki.net.
This changeset contains both resorted arrays as well as updates. Unfortunately the resorting makes the diffs unreadable :(.
Sam Reed [Sat, 7 May 2011 14:02:22 +0000 (14:02 +0000)]
Followup r87261
Somewhat vague spec is somehwat vague
Happy-melon [Sat, 7 May 2011 14:01:49 +0000 (14:01 +0000)]
Follow-up r85918:
* Clean up the ugly adding-then-removing-then-readding HTML <head> and <body> tags in DBConnectionError, deprecates MWException::htmlBodyOnly()
* Also deprecates MWException::htmlHeader(), removes code duplication since MWException::reportHTML() can safely call wfDie() and get an output format appropriate for the entry point
* Copy a couple of HTML headers (Cache-control, Pragma and Content-type) to the wfDie() implementation.
Happy-melon [Sat, 7 May 2011 13:24:47 +0000 (13:24 +0000)]
(bug 28834) Restore nl2br() wrappers removed in r85918.
Happy-melon [Sat, 7 May 2011 13:05:22 +0000 (13:05 +0000)]
(bug 28797) Fix ApiBase::parseMsg() to properly handle nested error arrays.
Aaron Schulz [Sat, 7 May 2011 10:24:38 +0000 (10:24 +0000)]
(bug 28667) "old title gets two review log entries after move". Fixed this by firing the revisionfromedit hook on the new title, which makes a bit more sense.
Aaron Schulz [Sat, 7 May 2011 09:55:18 +0000 (09:55 +0000)]
Notice: Use of undefined constant GAID_FOR_UPDATE - assumed 'GAID_FOR_UPDATE' in D:\www\MW_trunk\phase3\includes\Title.php on line 3085
Sam Reed [Fri, 6 May 2011 23:39:04 +0000 (23:39 +0000)]
List all removed globals in my recent commits in RELEASE-NOTES
Sam Reed [Fri, 6 May 2011 23:31:59 +0000 (23:31 +0000)]
Remove another unused deprecated function
Update 1 inbound caller
Sam Reed [Fri, 6 May 2011 23:25:57 +0000 (23:25 +0000)]
Kill $wgExtraRandompageSQL
Rewrote extension using them to subclass SpecialRandompage
Sam Reed [Fri, 6 May 2011 23:18:11 +0000 (23:18 +0000)]
Kill $wgAllowUserSkin
Sam Reed [Fri, 6 May 2011 23:15:01 +0000 (23:15 +0000)]
HTMLCacheUpdate->invalidate() deprecated since 1.16, unused
Sam Reed [Fri, 6 May 2011 23:13:09 +0000 (23:13 +0000)]
Xml::hidden() --> Html::hidden()
Xml::hidden() killed
Sam Reed [Fri, 6 May 2011 23:07:20 +0000 (23:07 +0000)]
Remove addExtraSQL
Sam Reed [Fri, 6 May 2011 22:53:59 +0000 (22:53 +0000)]
Documentation
Remove some deprecated in 1.16 functions with no callers
Sam Reed [Fri, 6 May 2011 22:17:48 +0000 (22:17 +0000)]
Fix fail attempt at passing string by reference in r87589
Raimond Spekking [Fri, 6 May 2011 22:11:48 +0000 (22:11 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-06 22:02:00 UTC)
Sam Reed [Fri, 6 May 2011 22:09:47 +0000 (22:09 +0000)]
Kill off the long deprecated $wgInputEncoding and $wgOutputEncoding globals
Sam Reed [Fri, 6 May 2011 21:57:55 +0000 (21:57 +0000)]
Kill $wgRateLimitsExcludedGroups which was deprecated in 1.13
Krinkle [Fri, 6 May 2011 21:55:25 +0000 (21:55 +0000)]
mw.util.isMainPage(); Was never released, removing before release since it's deprecated: Use wgIsMainPage in mw.config instead.
Sam Reed [Fri, 6 May 2011 21:50:18 +0000 (21:50 +0000)]
More versions added to @deprecated tags
Couple of inbound calls fixed up
Some ancient code removed as it's been marked deprecated
Rotem Liss [Fri, 6 May 2011 21:26:29 +0000 (21:26 +0000)]
Localization update for he.
Sam Reed [Fri, 6 May 2011 21:09:34 +0000 (21:09 +0000)]
Kill some more long deprecated unused functions
Add more @deprecated since where appropriate
Sam Reed [Fri, 6 May 2011 20:59:58 +0000 (20:59 +0000)]
Remove some stuff marked as deprecated <= 1.16 unused
Stuff still used left for the moment
Added some since to @deprecated
Added wfDeprecated( __METHOD__ ); in one case
Sam Reed [Fri, 6 May 2011 20:50:16 +0000 (20:50 +0000)]
Couple more deprecated things removed
Sam Reed [Fri, 6 May 2011 20:46:13 +0000 (20:46 +0000)]
More __ for r87572
Sam Reed [Fri, 6 May 2011 20:43:32 +0000 (20:43 +0000)]
Add wfDeprecated( __METHOD ); to one method marked for 1.19
Sam Reed [Fri, 6 May 2011 20:36:58 +0000 (20:36 +0000)]
Bye bye config directory
Sam Reed [Fri, 6 May 2011 20:35:52 +0000 (20:35 +0000)]
Remove install-utils.inc marked for 1.19 removal
Alexandre Emsenhuber [Fri, 6 May 2011 18:22:37 +0000 (18:22 +0000)]
Removed more functions marked for removal in 1.19: wfParseCIDR(), wfRFC822Phrase() and userMailer().
Alexandre Emsenhuber [Fri, 6 May 2011 18:17:52 +0000 (18:17 +0000)]
Removed LogPageValidTypes, LogPageLogName, LogPageLogHeader and LogPageActionText hooks. They are deprecated since 1.6 or so.
Alexandre Emsenhuber [Fri, 6 May 2011 18:10:53 +0000 (18:10 +0000)]
Remove functions marked for removal in 1.19
Chad Horohoe [Fri, 6 May 2011 15:45:13 +0000 (15:45 +0000)]
(bug 10154) Don't allow user to specify days beyond $wgRCMaxAge
Chad Horohoe [Fri, 6 May 2011 14:57:05 +0000 (14:57 +0000)]
Fix for r80864, host not server. Like r87498
Sam Reed [Fri, 6 May 2011 14:52:12 +0000 (14:52 +0000)]
Fix 2 more 1.18's from RELEASE-NOTES in r87542
Sam Reed [Fri, 6 May 2011 14:48:00 +0000 (14:48 +0000)]
Followup r87541
Move RELEASE-NOTES to HISTORY
Chad Horohoe [Fri, 6 May 2011 14:45:25 +0000 (14:45 +0000)]
Bump trunk version since we've branched
Chad Horohoe [Thu, 5 May 2011 22:27:54 +0000 (22:27 +0000)]
5.2.3, like we do everywhere else