From: Adam Roses Wight <awight@wikimedia.org>
Date: Mon, 11 Mar 2013 19:26:53 +0000 (-0700)
Subject: mediawiki.user: Use session ID instead of 1-year cross-session cookies
X-Git-Tag: 1.31.0-rc.0~19742^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/comptes/journal.php?a=commitdiff_plain;h=af5f850ec3087febcb6d74d48ddf3e8f6126698c;p=lhc%2Fweb%2Fwiklou.git

mediawiki.user: Use session ID instead of 1-year cross-session cookies

No cookies should be assigned for longer than session expiry.

Bug: 44327
Change-Id: If2f096dadb639769d859e1596d84b3ad5775a01d
---

diff --git a/resources/mediawiki/mediawiki.user.js b/resources/mediawiki/mediawiki.user.js
index e036dc9b22..9fd2e5e459 100644
--- a/resources/mediawiki/mediawiki.user.js
+++ b/resources/mediawiki/mediawiki.user.js
@@ -141,30 +141,16 @@
 		};
 
 		/**
-		 * Gets the current user's name or a random ID automatically generated and kept in a cookie.
-		 *
-		 * This ID is persistent for anonymous users, staying in their browser up to 1 year. The
-		 * expiration time is reset each time the ID is queried, so in most cases this ID will
-		 * persist until the browser's cookies are cleared or the user doesn't visit for 1 year.
+		 * Gets the current user's name or the session ID
 		 *
 		 * @return {string} User name or random session ID
 		 */
 		this.id = function () {
-			var id,
-				name = user.getName();
+			var name = user.getName();
 			if ( name ) {
 				return name;
 			}
-			id = $.cookie( 'mediaWiki.user.id' );
-			if ( typeof id === 'undefined' || id === null ) {
-				id = user.generateRandomSessionId();
-			}
-			// Set cookie if not set, or renew it if already set
-			$.cookie( 'mediaWiki.user.id', id, {
-				expires: 365,
-				path: '/'
-			} );
-			return id;
+			return user.sessionId();
 		};
 
 		/**