From fe136d618d847060ddfdabb435f583c6b0b793c9 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Sun, 23 Sep 2012 20:53:30 +0200 Subject: [PATCH] Remove pass-by-reference from WikiExporter constructor The pass-by-reference is a left over from PHP 4 times. This avoids: Strict Standards: Only variables should be passed by reference in \includes\api\ApiQuery.php on line 523 Change-Id: I8c9afcd9f7631bbb0bdb9ea608339bbbd5726a26 --- includes/Export.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/Export.php b/includes/Export.php index f01fb23732..c2409de98f 100644 --- a/includes/Export.php +++ b/includes/Export.php @@ -83,9 +83,9 @@ class WikiExporter { * @param $buffer Int: one of WikiExporter::BUFFER or WikiExporter::STREAM * @param $text Int: one of WikiExporter::TEXT or WikiExporter::STUB */ - function __construct( &$db, $history = WikiExporter::CURRENT, + function __construct( $db, $history = WikiExporter::CURRENT, $buffer = WikiExporter::BUFFER, $text = WikiExporter::TEXT ) { - $this->db =& $db; + $this->db = $db; $this->history = $history; $this->buffer = $buffer; $this->writer = new XmlDumpWriter(); -- 2.20.1