From b41e6a593350f7f463691b4a7e18adadce4d49ae Mon Sep 17 00:00:00 2001 From: "This, that and the other" Date: Tue, 21 Apr 2015 17:17:23 +1000 Subject: [PATCH] Use successbox/errorbox instead of bolded text on revision delete form Same idea as I596cbdc2. * Avoid style markup in i18n messages. Use successbox instead of inside a message in a span. * Consistency with rest of MediaWiki (e.g. Special:Preferences). * Make error look like an error. It was previously output in a plain paragraph with no styling or other indication. Change-Id: Ia2f8d56edbd72632d02c6738841340b28cc6d773 --- includes/specials/SpecialRevisiondelete.php | 7 +++++-- languages/i18n/en.json | 8 ++++---- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/includes/specials/SpecialRevisiondelete.php b/includes/specials/SpecialRevisiondelete.php index bdfe911674..62025e75d6 100644 --- a/includes/specials/SpecialRevisiondelete.php +++ b/includes/specials/SpecialRevisiondelete.php @@ -606,7 +606,7 @@ class SpecialRevisionDelete extends UnlistedSpecialPage { // Messages: revdelete-success, logdelete-success $this->getOutput()->setPageTitle( $this->msg( 'actioncomplete' ) ); $this->getOutput()->wrapWikiMsg( - "\n$1\n", + "
\n$1\n
", $this->typeLabels['success'] ); $this->wasSaved = true; @@ -621,7 +621,10 @@ class SpecialRevisionDelete extends UnlistedSpecialPage { protected function failure( $status ) { // Messages: revdelete-failure, logdelete-failure $this->getOutput()->setPageTitle( $this->msg( 'actionfailed' ) ); - $this->getOutput()->addWikiText( $status->getWikiText( $this->typeLabels['failure'] ) ); + $this->getOutput()->addWikiText( '
' . + $status->getWikiText( $this->typeLabels['failure'] ) . + '
' + ); $this->showForm(); } diff --git a/languages/i18n/en.json b/languages/i18n/en.json index 93eb6c56c8..9ad1afe303 100644 --- a/languages/i18n/en.json +++ b/languages/i18n/en.json @@ -813,10 +813,10 @@ "revdelete-unsuppress": "Remove restrictions on restored revisions", "revdelete-log": "Reason:", "revdelete-submit": "Apply to selected {{PLURAL:$1|revision|revisions}}", - "revdelete-success": "Revision visibility successfully updated.", - "revdelete-failure": "Revision visibility could not be updated:\n$1", - "logdelete-success": "Log visibility successfully set.", - "logdelete-failure": "Log visibility could not be set:\n$1", + "revdelete-success": "Revision visibility successfully updated.", + "revdelete-failure": "Revision visibility could not be updated:\n$1", + "logdelete-success": "Log visibility successfully set.", + "logdelete-failure": "Log visibility could not be set:\n$1", "revdel-restore": "change visibility", "pagehist": "Page history", "deletedhist": "Deleted history", -- 2.20.1