From a6814c9df38176726fdd53b4310ec045cee0ace9 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Tue, 14 Oct 2014 14:58:26 -0700 Subject: [PATCH] Removed extra "tries" increment in the redis job queue * This could result in jobs getting one less extra tries than they should Change-Id: Ia2e82ca0965f6ce9e1354820eb03f40f047a949c --- includes/jobqueue/JobQueueRedis.php | 1 - 1 file changed, 1 deletion(-) diff --git a/includes/jobqueue/JobQueueRedis.php b/includes/jobqueue/JobQueueRedis.php index b87c678a36..e6724f7432 100644 --- a/includes/jobqueue/JobQueueRedis.php +++ b/includes/jobqueue/JobQueueRedis.php @@ -614,7 +614,6 @@ LUA; if attempts < ARGV[3] then -- Claim expired and retries left: re-enqueue the job redis.call('lPush',kUnclaimed,id) - redis.call('hIncrBy',kAttempts,id,1) released = released + 1 else -- Claim expired and no retries left: mark the job as dead -- 2.20.1