From 9fbf29e7ef028d07d2f1516292096803e0e5ae96 Mon Sep 17 00:00:00 2001
From: Erik Moeller <erik@users.mediawiki.org>
Date: Sun, 18 Jan 2004 08:19:29 +0000
Subject: [PATCH] generate toolbar buttons via JS so that non-JS browsers don't
 show toolbar text

---
 includes/Skin.php | 25 +++++++++----------------
 1 file changed, 9 insertions(+), 16 deletions(-)

diff --git a/includes/Skin.php b/includes/Skin.php
index 0f324d1a8a..e7a646e42b 100644
--- a/includes/Skin.php
+++ b/includes/Skin.php
@@ -2227,13 +2227,13 @@ class Skin {
 		// The tip text is shown when the user moves the mouse over the button.
 		$toolarray=array(
 			array(	"image"=>"button_bold.gif",
-				"open"=>"\\'\\'\\'",
-				"close"=>"\\'\\'\\'",
+				"open"=>"\'\'\'",
+				"close"=>"\'\'\'",
 				"sample"=>wfMsg("bold_sample"),
 				"tip"=>wfMsg("bold_tip")),
 			array(	"image"=>"button_italic.gif",
-				"open"=>"\\'\\'",
-				"close"=>"\\'\\'",
+				"open"=>"\'\'",
+				"close"=>"\'\'",
 				"sample"=>wfMsg("italic_sample"),
 				"tip"=>wfMsg("italic_tip")),
 			array(	"image"=>"button_link.gif",
@@ -2277,11 +2277,11 @@ class Skin {
 				"sample"=>"",
 				"tip"=>wfMsg("hr_tip"))
 		);
-		$toolbar.="
-		<div id=\"toolbar\">";
+		$toolbar.="<script type='text/javascript'>\n";
+		$toolbar.="document.writeln(\"</p><div id='toolbar'>\");\n";
 		foreach($toolarray as $tool) {
 
-			$image=$tool["image"];
+			$image=$wgUploadPath."/".$tool["image"];
 			$open=$tool["open"];
 			$close=$tool["close"];
 			$sample=$tool["sample"];
@@ -2291,18 +2291,11 @@ class Skin {
 			// Ideally these should be different, realistically they
 			// probably don't need to be.
 			$tip=$tool["tip"];
-
-			$toolbar.=
-			"<a href=\"#\"".
-			"onclick=\"javascript:insertTags('$open','$close','$sample');\">".
-			"<img src=\"$wgUploadPath/$image\" border=\"0\" ALT=\"$tip\" TITLE=\"$tip\">".
-			"</a>";
-
+			$toolbar.="addButton('$image','$tip','$open','$close','$sample');\n";
 		}
 
-		$toolbar.="</div>";
+		$toolbar.="document.writeln(\"</div>\");\n</script>";
 		return $toolbar;
-
 	}
 }
 
-- 
2.20.1