From 8d0178c60b95ea39938aa8e0bf0fcccf62bf5908 Mon Sep 17 00:00:00 2001
From: Alexandre Emsenhuber <ialex@users.mediawiki.org>
Date: Mon, 2 May 2011 17:30:17 +0000
Subject: [PATCH] * Removed Skin::reallyGenerateUserStylesheet() nothing uses
 it and nothing overrides it * Corrected Skin::generateUserJs() and
 Skin::generateUserStylesheet()'s comments: nothing override them anymore,
 also marked them as deprecated, only usage is action=raw&gen=(css|js)

---
 includes/Skin.php | 35 +++++++++--------------------------
 1 file changed, 9 insertions(+), 26 deletions(-)

diff --git a/includes/Skin.php b/includes/Skin.php
index acbe6eaef4..e7fff76ad4 100644
--- a/includes/Skin.php
+++ b/includes/Skin.php
@@ -374,43 +374,26 @@ abstract class Skin {
 
 	/**
 	 * Generated JavaScript action=raw&gen=js
-	 * This returns MediaWiki:Common.js and MediaWiki:[Skinname].js concate-
-	 * nated together.  For some bizarre reason, it does *not* return any
-	 * custom user JS from subpages.  Huh?
-	 *
-	 * There's absolutely no reason to have separate Monobook/Common JSes.
-	 * Any JS that cares can just check the skin variable generated at the
-	 * top.  For now Monobook.js will be maintained, but it should be consi-
-	 * dered deprecated.
+	 * This used to load MediaWiki:Common.js and the skin-specific style
+	 * before the RessourceLoader.
 	 *
+	 * @deprecated Use the RessourceLoader instead. This may be removed at some
+	 * point.
 	 * @param $skinName String: If set, overrides the skin name
-	 * @return string
+	 * @return String
 	 */
 	public function generateUserJs( $skinName = null ) {
-		
-		// Stub - see ResourceLoaderSiteModule, CologneBlue, Simple and Standard skins override this
-		
 		return '';
 	}
 
 	/**
 	 * Generate user stylesheet for action=raw&gen=css
+	 *
+	 * @deprecated Use the RessourceLoader instead. This may be removed at some
+	 * point.
+	 * @return String
 	 */
 	public function generateUserStylesheet() {
-		
-		// Stub - see ResourceLoaderUserModule, CologneBlue, Simple and Standard skins override this
-		
-		return '';
-	}
-
-	/**
-	 * Split for easier subclassing in SkinSimple, SkinStandard and SkinCologneBlue
-	 * Anything in here won't be generated if $wgAllowUserCssPrefs is false.
-	 */
-	protected function reallyGenerateUserStylesheet() {
-		
-		// Stub - see  ResourceLoaderUserModule, CologneBlue, Simple and Standard skins override this
-		
 		return '';
 	}
 
-- 
2.20.1