From 8782d889404991f547e2def6c8d52f7d41deb8eb Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Thu, 27 Jul 2017 16:17:50 -0700 Subject: [PATCH] RCFilters UI: Remove duplicate(!!) method mw.rcfilters.Controller#_getDefaultParams Change-Id: Id26f4e9716d2276123881c3c74f908265dd1a52f --- .../mw.rcfilters.Controller.js | 37 ------------------- 1 file changed, 37 deletions(-) diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js index 45e3046c79..82213ea532 100644 --- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js +++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js @@ -750,43 +750,6 @@ ); }; - /** - * Get an object representing the default parameter state, whether - * it is from the model defaults or from the saved queries. - * - * @return {Object} Default parameters - */ - mw.rcfilters.Controller.prototype._getDefaultParams = function () { - var data, queryHighlights, - savedParams = {}, - savedHighlights = {}, - defaultSavedQueryItem = this.savedQueriesModel.getItemByID( this.savedQueriesModel.getDefault() ); - - if ( mw.config.get( 'wgStructuredChangeFiltersEnableSaving' ) && - defaultSavedQueryItem ) { - - data = defaultSavedQueryItem.getData(); - - queryHighlights = data.highlights || {}; - savedParams = this.filtersModel.getParametersFromFilters( data.filters || {} ); - - // Translate highlights to parameters - savedHighlights.highlight = String( Number( queryHighlights.highlight ) ); - $.each( queryHighlights, function ( filterName, color ) { - if ( filterName !== 'highlights' ) { - savedHighlights[ filterName + '_color' ] = color; - } - } ); - - return $.extend( true, {}, savedParams, savedHighlights, { invert: data.invert } ); - } - - return $.extend( - { highlight: '0' }, - this.filtersModel.getDefaultParams() - ); - }; - /** * Get an object representing the default parameter state, whether * it is from the model defaults or from the saved queries. -- 2.20.1