From: Bartosz Dziewoński <matma.rex@gmail.com>
Date: Sat, 23 Aug 2014 16:20:51 +0000 (+0200)
Subject: OutputPage: addParserOutput*() family doesn't need to take a reference
X-Git-Tag: 1.31.0-rc.0~14300^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/comptes/ajouter.php?a=commitdiff_plain;h=4bb54bbe30174c6aa3ddfd63825f4163d8f5a615;p=lhc%2Fweb%2Fwiklou.git

OutputPage: addParserOutput*() family doesn't need to take a reference

We never assign to the variable, only call some (mutating) methods on
the object. With PHP 5 we don't need to pass this by reference.

The functions that evolved into this family were originally added in
r12337, back then we probably still ran on PHP 4 or something.

Change-Id: Ib4ab141ca6d803f9df0351b1f65c7e9955c37d57
---

diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index c98f34b172..8a69f6cb92 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -1617,7 +1617,7 @@ class OutputPage extends ContextSource {
 	 * @deprecated since 1.24, use addParserOutputMetadata() instead.
 	 * @param ParserOutput $parserOutput
 	 */
-	public function addParserOutputNoText( &$parserOutput ) {
+	public function addParserOutputNoText( $parserOutput ) {
 		$this->addParserOutputMetadata( $parserOutput );
 	}
 
@@ -1629,7 +1629,7 @@ class OutputPage extends ContextSource {
 	 * @since 1.24
 	 * @param ParserOutput $parserOutput
 	 */
-	public function addParserOutputMetadata( &$parserOutput ) {
+	public function addParserOutputMetadata( $parserOutput ) {
 		$this->mLanguageLinks += $parserOutput->getLanguageLinks();
 		$this->addCategoryLinks( $parserOutput->getCategories() );
 		$this->mNewSectionLink = $parserOutput->getNewSection();
@@ -1685,7 +1685,7 @@ class OutputPage extends ContextSource {
 	 * @since 1.24
 	 * @param ParserOutput $parserOutput
 	 */
-	public function addParserOutputContent( &$parserOutput ) {
+	public function addParserOutputContent( $parserOutput ) {
 		$this->addParserOutputText( $parserOutput );
 
 		$this->addModules( $parserOutput->getModules() );
@@ -1702,7 +1702,7 @@ class OutputPage extends ContextSource {
 	 * @since 1.24
 	 * @param ParserOutput $parserOutput
 	 */
-	public function addParserOutputText( &$parserOutput ) {
+	public function addParserOutputText( $parserOutput ) {
 		$text = $parserOutput->getText();
 		wfRunHooks( 'OutputPageBeforeHTML', array( &$this, &$text ) );
 		$this->addHTML( $text );
@@ -1713,7 +1713,7 @@ class OutputPage extends ContextSource {
 	 *
 	 * @param ParserOutput $parserOutput
 	 */
-	function addParserOutput( &$parserOutput ) {
+	function addParserOutput( $parserOutput ) {
 		$this->addParserOutputMetadata( $parserOutput );
 		$parserOutput->setTOCEnabled( $this->mEnableTOC );