Actually list implicit groups in allusers.
authorSam Reed <reedy@users.mediawiki.org>
Sun, 20 Mar 2011 00:23:41 +0000 (00:23 +0000)
committerSam Reed <reedy@users.mediawiki.org>
Sun, 20 Mar 2011 00:23:41 +0000 (00:23 +0000)
Looks like I might've regressed this in the course of fixing other bugs. Oh well, fixed now

includes/api/ApiQueryAllUsers.php

index 0376431..a2657fb 100644 (file)
@@ -225,14 +225,14 @@ class ApiQueryAllUsers extends ApiQueryBase {
                                $result->setIndexedTagName( $lastUserData['groups'], 'g' );
                        }
 
-                       if ( $fld_rights && !is_null( $row->ug_group2 ) ) {
-                               if ( !isset( $lastUserData['rights'] ) ) {
-                                       $lastUserData['rights'] = User::getGroupPermissions( User::getImplicitGroups() );
+                       if ( $fld_groups ) {
+                               if ( !isset( $lastUserData['groups'] ) ) {
+                                       $lastUserData['groups'] = ApiQueryUsers::getAutoGroups( User::newFromName( $lastUser ) );
                                }
-
-                               $lastUserData['rights'] = array_unique( array_merge( $lastUserData['rights'],
-                                       User::getGroupPermissions( array( $row->ug_group2 ) ) ) );
-                               $result->setIndexedTagName( $lastUserData['rights'], 'r' );
+                               if ( !is_null( $row->ug_group2 ) ) {
+                                       $lastUserData['groups'][] = $row->ug_group2;
+                               }
+                               $result->setIndexedTagName( $lastUserData['groups'], 'g' );
                        }
                }