Add fixme note for ArticleViewHeader hook, which appears to be misplaced.
authorBrion Vibber <brion@users.mediawiki.org>
Tue, 13 Dec 2005 00:42:39 +0000 (00:42 +0000)
committerBrion Vibber <brion@users.mediawiki.org>
Tue, 13 Dec 2005 00:42:39 +0000 (00:42 +0000)
If the view is a parser cache hit, the hook will not be called.

includes/Article.php

index fc0efc8..6a4a65d 100644 (file)
@@ -786,6 +786,10 @@ class Article {
                        }
                }
                if( !$outputDone ) {
+                       /**
+                        * @fixme: this hook doesn't work most of the time, as it doesn't
+                        * trigger when the parser cache is used.
+                        */
                        wfRunHooks( 'ArticleViewHeader', array( &$this ) ) ;
                        # wrap user css and user js in pre and don't parse
                        # XXX: use $this->mTitle->usCssJsSubpage() when php is fixed/ a workaround is found