Merge "WikiPage: Hard deprecate second arg of prepareContentForEdit() as an int"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Mon, 25 Sep 2017 14:51:39 +0000 (14:51 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Mon, 25 Sep 2017 14:51:39 +0000 (14:51 +0000)
includes/page/WikiPage.php

index c04eb0a..d0a04c0 100644 (file)
@@ -1984,6 +1984,7 @@ class WikiPage implements Page, IDBAccessObject {
                        // This code path is deprecated, and nothing is known to
                        // use it, so performance here shouldn't be a worry.
                        if ( $revid !== null ) {
+                               wfDeprecated( __METHOD__ . ' with $revision = revision ID', '1.25' );
                                $revision = Revision::newFromId( $revid, Revision::READ_LATEST );
                        } else {
                                $revision = null;