Set visibility on class properties for *Dependency classes

Set visibility to private for properties that are not referenced outside
of the class itself, and when the class is not currently being subclassed.

Change-Id: I427c6de5a0a29b43cff755db0eb8a750db620173

diff --git a/includes/cache/CacheDependency.php b/includes/cache/CacheDependency.php
index 57d9af8..27f136a 100644 (file)
--- a/includes/cache/CacheDependency.php
+++ b/includes/cache/CacheDependency.php
@@ -148,7 +148,8 @@ abstract class CacheDependency {
  * @ingroup Cache
  */
 class FileDependency extends CacheDependency {
-       var $filename, $timestamp;
+       private $filename;
+       private $timestamp;
 
        /**
         * Create a file dependency
@@ -218,9 +219,10 @@ class FileDependency extends CacheDependency {
  * @ingroup Cache
  */
 class TitleDependency extends CacheDependency {
-       var $titleObj;
-       var $ns, $dbk;
-       var $touched;
+       private $titleObj;
+       private $ns;
+       private $dbk;
+       private $touched;
 
        /**
         * Construct a title dependency
@@ -287,8 +289,8 @@ class TitleDependency extends CacheDependency {
  * @ingroup Cache
  */
 class TitleListDependency extends CacheDependency {
-       var $linkBatch;
-       var $timestamps;
+       private $linkBatch;
+       private $timestamps;
 
        /**
         * Construct a dependency on a list of titles
@@ -393,7 +395,8 @@ class TitleListDependency extends CacheDependency {
  * @ingroup Cache
  */
 class GlobalDependency extends CacheDependency {
-       var $name, $value;
+       private $name;
+       private $value;
 
        function __construct( $name ) {
                $this->name = $name;
@@ -415,7 +418,8 @@ class GlobalDependency extends CacheDependency {
  * @ingroup Cache
  */
 class ConstantDependency extends CacheDependency {
-       var $name, $value;
+       private $name;
+       private $value;
 
        function __construct( $name ) {
                $this->name = $name;