From 416c2f67ecf7e6e6e857ce4740aa8e64fe98740e Mon Sep 17 00:00:00 2001 From: David Barratt Date: Fri, 19 Jul 2019 14:12:06 -0400 Subject: [PATCH] Remove TODO for unblockself It is impossible to reach the unblockself code if someone is anonymous, so there is no need to check that the block applies to that permission. Bug: T228538 Change-Id: Ie7b1e0f37363cc9e75ee2c871c06cefdfb2eb1d1 --- includes/specials/SpecialBlock.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/includes/specials/SpecialBlock.php b/includes/specials/SpecialBlock.php index ea4f18d287..13e4609eb3 100644 --- a/includes/specials/SpecialBlock.php +++ b/includes/specials/SpecialBlock.php @@ -1130,8 +1130,6 @@ class SpecialBlock extends FormSpecialPage { if ( $performer->getBlock() ) { if ( $target instanceof User && $target->getId() == $performer->getId() ) { # User is trying to unblock themselves - // @TODO Ensure that the block does not apply to the `unblockself` - // right. if ( $performer->isAllowed( 'unblockself' ) ) { return true; # User blocked themselves and is now trying to reverse it -- 2.20.1