From 39389f402d9ff55f28a0ca41470bf746b2a9fda8 Mon Sep 17 00:00:00 2001 From: Andrew Garrett Date: Wed, 28 Jan 2009 23:37:42 +0000 Subject: [PATCH] Fix patrolling checks, which are using the expensive version of userCan, and therefore causing queries to be made cross-cluster on every single pageview. --- includes/Article.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/Article.php b/includes/Article.php index 4f3125ea7c..d5ed3bd02f 100644 --- a/includes/Article.php +++ b/includes/Article.php @@ -996,7 +996,7 @@ class Article { # Only diffs and new page links from RC give rcid params, so if # we are just viewing the page normally with no rcid, try to find it. # This is more convenient for users. - if( $this->mTitle->exists() && $this->mTitle->userCan('patrol') ) { + if( $this->mTitle->exists() && $this->mTitle->userCan('patrol', false) ) { if( empty($rcid) ) { $firstRev = $this->mTitle->getFirstRevision(); $rcid = $firstRev ? $firstRev->isUnpatrolled() : 0; @@ -1008,7 +1008,7 @@ class Article { } # If we have been passed an &rcid= parameter, we want to give the user a # chance to mark this new article as patrolled. - if( !empty($rcid) && $this->mTitle->exists() && $this->mTitle->userCan('patrol') ) { + if( !empty($rcid) && $this->mTitle->exists() && $this->mTitle->userCan('patrol', false) ) { $wgOut->addHTML( "
" . wfMsgHtml( 'markaspatrolledlink', -- 2.20.1