jenkins-bot [Tue, 18 Jul 2017 01:40:08 +0000 (01:40 +0000)]
Merge "phpunit: Load extension unit tests for --testsuite=skins"
Timo Tijhof [Tue, 18 Jul 2017 01:24:32 +0000 (20:24 -0500)]
doc: Fix a few Example docs for PHP classes
* "@example" is specifically for creating entries on the "Examples"
page produced by Doxygen, which is not specific to individual classes
or methods, but rather is meant to be about the software as a whole.
There are currently four entries produced there, and they are all broken:
- .../src/includes/rcfeed/RedisPubSubFeedEngine.php (unnamed example, broken)
- .../src/tests/phpunit/MediaWikiTestCase.php (unnamed example)
- 42 (empty page named "42")
- user (empty page named "user")
* Remove usage and replace with either a regular paragraph that is
part of the member/method/class description, or for code examples,
use "@par" to create a sub heading, and then a @code-@endcode block.
Change-Id: I52c937fef4b377173f6c4dbad9dc4a9f8beae4ee
jdlrobson [Mon, 17 Jul 2017 20:38:01 +0000 (13:38 -0700)]
phpunit: Load extension unit tests for --testsuite=skins
Skins, like extensions, can register PHPUnit tests.
The testsuite interface in PHPUnit is designed to execute one run only,
so this should be based on the semantic entry of "skin jobs".
Changing the Jenkins job to run both doesn't work (only one value accepted).
Working around by running phpunit twice also seems wrong.
Bug: T170880
Change-Id: Ic04f4a842b2912574826b01b00d49db93d51c99b
Roan Kattouw [Mon, 17 Jul 2017 23:52:51 +0000 (16:52 -0700)]
ChangesListStringOptionsFilter: Make isSelected() respect ALL
ChangesListStringOptionsGroup::modifyQuery checks for ALL and
behaves accordingly, but isSelected() didn't. This broke conflict
detection when an entire non-full-coverage group was selected.
Bug: T162630
Change-Id: Ie241744201380ca5450d5edbb3eba971194f3df4
Aaron Schulz [Mon, 17 Jul 2017 23:32:53 +0000 (16:32 -0700)]
Remove excess getExternalLB() argument
Change-Id: I097b1ba46806649f014ca624d15d9064ee0f9ba7
jenkins-bot [Mon, 17 Jul 2017 23:00:57 +0000 (23:00 +0000)]
Merge "qunit: Remove redundant conditional for sandbox teardown"
Moriel Schottlender [Mon, 17 Jul 2017 22:38:32 +0000 (15:38 -0700)]
RCFilters: Correct language for invert button
Bug: T166912
Change-Id: Iabbbe2c76d5dc51f2aa49646c84b8eba7bc692a1
jenkins-bot [Mon, 17 Jul 2017 21:49:44 +0000 (21:49 +0000)]
Merge "Swap SqliteInstaller::MINIMUM_VERSION for SqliteInstaller::$minimumVersion"
Kunal Mehta [Mon, 17 Jul 2017 21:07:45 +0000 (14:07 -0700)]
Avoid globals in EditPage::__construct()
Change-Id: Icb1d1042f4bb5e4397c49f20ce26ab9c73e9d0d1
Timo Tijhof [Sat, 8 Jul 2017 00:35:26 +0000 (17:35 -0700)]
qunit: Remove redundant conditional for sandbox teardown
Follows-up
0a208911a257, which added support for the `executeNow`
parameter to QUnit.module.
To properly support nested modules, we also need to skip registering
a second setup and teardown because nested modules already run the
beforeEach (setup), and afterEach (teardown), of their parent modules.
During setup this would needlessly create two sandboxes and override
the 'sandbox' property on the same 'this' context object. During
teardown it would fail because the inner module's teardown would
have already torn down the sandbox.
Change-Id: Ib17bbbef45b2bd0247979cf0fa8aed17800c54a0
Translation updater bot [Mon, 17 Jul 2017 20:05:22 +0000 (22:05 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Iaa3a7149e92d2cee9ad5cd7b445ff8f3ae0684ce
jenkins-bot [Mon, 17 Jul 2017 19:47:01 +0000 (19:47 +0000)]
Merge "DateInputWidget: Unbreak closing the calendar when selecting a date"
jenkins-bot [Mon, 17 Jul 2017 19:44:33 +0000 (19:44 +0000)]
Merge "RCFilters: Reduce saved queries items height"
Roan Kattouw [Wed, 12 Jul 2017 22:40:58 +0000 (15:40 -0700)]
Special:Contributions: Open "To date" widget after selecting a "From date"
Add a 'deactivate' event to DateInputWidget, with a boolean indicating
whether the deactivation occurred because the user chose a date.
Also consolidate some of the code handling this case into the deactivate()
method.
Bug: T120733
Change-Id: Ia56cc28b400a0bc051dff79b2d3870a8954137a6
Roan Kattouw [Wed, 12 Jul 2017 22:14:45 +0000 (15:14 -0700)]
DateInputWidget: Unbreak closing the calendar when selecting a date
I24327e1fe broke this by reopening the calendar when the handle was focused.
Bonus: also fix auto-closing in { precision: 'month' } mode.
Bug: T120733
Change-Id: Ief43f10c1e01f9a6f90b098e4f8ec1f84d8038d1
jenkins-bot [Mon, 17 Jul 2017 19:07:26 +0000 (19:07 +0000)]
Merge "rcfilters: LiveUpdateButtonWidget: Fix bad method call leading to weird warning"
jenkins-bot [Mon, 17 Jul 2017 17:30:47 +0000 (17:30 +0000)]
Merge "registration: Allow protocol-relative links in "url" field"
jenkins-bot [Mon, 17 Jul 2017 17:29:06 +0000 (17:29 +0000)]
Merge "Bump justinrainbow/json-schema development dependency to ~5.2"
jenkins-bot [Mon, 17 Jul 2017 17:21:13 +0000 (17:21 +0000)]
Merge "Update wikimedia/composer-merge-plugin from 1.4.0 -> 1.4.1"
Bartosz Dziewoński [Mon, 17 Jul 2017 17:19:15 +0000 (19:19 +0200)]
rcfilters: LiveUpdateButtonWidget: Fix bad method call leading to weird warning
When viewing recent changes, I get 'JQMIGRATE: jQuery.unique is
deprecated, use jQuery.uniqueSort' in the console.
The bad parentheses change the meaning of $.extend to try to extend
the global $ object, and somehow that ends up touching deprecated
properties. There might be a jQuery bug here somewhere too.
Change-Id: I49265c5882dd189e2b17916c2e14c62d16235677
Kunal Mehta [Mon, 17 Jul 2017 17:13:49 +0000 (10:13 -0700)]
registration: Allow protocol-relative links in "url" field
Bug: T93010
Change-Id: I626fb5528b41910d859d8596a8ad350f94c1082e
Kunal Mehta [Mon, 17 Jul 2017 17:12:55 +0000 (10:12 -0700)]
Bump justinrainbow/json-schema development dependency to ~5.2
https://github.com/justinrainbow/json-schema/compare/3.0.1...5.2.0
https://github.com/justinrainbow/json-schema/releases/tag/4.0.0
https://github.com/justinrainbow/json-schema/releases/tag/4.0.1
https://github.com/justinrainbow/json-schema/releases/tag/4.1.0
https://github.com/justinrainbow/json-schema/releases/tag/5.0.0
https://github.com/justinrainbow/json-schema/releases/tag/5.1.0
https://github.com/justinrainbow/json-schema/releases/tag/5.2.0
Change-Id: I9e3aa67bcf1f4e7b6b0dc831c64df73ce0fea8fe
jenkins-bot [Mon, 17 Jul 2017 17:11:54 +0000 (17:11 +0000)]
Merge "Bump minimum required MySQL Version to 5.5.8"
Translation updater bot [Sun, 16 Jul 2017 19:59:08 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ief7038a0c8b5e47b01b177e3a2cd7a472538f02d
Reedy [Sun, 16 Jul 2017 15:34:09 +0000 (16:34 +0100)]
Update wikimedia/composer-merge-plugin from 1.4.0 -> 1.4.1
https://github.com/wikimedia/composer-merge-plugin/releases/tag/v1.4.1
https://github.com/wikimedia/composer-merge-plugin/compare/v1.4.0...v1.4.1
Change-Id: I805516387648ae76a2b22adac6f94c498b69e6a3
Depends-On: I50338e7f64f8eb3ff9e7177f59d93c88e08562d6
Translation updater bot [Sat, 15 Jul 2017 20:02:18 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I9bd42f589285be09db8e45e5eb88966f430228d5
jenkins-bot [Sat, 15 Jul 2017 18:23:49 +0000 (18:23 +0000)]
Merge "resourceloader: Avoid mw-exception log spam from PHPUnit tests"
Reedy [Thu, 13 Jul 2017 16:14:37 +0000 (17:14 +0100)]
Bump minimum required MySQL Version to 5.5.8
Bug: T161232
Change-Id: I5f7d08ad7e58ce89c9fd766f0ac45fa996bf6a44
jenkins-bot [Sat, 15 Jul 2017 08:02:20 +0000 (08:02 +0000)]
Merge "New maintenance script to recalculate category membership counts"
This, that and the other [Thu, 26 Jan 2017 11:39:30 +0000 (22:39 +1100)]
New maintenance script to recalculate category membership counts
The category membership counts stored in the category table have a habit of
drifting away from the actual number of pages in the category. This script
identifies incorrectly-counted categories by performing a SELECT on the
replica DB, then querying master for up-to-date counts and updating the
category rows with those counts.
It's possible that a LinksUpdate job will be in progress while this script
is run. LinksUpdate does categorylinks INSERTs and category UPDATEs in
separate transactions, and our count might occur in between, leading to
category values that are slightly off. But since we are only updating
categories with already incorrect counts, we are not making the situation
any worse than it already was.
The script runs reasonably quickly on all but the very largest wikis.
Bug: T18765
Change-Id: I555f068fbf3aee20a7775d5532781f421f706346
Timo Tijhof [Tue, 11 Jul 2017 20:05:17 +0000 (13:05 -0700)]
mediawiki.toc: Migrate test from deprecated asyncTest()
Instead, use assert.async(), or (in this case) return the Promise directly
to QUnit.test, which will naturally await it.
As bonus, it'll handle errors, too. (instead of timing out)
Change-Id: I94ee0bf72a3d8ac2e588cd75cbe0787b5001d5b4
Timo Tijhof [Thu, 13 Jul 2017 05:16:53 +0000 (22:16 -0700)]
resourceloader: Avoid mw-exception log spam from PHPUnit tests
Bug: T50002
Change-Id: Ida18f271883535eca2a1d26ee34120190914d87a
jenkins-bot [Sat, 15 Jul 2017 00:27:30 +0000 (00:27 +0000)]
Merge "mw.loader: Avoid use of deprecated QUnit.asyncTest/QUnit.start"
jenkins-bot [Sat, 15 Jul 2017 00:20:12 +0000 (00:20 +0000)]
Merge "Remove temporary hole in abstractions"
Max Semenik [Fri, 14 Jul 2017 23:36:10 +0000 (16:36 -0700)]
Remove temporary hole in abstractions
Was introduced temprarily to facilitate event logging, now the only caller is gone.
Bug: T166247
Change-Id: I0f9cdccc6b3a566d9f7ebf02515f724348205071
Roan Kattouw [Fri, 14 Jul 2017 21:35:48 +0000 (14:35 -0700)]
RCFilters: Allow experimental live update feature to be enabled with query string parameter
For testing. Adding ?liveupdate=1 to the URL will unhide the live update button.
Bug: T167743
Change-Id: I2696da959d34adf952f7f2fa6477ab756ef259bd
Moriel Schottlender [Fri, 14 Jul 2017 20:50:11 +0000 (15:50 -0500)]
RCFilters: Reduce saved queries items height
Bug: T164861
Change-Id: I30a558bc73cc552e0d2b70ab7fd9299e866fd6d2
Translation updater bot [Fri, 14 Jul 2017 20:01:37 +0000 (22:01 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I272241868eec5790ebc164f74b3d8f6982153776
jenkins-bot [Fri, 14 Jul 2017 17:29:40 +0000 (17:29 +0000)]
Merge "Add urlencode for URL encoding of lang values"
jenkins-bot [Fri, 14 Jul 2017 14:04:10 +0000 (14:04 +0000)]
Merge "ChangesListSpecialPage: Don't short-circuit the ChangesList, instead format zero rows"
Brad Jorsch [Fri, 14 Jul 2017 12:42:47 +0000 (08:42 -0400)]
DateTimeInputWidget: Ignore wheel when not focused
Much like I6c9f4679, it's probably best that the widget only use wheel
input when it's focused so it won't accidentally trigger when scrolling
through a form.
Bug: T170607
Change-Id: I46dc3eb01733be939c62e7e7f3f044f21ef1e6d8
Moriel Schottlender [Fri, 14 Jul 2017 01:04:52 +0000 (20:04 -0500)]
RCFilters: Scroll to top on view switch
Bug: T170651
Change-Id: I07376569397651ebee0815c1e1d6e945ef1704dc
Reedy [Thu, 13 Jul 2017 22:30:25 +0000 (23:30 +0100)]
Swap SqliteInstaller::MINIMUM_VERSION for SqliteInstaller::$minimumVersion
Makes it like the rest of the Installer classes
Change-Id: I940e71878f4e9454371c0e1da0ef5d6bfa51ebdd
Translation updater bot [Thu, 13 Jul 2017 20:10:57 +0000 (22:10 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3d1065d5b04461626dac32532b635373b28ade4f
jenkins-bot [Thu, 13 Jul 2017 18:25:32 +0000 (18:25 +0000)]
Merge "Special:ListUsers: Use HTMLForm and OOUI"
Timo Tijhof [Tue, 11 Jul 2017 19:56:35 +0000 (12:56 -0700)]
mw.loader: Avoid use of deprecated QUnit.asyncTest/QUnit.start
Deprecated since QUnit 1.16, removed in QUnit 2.0. (We're on 1.23 currently.)
Migrate to assert.async().
This is a fairly atypical use of QUnit.start(), because it functions here
as a cross-script callback, where lexical scope cannot be used to share
the async() callback directly.
Other mw.loader tests already solved this by using a static callback instead
which inherits the lexical scope from the test to call done(). The old
'qunitOkCall' script is no longer used after this and thus removed.
Change-Id: I430df14b35a69c71df8685494d1379e22af0d6df
jenkins-bot [Thu, 13 Jul 2017 02:18:22 +0000 (02:18 +0000)]
Merge "Maintenance script to purge specific page"
jenkins-bot [Wed, 12 Jul 2017 21:31:07 +0000 (21:31 +0000)]
Merge "HTMLUsersMultiselectField: Handle empty value properly"
jenkins-bot [Wed, 12 Jul 2017 21:31:04 +0000 (21:31 +0000)]
Merge "RCFilters: Don't call ChangeTags::tagUsageStatistics() for now"
jenkins-bot [Wed, 12 Jul 2017 20:41:48 +0000 (20:41 +0000)]
Bartosz Dziewoński [Wed, 12 Jul 2017 20:17:10 +0000 (22:17 +0200)]
SpecialUndelete: Follow-up to
6cf13604aec40e2210c16ccdbeba850de9428d19
Per my (late) code review comments on that commit.
Change-Id: Ia5bb6410b430992b66f34274e86480e6c9566525
Translation updater bot [Wed, 12 Jul 2017 20:07:50 +0000 (22:07 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ice8d28e7cb190e7c0b2ec4d95a3e3e2e835b17bb
jenkins-bot [Wed, 12 Jul 2017 19:55:16 +0000 (19:55 +0000)]
Merge "DeleteAction: Remove now-unnecessary RL modules"
jenkins-bot [Wed, 12 Jul 2017 19:24:54 +0000 (19:24 +0000)]
Merge "Fix cleanupTitles.php"
jenkins-bot [Wed, 12 Jul 2017 19:02:06 +0000 (19:02 +0000)]
Merge "Convert rest of Special:Undelete to OOUI"
jenkins-bot [Wed, 12 Jul 2017 19:02:00 +0000 (19:02 +0000)]
Merge "Give some idea of time remaining"
jenkins-bot [Wed, 12 Jul 2017 19:01:57 +0000 (19:01 +0000)]
Merge "Advise extensions not to modify $wgWhitelistRead"
Bartosz Dziewoński [Wed, 12 Jul 2017 18:46:15 +0000 (20:46 +0200)]
DeleteAction: Remove now-unnecessary RL modules
After
97a8fb78faa4ca2d9604140e5547f5deae5a2524 these are never used.
Change-Id: Ibb4ee45ad991651afab0f0363056d3066e740b24
jenkins-bot [Wed, 12 Jul 2017 18:45:34 +0000 (18:45 +0000)]
Merge "FilterTagMultiselectWidget: Use frameless buttons and fix height issues"
Ed Sanders [Thu, 11 May 2017 14:11:45 +0000 (15:11 +0100)]
Convert rest of Special:Undelete to OOUI
Also fix the 'invert selection' button:
* Don't use type=submit so it doesn't try to post
if JS is disabled
* Don't invert the wpUnsuppress checkbox, just
checkboxes in revision lists.
Bug: T113758
Change-Id: I84785a5ddcc3343d74b5b7addb4aa4817a469f33
jenkins-bot [Wed, 12 Jul 2017 16:14:38 +0000 (16:14 +0000)]
Merge "Convert article delete to use OOUI"
jenkins-bot [Wed, 12 Jul 2017 15:51:17 +0000 (15:51 +0000)]
Merge "Convert Special:Undelete search form to use OOUI"
jenkins-bot [Wed, 12 Jul 2017 15:19:13 +0000 (15:19 +0000)]
Merge "Use OO.ui.MultilineTextInputWidget"
Ed Sanders [Tue, 9 May 2017 19:10:09 +0000 (20:10 +0100)]
Convert Special:Undelete search form to use OOUI
Bug: T113758
Change-Id: I955a07a5903c37d5a054c7b2427c4ec0615a3c36
jenkins-bot [Wed, 12 Jul 2017 15:13:19 +0000 (15:13 +0000)]
Merge "Sanitizer: Allow attribute names to use any Unicode "Letter" or "Number""
Volker E [Wed, 12 Jul 2017 12:20:49 +0000 (14:20 +0200)]
Use OO.ui.MultilineTextInputWidget
Replacing deprecated OO.ui.TextInputWidget({multiline: true}) as of
OOjs UI v0.22.2 with OO.ui.MultilineTextInputWidget.
Also removing `multiline: false` since it is the default value.
Bug: T170275
Change-Id: Iad7c5bb32d7fb9c38b1781cce00eec8f1e99f6f2
jenkins-bot [Wed, 12 Jul 2017 07:47:30 +0000 (07:47 +0000)]
Merge "Add (hacky) check for webm audio files"
jenkins-bot [Wed, 12 Jul 2017 07:43:15 +0000 (07:43 +0000)]
Merge "Add hook for cleaning up data that depends on purged recentchanges rows"
Kunal Mehta [Wed, 12 Jul 2017 01:30:33 +0000 (18:30 -0700)]
Advise extensions not to modify $wgWhitelistRead
Instead they should use the TitleReadWhitelist hook. I've seen this
pattern in multiple extensions now, each causing different problems, so
it should be explicitly documented.
Change-Id: I670b0acde660bdc27a6c7e91c4b1b3baeea8b2e5
Roan Kattouw [Wed, 12 Jul 2017 01:01:09 +0000 (18:01 -0700)]
RCFilters: Don't call ChangeTags::tagUsageStatistics() for now
We need to fix its performance first, it currently takes >30s on wikidatawiki.
Fake all hit counts to be zero. Instead of sorting by hit count,
sort by display name.
Bug: T169997
Change-Id: I4075ea4d43a8f75e21a87a892211699ba3bc7058
James D. Forrester [Tue, 11 Jul 2017 22:15:55 +0000 (15:15 -0700)]
Update OOjs UI to v0.22.3
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.22.3
Depends-On: If676bfab1d2040a9d360c741a5ab4e1c81b36b87
Change-Id: I684822b564663a94e03fc8b559617974502c8e52
Translation updater bot [Tue, 11 Jul 2017 20:13:24 +0000 (22:13 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I7a1a699abbe0d0a35d753e9d8e29a292e4722b5f
Mark Holmquist [Mon, 10 Jul 2017 17:39:36 +0000 (12:39 -0500)]
Add (hacky) check for webm audio files
If there is no video track in a webm file, it's supposed to be audio/webm,
but since we assume every webm file is video/webm, that's never worked.
This should slightly improve searching for audio files.
Bug: T156135
Change-Id: Iac749233e87b3622ff416ad503aedef3df0d0f1d
Roan Kattouw [Tue, 11 Jul 2017 18:29:17 +0000 (11:29 -0700)]
HTMLUsersMultiselectField: Handle empty value properly
If the string value is '' (empty string), the array
value should be [] (empty array), not [''] (array of one element
which is an empty string).
Bug: T169384
Change-Id: I558f3890af05efb6eaa18403467c0a05f44af12a
jenkins-bot [Tue, 11 Jul 2017 18:06:52 +0000 (18:06 +0000)]
Merge "Make label on Special:Undelete search reflect whether search is full-text or prefix"
jenkins-bot [Tue, 11 Jul 2017 15:56:36 +0000 (15:56 +0000)]
Merge "Use OO.ui.MultilineTextInputWidget"
Matthias Mullie [Tue, 11 Jul 2017 11:33:15 +0000 (13:33 +0200)]
Use OO.ui.MultilineTextInputWidget
Replace deprecated OO.ui.TextInputWidget({multiline: true}) as of
OOjs UI v0.22.2 with OO.ui.MultilineTextInputWidget
Bug: T170275
Change-Id: I8f310510a318fb943969fde2a366c08d88bda0e7
Timo Tijhof [Sat, 8 Jul 2017 04:29:36 +0000 (21:29 -0700)]
mw.loader: Log unknown modules in load() to console
Follows-up If8ff31b530dfbd882. Now that we have resolveStubbornly,
we don't need to filter out unknown modules ahead of time.
Aside from removing the needless filter condition, it also has
the benefit of causing a message to be logged to the console,
which can help discover problems. Previously these were silently
ignored.
Change-Id: I700db4931dfd0a412a8eca66c4a74b8831ab0086
jenkins-bot [Tue, 11 Jul 2017 15:19:17 +0000 (15:19 +0000)]
Merge "Make multiple colons escaping interlanguage links invalid, consistently"
jenkins-bot [Tue, 11 Jul 2017 13:23:46 +0000 (13:23 +0000)]
Merge "Resolve successful 1-chunk uploads"
Matthias Mullie [Tue, 11 Jul 2017 13:07:11 +0000 (15:07 +0200)]
Resolve successful 1-chunk uploads
Existing code would assume there's always more than one chunk,
or it would otherwise not resolve.
Upload dialog started doing chunked uploads recently:
Ib9cc2c77a27658accf728fb37f8cebc879a467d2
Change-Id: I29a85c5ee6fbf6cea7d07e3281279b4ea3d87188
jenkins-bot [Tue, 11 Jul 2017 05:53:17 +0000 (05:53 +0000)]
Merge "Refactor UploadBase::checkWarnings into smaller methods"
jenkins-bot [Tue, 11 Jul 2017 00:56:39 +0000 (00:56 +0000)]
Merge "RCFilters: Align TagItemWidget highlight in Safari"
jenkins-bot [Tue, 11 Jul 2017 00:50:04 +0000 (00:50 +0000)]
Merge "Use shell_exec instead of backtick"
jenkins-bot [Tue, 11 Jul 2017 00:47:59 +0000 (00:47 +0000)]
Merge "RCFilters: Change legend heading for the beta feature"
Moriel Schottlender [Mon, 10 Jul 2017 15:55:59 +0000 (10:55 -0500)]
RCFilters: Change legend heading for the beta feature
Bug: T168043
Change-Id: Ide56598b160c93e1dfa8019c0e6e99fb377ea311
jenkins-bot [Tue, 11 Jul 2017 00:39:26 +0000 (00:39 +0000)]
Merge "mw.loader: Skip modules in load() with unknown dependencies"
jenkins-bot [Tue, 11 Jul 2017 00:25:55 +0000 (00:25 +0000)]
Merge "RCFilters: Add white background to legend"
Max Semenik [Mon, 10 Jul 2017 22:07:07 +0000 (15:07 -0700)]
Fix cleanupTitles.php
It was failing in production with duplicate key error in
moveInconsistentPage(). Live-patching it to check for existence
for updates resolved the issues. Committing the fix now.
Change-Id: I1c0bf632b5040b44f5a49c8fb95779e7ed19dea9
Moriel Schottlender [Mon, 10 Jul 2017 21:57:45 +0000 (16:57 -0500)]
RCFilters: Add white background to legend
Bug: T170190
Change-Id: Ib0fc1a492d8e6d431e73bc749178f19f25863965
Moriel Schottlender [Mon, 10 Jul 2017 21:38:45 +0000 (16:38 -0500)]
RCFilters: Respect ?enhanced=0 url regardless of preference
Change-Id: Iffb8cc17b86c5358eea5ae904f55c88965ba4ee0
Translation updater bot [Mon, 10 Jul 2017 20:02:31 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I2d28957e14a7a90a5cba88bfe1a60060387d7cdc
jenkins-bot [Mon, 10 Jul 2017 19:22:15 +0000 (19:22 +0000)]
Merge "RCFilters: Only show 'no filters' when actually none were found"
Timo Tijhof [Sat, 8 Jul 2017 03:34:56 +0000 (20:34 -0700)]
resourceloader: Add unit tests for ResourceLoaderSkinModule
Change-Id: I299eff8f5172e047c0d54d9c824b17529dd6d190
Timo Tijhof [Fri, 16 Jun 2017 19:25:41 +0000 (21:25 +0200)]
ResourceLoaderSkinModule: Fix SkinStyles extending of known media queries
If any of the styles given in its module definition (in the
'styles' or 'skinStyles' properties) used the same media queries
as the module's own CSS (e.g. 'all'), the module would fail with
"PHP Fatal error: [] operator not supported for strings" because
FileModule defaults to merging all the stylesheets into a single
string.
Fix this by ensuring they are arrays before trying to extend them.
This previously made it impossible to use $wgResourceModuleSkinStyles
for modules that use SkinModule (instead of plain FileModule), such as
the 'mediawiki.skinning.interface' module.
Bug: T168088
Change-Id: I3effcaa4982728e707fbf9efeec4e5e78fc8aab6
Moriel Schottlender [Mon, 10 Jul 2017 15:22:18 +0000 (10:22 -0500)]
RCFilters: Only show 'no filters' when actually none were found
Bug: T170161
Change-Id: I50da0d21e84d7e0582437dd43760c93ecb557a56
Gergő Tisza [Mon, 1 May 2017 12:06:56 +0000 (12:06 +0000)]
Add hook for cleaning up data that depends on purged recentchanges rows
Adds RecentChangesPurgeRows hook which gets called in the same
transaction where old recentchanges rows are purged, and gets the
list of deleted rows. Extensions which store data for joining to
recentchanges can use this to purge their own data.
Bug: T159753
Change-Id: I03f1d485a1a3004412e0859d9d878b7895c95b40
Thiemo Mättig [Wed, 5 Jul 2017 10:42:09 +0000 (12:42 +0200)]
Remove auto-generated "Constructor" documentation on constructors
Having such comments is worse than not having them. They add zero
information. But you must read the text to understand there is
nothing you don't already know from the class and the method name.
Change-Id: I994d11e05f202b880390723e148d79c72cca29f0
Prateek Saxena [Sun, 2 Jul 2017 11:28:42 +0000 (16:58 +0530)]
Special:ListUsers: Use HTMLForm and OOUI
Also update the hooks documentation. Now that it is using HTMLForm the
<fieldset> is closed before the submit button is added. The old code
was closing the <fieldset> after adding the submit button so the
documentatio made sense.
Bug: T111999
Change-Id: I109065100e40fef0c56a010c444de04a40950479
Fomafix [Wed, 7 Jun 2017 12:11:08 +0000 (14:11 +0200)]
Use <link rel="license"> instead of <link rel="copyright">
"copyright" is not in the list of the allowed values for the attribut rel:
https://w3c.github.io/html/single-page.html#allowed-keywords-and-their-meanings
Bug: T167284
Change-Id: I09205bb146001d1d1d90e6a0f25d21851f3f697c