jenkins-bot [Sat, 29 Jul 2017 01:16:05 +0000 (01:16 +0000)]
Merge "RCFilters: Make 'related links' collapsible"
jenkins-bot [Sat, 29 Jul 2017 01:14:17 +0000 (01:14 +0000)]
Merge "Follow-up
0b3ea6e1ab: use more flexible regex for timestamp in ChangesListSpecialPageTest"
Moriel Schottlender [Fri, 28 Jul 2017 07:53:57 +0000 (00:53 -0700)]
RCFilters: Make 'related links' collapsible
Bug: T166919
Change-Id: I89d69c6614f641ac92143f0b1a718145e9cd61bd
Roan Kattouw [Sat, 29 Jul 2017 00:36:25 +0000 (17:36 -0700)]
Follow-up
0b3ea6e1ab: use more flexible regex for timestamp in ChangesListSpecialPageTest
Postgres uses timestamps like "2017-07-28 17:37:03" that aren't all numbers.
Bug: T75174
Change-Id: I1b65578c955ccdce1060783b06c2ca577796e68f
jenkins-bot [Sat, 29 Jul 2017 00:05:39 +0000 (00:05 +0000)]
Merge "RCFilters: Create a sticky preference for days/limit groups"
jenkins-bot [Sat, 29 Jul 2017 00:03:18 +0000 (00:03 +0000)]
Merge "Follow-up to '3D' file type addition"
jenkins-bot [Sat, 29 Jul 2017 00:01:17 +0000 (00:01 +0000)]
Merge "Update wikimedia/relpath from 1.0.3 -> 2.0.0"
Matthias Mullie [Thu, 20 Jul 2017 14:43:50 +0000 (16:43 +0200)]
Follow-up to '3D' file type addition
Based on feedback on Id78a504302fa664b353a4c45bdc5d99f95a0180a
Bug: T157348
Change-Id: Id6bfe8d20307f62e4673a5ef30e79f164b1ea034
Timo Tijhof [Fri, 28 Jul 2017 21:26:40 +0000 (14:26 -0700)]
Update wikimedia/relpath from 1.0.3 -> 2.0.0
* (
4f670afd92) Normalize leading path separator to forward slash
Fixes Windows compatibility.
* (
b0eeb17d31) Drop support for PHP 5.3 and PHP 5.4.
Depends-On: I98eb809ff72c4d09bfbb89a9dad9bc7094868240
Change-Id: I4111af30dfbfe2c72d52325bbd1923773e3b4202
jenkins-bot [Fri, 28 Jul 2017 23:12:40 +0000 (23:12 +0000)]
Merge "RCFilters: Remember legend expand/collapse state"
jenkins-bot [Fri, 28 Jul 2017 23:10:57 +0000 (23:10 +0000)]
Merge "RCFilters: Open limit/days popups the other way"
Moriel Schottlender [Thu, 27 Jul 2017 22:32:32 +0000 (15:32 -0700)]
RCFilters: Create a sticky preference for days/limit groups
- Add sticky preference for groups and the operation behind
it.
- Allow normalization from the UriProcessor
- Backwards-compatibility for saved queries
- Allow saved queries to load regardless of sticky params
and to be compared correctly without the sticky params.
- Add days/limit preferences and update those on change
- Update the preference even if we received a new value
from the URL.
Bug: T171514
Bug: T171368
Change-Id: I5232f3372f0e5c981332d152faf0ab47cc470b56
jenkins-bot [Fri, 28 Jul 2017 23:02:25 +0000 (23:02 +0000)]
Merge "RCFilters: Allow setting a new query as default"
Moriel Schottlender [Fri, 28 Jul 2017 22:58:55 +0000 (15:58 -0700)]
RCFilters: Open limit/days popups the other way
Bug: T171968
Change-Id: I83127f43cef02194c839cd0ac531ae43fa386e9a
Moriel Schottlender [Fri, 28 Jul 2017 22:19:27 +0000 (15:19 -0700)]
RCFilters: Remember legend expand/collapse state
Bug: T168043
Change-Id: I2f22f4211cfcbd9e81ee20f013fde921635e5ebc
jenkins-bot [Fri, 28 Jul 2017 22:05:43 +0000 (22:05 +0000)]
Merge "Adjustments to print table styles"
jenkins-bot [Fri, 28 Jul 2017 21:02:54 +0000 (21:02 +0000)]
Merge "rdbms: Complete coverage for Database::selectSQLText()"
Stephane Bisson [Fri, 28 Jul 2017 19:47:48 +0000 (15:47 -0400)]
RCFilters: Allow setting a new query as default
When creating a new saved query, there's a checkbox
to set it as default as the same time.
Bug: T171922
Change-Id: Id6da0e79c54bc65d76636bbff64b2ece568c0cd4
Translation updater bot [Fri, 28 Jul 2017 19:59:25 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie36e6cc52456c039483fb52bbf56a5714d7e3128
jenkins-bot [Fri, 28 Jul 2017 18:55:29 +0000 (18:55 +0000)]
Merge "updateCredits: Fix collation name"
jenkins-bot [Fri, 28 Jul 2017 18:11:14 +0000 (18:11 +0000)]
Merge "RCFilters: Reduce space between filters and saved queries button"
jenkins-bot [Fri, 28 Jul 2017 18:08:38 +0000 (18:08 +0000)]
Merge "RCFilters: Trim input text before evaluation"
jenkins-bot [Fri, 28 Jul 2017 18:07:29 +0000 (18:07 +0000)]
Merge "RCFilters: Close limit/days popups after choosing value"
Bartosz Dziewoński [Fri, 28 Jul 2017 17:13:54 +0000 (19:13 +0200)]
updateCredits: Fix collation name
'uca-default-u-kn' is a valid name for MediaWiki's category collation
functionality ($wgCategoryCollation / Collation class), not for PHP's
collation functionality (Collator class).
'uca-default-u-kn' for Collation maps to 'root-u-kn' for Collator
(see Collation::factory()), and the '-u-kn' suffix is later stripped
to enable numeric collation (see IcuCollation::_construct()).
This doesn't seem to result in any changes in the output.
Change-Id: I8cc7d283aee5408f8b7bed365661ff286236a694
jenkins-bot [Fri, 28 Jul 2017 17:09:49 +0000 (17:09 +0000)]
Merge "resourceloader: Soft-deprecate use of global LESS variables"
Timo Tijhof [Sat, 22 Jul 2017 00:29:14 +0000 (17:29 -0700)]
resourceloader: Soft-deprecate use of global LESS variables
Add deprecation notice to $wgResourceLoaderLESSVars and
hook 'ResourceLoaderGetLessVars'. Warnings to be added in 1.31.
Users should migrate to exposing variables via the individual module's
getLessVars() method.
- Ensures better cache invalidation.
- Separates concerns for getting information and exposing information
as less variables. And allows an extension to, for example, use
a different variable name for something if needed.
The 'deviceWidthTablet' variable will need to be migrated to
either a regular configuration variable that individual modules
can expose in their getLessVars() method - or, alternatively, we
can deprecate it altogether in favour of exposing it through
a less import file instead (see T112747). That would mean, however,
that the value can only be changed in core, not by site config.
Bug: T140804
Change-Id: I61cff1d9652d88dc53c43075dd5053b7707809e6
jenkins-bot [Fri, 28 Jul 2017 14:08:42 +0000 (14:08 +0000)]
Merge "resourceloader: Fix @covers for CSSMin tests"
jdlrobson [Fri, 21 Jul 2017 21:33:52 +0000 (14:33 -0700)]
Adjustments to print table styles
* Remove bolding
* Reset backgrounds
* Explicitly choose font sizes
* Adjust paddings
Bug: T169823
Change-Id: I9c82f10fa92a24c7bcfff4458c6e5b8d2ddaffbf
jenkins-bot [Fri, 28 Jul 2017 08:18:01 +0000 (08:18 +0000)]
Merge "RCFilters: Make namespace and tag features no longer experimental"
Moriel Schottlender [Fri, 28 Jul 2017 08:02:45 +0000 (01:02 -0700)]
RCFilters: Reduce space between filters and saved queries button
Bug: T171822
Change-Id: I521a8e00ad8ea585b30d4d7e0ca36b1e5da031c2
Moriel Schottlender [Fri, 28 Jul 2017 07:28:40 +0000 (00:28 -0700)]
RCFilters: Trim input text before evaluation
Make sure that trailing and leading spaces don't affect searching
and view switches.
Bug: T168225
Change-Id: I2379c7848887ef2cb2cafa9c3cfef8cbe5ed6a62
Moriel Schottlender [Fri, 28 Jul 2017 07:21:34 +0000 (00:21 -0700)]
RCFilters: Close limit/days popups after choosing value
Change-Id: Icd47d243ee64fdc9ab5c0790735a48ba9585e808
jenkins-bot [Fri, 28 Jul 2017 07:05:54 +0000 (07:05 +0000)]
Merge "Fix Special:ListUsers "subpage parameter" handling"
jenkins-bot [Fri, 28 Jul 2017 05:48:51 +0000 (05:48 +0000)]
Merge "Enable jsduck for resources/src/mediawiki.rcfilters and make pass"
jenkins-bot [Fri, 28 Jul 2017 05:40:15 +0000 (05:40 +0000)]
Merge "RCFilters UI: Remove duplicate(!!) method mw.rcfilters.Controller#_getDefaultParams"
Timo Tijhof [Fri, 28 Jul 2017 04:40:21 +0000 (21:40 -0700)]
resourceloader: Fix @covers for CSSMin tests
Change-Id: Idb451d244fbdfbb218a56c2953298b7fe29ed3d4
Timo Tijhof [Fri, 28 Jul 2017 04:19:53 +0000 (21:19 -0700)]
rdbms: Complete coverage for Database::selectSQLText()
Only missing cases where 'USE INDEX' and 'IGNORE INDEX'.
The test doesn't do much since the underlying methods are no-ops
by default, but at least it ensures there are no PHP errors from
these branches.
We can later re-use some of these test cases in tests specific
to one backend.
Change-Id: Id004a2ae41efaa7a367f964013e25d98ecc591ff
Timo Tijhof [Fri, 28 Jul 2017 04:03:18 +0000 (21:03 -0700)]
phpunit: Exclude /languages/messages from coverage report
Indexing these files takes about 5-10% of the run time when generating
code coverage reports for core. It has no coverage at the moment and
probably won't any time soon given it's just variable declarations.
At least for now, exclude it to significantly speed up generating of
coverage reports.
Change-Id: I0357e004e96d4f4b19036474c8353ddb778e31f3
Roan Kattouw [Thu, 27 Jul 2017 23:18:19 +0000 (16:18 -0700)]
Enable jsduck for resources/src/mediawiki.rcfilters and make pass
Change-Id: I2a29689e2697108a5c5206cc61b36b5fb838182f
jenkins-bot [Fri, 28 Jul 2017 00:34:55 +0000 (00:34 +0000)]
Merge "Split minoredit into minoredit and enotif_minoredit"
Matthew Flaschen [Fri, 28 Jul 2017 00:11:28 +0000 (20:11 -0400)]
Split minoredit into minoredit and enotif_minoredit
This allows minoredit to have links, while enotif_minoredit can
not.
Change-Id: I7aff9e5a5e6d460f6fce7da36a32e4717b247e4c
Roan Kattouw [Thu, 27 Jul 2017 23:56:45 +0000 (16:56 -0700)]
RCFilters: Make namespace and tag features no longer experimental
Change-Id: I6a8619088d5672a156617a313d22f25701289e9c
Roan Kattouw [Thu, 27 Jul 2017 23:33:20 +0000 (16:33 -0700)]
Follow-up
94b6ba5453: cast default value to string
The function we're calling here expects an array of strings,
and if we pass it a number it will treat the number 50
differently from the string "50".
Change-Id: I2af535e8ef5dbbba50460013ec4d24e7f29b6b03
Roan Kattouw [Thu, 27 Jul 2017 23:17:50 +0000 (16:17 -0700)]
RCFilters UI: Remove duplicate(!!) method mw.rcfilters.Controller#_getDefaultParams
Change-Id: Id26f4e9716d2276123881c3c74f908265dd1a52f
jenkins-bot [Thu, 27 Jul 2017 22:08:44 +0000 (22:08 +0000)]
Merge "mediawiki.legacy.shared can be run in mobile target"
jenkins-bot [Thu, 27 Jul 2017 21:54:12 +0000 (21:54 +0000)]
Merge "benchmarks: Add benchmarks for MapCacheLRU and HashBagOStuff"
jdlrobson [Thu, 27 Jul 2017 21:49:25 +0000 (14:49 -0700)]
mediawiki.legacy.shared can be run in mobile target
Minerva explicitly disables it
These are needed for rendering for:
?useformat=mobile&useskin=vector
Change-Id: I759c023b4ce63186929b893953042fc0a5059aa2
Timo Tijhof [Thu, 27 Jul 2017 21:09:41 +0000 (14:09 -0700)]
benchmarks: Add benchmarks for MapCacheLRU and HashBagOStuff
Currently, HashBagOStuff leads in most benchmarks, except for
the --fill benchmark, where MapCacheLRU is faster on HHVM.
(by invoking with `PHP=hhvm mwscript maintenance/bench...`)
Run in MediaWiki-Vagrant (Debian Jessie) on MacBook Pro host.
$ benchmarkLruHash.php --count 50000 --construct
Running PHP 5.6.30-0+deb8u1:
- HashBagOStuff-construct (22% faster)
total: 446.20ms (min: 0.01ms, median: 0.01ms, max: 2.09ms)
- MapCacheLRU-construct
total: 575.31ms (min: 0.01ms, median: 0.01ms, max: 3.51ms)
Running PHP version 5.6.99-hhvm:
- HashBagOStuff-construct (13% faster)
total: 124.70ms (min: 0.00ms, median: 0.00ms, max: 1.27ms)
- MapCacheLRU-construct
total: 143.76ms (min: 0.00ms, median: 0.00ms, max: 2.01ms)
For MapCacheLRU, the main slowdown is its use of Wikimedia\Assert.
Removing that would make it faster than HashBagOStuff.
$ benchmarkLruHash.php --count 3000 --fill
Running PHP 5.6.30-0+deb8u1:
- HashBagOStuff-fill (22% faster)
total: 10196.82ms (min: 2.91ms, median: 3.24ms, max: 9.51ms)
- MapCacheLRU-fill
total: 13197.13ms (min: 3.92ms, median: 4.31ms, max: 9.90ms)
Running PHP version 5.6.99-hhvm:
- HashBagOStuff-fill
total: 5700.37ms (min: 1.71ms, median: 1.85ms, max: 8.24ms)
- MapCacheLRU-fill (11% faster)
total: 4986.90ms (min: 1.48ms, median: 1.62ms, max: 6.93ms)
Change-Id: Icd03f872dddb308f162c72674c8d2aa6092395e5
jenkins-bot [Thu, 27 Jul 2017 20:52:52 +0000 (20:52 +0000)]
Merge "RCFilters: Read base value of limit/days from preference"
Moriel Schottlender [Thu, 27 Jul 2017 18:20:27 +0000 (11:20 -0700)]
RCFilters: Read base value of limit/days from preference
Bug: T171368
Change-Id: I0cdbae5bf6b9d00efe351c551d1f8a52459559c4
Translation updater bot [Thu, 27 Jul 2017 20:08:26 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie37ac9953b5715c876cb64d657ef353cf2095215
jenkins-bot [Thu, 27 Jul 2017 18:08:22 +0000 (18:08 +0000)]
Merge "Changing interwiki results header from <p> to <h2>"
jenkins-bot [Thu, 27 Jul 2017 16:54:55 +0000 (16:54 +0000)]
Merge "HTMLUsersMultiSelectField: Don't use content language for placeholder message"
jdlrobson [Fri, 21 Jul 2017 21:26:19 +0000 (14:26 -0700)]
Fix font size and backgrounds in gallery
In print medium we should be explicit about font size
- don't rely on %
and colors should be made more printer friendly
Additional changes:
* Remove some duplicated rule between gallery.print.css and
gallery.css
* Scope background definitions to screen medium
Bug: T169823
Change-Id: Iffcff305a4e0b973bdd52a57f52d8a0766cef512
Roan Kattouw [Thu, 27 Jul 2017 16:38:57 +0000 (09:38 -0700)]
HTMLUsersMultiSelectField: Don't use content language for placeholder message
No idea why this was using content language to begin with, but it seems
like it should clearly use the user language instead.
Bug: T171817
Change-Id: I1763ffd8ee037dbb5dd94c410cb6a82e0f6b27e9
jenkins-bot [Thu, 27 Jul 2017 16:25:01 +0000 (16:25 +0000)]
Merge "New parameters 'reverse' and 'sortbyvalue' for Special:PagesWithProp"
Jan Drewniak [Mon, 24 Jul 2017 15:44:02 +0000 (17:44 +0200)]
Changing interwiki results header from <p> to <h2>
Makes the header on interwiki results
(results from different languages on Special:Search)
bigger.
Bug: T146655
Change-Id: I10ea6f85f97b4c8a5e585b2b1090af68054cbe2c
jenkins-bot [Thu, 27 Jul 2017 14:42:09 +0000 (14:42 +0000)]
Merge "resourceloader: Include lessVars in FileModule definition summary"
jenkins-bot [Thu, 27 Jul 2017 13:43:24 +0000 (13:43 +0000)]
Merge "UserPager: Call text() on message, don't use it directly"
Prateek Saxena [Thu, 27 Jul 2017 08:11:55 +0000 (13:41 +0530)]
UserPager: Call text() on message, don't use it directly
Bug: T171806
Change-Id: Ib9a1ae7b65f8a01542c61b192252f3bb3ded1236
jenkins-bot [Thu, 27 Jul 2017 03:05:45 +0000 (03:05 +0000)]
Merge "Re-introduce use of mime_content_type()"
Timo Tijhof [Thu, 27 Jul 2017 01:53:37 +0000 (18:53 -0700)]
resourceloader: Include lessVars in FileModule definition summary
This already worked as expected for any module that uses the new
enableModuleContentVersion model, but for the majority of file modules
this is not yet the case for performance reasons. As such, make
sure lessVars are included in our manual tracking.
Include it conditionally to avoid changing the array for other modules,
which would needlessly invalidate their cache.
Bug: T171809
Change-Id: Ib250068e0ecfc29a09ca33c23bef901ee0482bf2
Timo Tijhof [Tue, 25 Jul 2017 05:11:17 +0000 (22:11 -0700)]
Re-introduce use of mime_content_type()
Follows-up
eac059c7224. See also https://stackoverflow.com/a/
39676272/319266.
This function was never deprecated. For a short time, the www.php.net
manual page for `mime_content_type` wrongly documented it as having been
deprecated in PHP 5.3, but this wasn't true, and it has been present in
every PHP version since PHP 4.3, including PHP 7 and HHVM 2.3+.
Between PHP 4.3.0-4.3.2 and PHP 5.0-5.3, the function would be absent
if the Mimemagic extension was not enabled at compile-time. However, while
mime_content_type was first introduced by the Mimemagic PHP ext, it is
backend by the Finfo extension since PHP 5.3.0.
Confirmed via https://3v4l.org/IQC1Q.
* CSSMin: Revert conditional use of finfo back to unconditional use
of mime_content_type.
* MimeAnalyzer: Replace conditional use of finfo with unconditional use
use of mime_content_type. Also remove the now-redundant 'else' branch.
The 'else' branch existed because this code was written at a time where
MediaWiki still supported PHP 4, of which some minor versions could
sometimes be compiled without this function.
Change-Id: Iee4a0b6f616a469bb779c40e386045f9c3200446
jenkins-bot [Wed, 26 Jul 2017 23:08:57 +0000 (23:08 +0000)]
Merge "Use double quotes instead of singe quotes for HTML attributes"
jenkins-bot [Wed, 26 Jul 2017 23:02:31 +0000 (23:02 +0000)]
Merge "Cap 'days' param in RC/Watchlist at $wgRCMaxAge"
Fomafix [Mon, 3 Jul 2017 06:51:10 +0000 (08:51 +0200)]
Use double quotes instead of singe quotes for HTML attributes
htmlspecialchars[1] encodes only double quotes not single quotes.
Therefor the HTML attribute must enclosed with double quotes for
correct output encoding.
[1] https://secure.php.net/manual/en/function.htmlspecialchars.php
Change-Id: I3fec5299585187ed70d62b9248007af34b0db85b
jenkins-bot [Wed, 26 Jul 2017 22:25:44 +0000 (22:25 +0000)]
Merge "rdbms: Ensure onTransactionPreCommitOrIdle() callbacks don't lead transactions"
Aaron Schulz [Wed, 26 Jul 2017 09:04:34 +0000 (02:04 -0700)]
rdbms: Ensure onTransactionPreCommitOrIdle() callbacks don't lead transactions
If no writes started a transaction yet, the callback would run
but not commit (by design, joining the request round). Later
writes will then pile on top of it.
The point of this method is to avoid such cases, so this edge
case has been fixed.
Change-Id: I9b44b19261d679de4aff6e44a9cfeb4f684ce02e
Roan Kattouw [Wed, 26 Jul 2017 02:46:37 +0000 (19:46 -0700)]
Cap 'days' param in RC/Watchlist at $wgRCMaxAge
Without this, setting the 'days' param to a very high value
causes exceptions while doing timestamp math.
Bug: T149890
Change-Id: I5aee5f027cced8860eb966e2d6bdb07764ce861a
Translation updater bot [Wed, 26 Jul 2017 19:59:14 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I48b125192ab8b55519f0d772cb36d1c9d3926dd0
jenkins-bot [Wed, 26 Jul 2017 18:54:03 +0000 (18:54 +0000)]
Merge "HTMLForm: Show more options when incorrect displayFormat is set"
Prateek Saxena [Mon, 24 Jul 2017 18:37:14 +0000 (00:07 +0530)]
HTMLForm: Show more options when incorrect displayFormat is set
Change-Id: I47a4684f01f5e30629e819403d7445479c4607da
jenkins-bot [Wed, 26 Jul 2017 14:23:16 +0000 (14:23 +0000)]
Merge "Add urlencode for URL encoding of lang values"
Moriel Schottlender [Wed, 26 Jul 2017 03:34:47 +0000 (20:34 -0700)]
RCFilters: Followup I78e23f85c3: Don't disable RCFilters system when fetching results
We disable and hide it only on first page load while we create the
system, but should not hide and disable the actual filter area
system.
Bug: T165286
Bug: T171671
Change-Id: Ifc9d3c02c0c118d48634b8df846e14bfa6ea294a
jenkins-bot [Wed, 26 Jul 2017 02:26:05 +0000 (02:26 +0000)]
Merge "jquery.tablesorter: Make tests QUnit 2 compatible (remove testCount)"
Timo Tijhof [Wed, 26 Jul 2017 02:02:16 +0000 (19:02 -0700)]
jquery.tablesorter: Make tests QUnit 2 compatible (remove testCount)
Follows-up
6418c54c4,
5e602c6132. Missed these because they didn't
match my search pattern previously (I didn't account for the test
name being a variable instead of a string literal.)
Change-Id: Ieae82acc80719041712c8c18b8ddffe387ebe8cf
Bartosz Dziewoński [Tue, 25 Jul 2017 17:20:31 +0000 (19:20 +0200)]
SpecialUndelete: Remove commented-out code
This has been commented-out since 2006 (
8a42f0b1 / r14777).
I think it's safe to bet it won't be needed again.
Change-Id: Ice85b734803fd5e5d98692ca284a987f17712bc1
jenkins-bot [Wed, 26 Jul 2017 01:30:05 +0000 (01:30 +0000)]
Merge "Add some output messages to populatePPSortKey"
jenkins-bot [Wed, 26 Jul 2017 01:08:56 +0000 (01:08 +0000)]
Merge "RCFilters UI: Unbreak limit and days widgets in non-experimental mode"
Roan Kattouw [Wed, 26 Jul 2017 00:45:00 +0000 (17:45 -0700)]
Follow-up
2a04f2d: don't pass [''] as tag filter when tagfilter=''
Change-Id: I472ff9524840c01131995a884283ca426e133879
Roan Kattouw [Wed, 26 Jul 2017 00:40:47 +0000 (17:40 -0700)]
RCFilters UI: Unbreak limit and days widgets in non-experimental mode
Don't treat all views as experimental, only the namespace and tag ones.
Change-Id: I1ec014314217b52cdfd71ccfcf10d549bea55f6c
Bartosz Dziewoński [Wed, 26 Jul 2017 00:21:44 +0000 (02:21 +0200)]
Fix Special:ListUsers "subpage parameter" handling
* Set the form action to avoid the subpage being "stuck". This is
apparently a common problem and a common workaround, hmm. The $self
variable, curiously unused, seems to have been meant for this.
* Fix incorrect parameter name to display values from subpage
parameters in the form, and preserve them after submission.
Bug: T171657
Change-Id: Ibeee545a1e9932dfe44165c34cb55ad87268b705
jenkins-bot [Wed, 26 Jul 2017 00:14:54 +0000 (00:14 +0000)]
Merge "ChangeTags: Remove $wgRequest abuse in modifyDisplayQuery()"
jenkins-bot [Wed, 26 Jul 2017 00:14:51 +0000 (00:14 +0000)]
Merge "Add unit tests for ChangeTags::modifyDisplayQuery()"
jenkins-bot [Wed, 26 Jul 2017 00:07:31 +0000 (00:07 +0000)]
Merge "RCFilters: Filter duplicates when filtering for multiple tags"
jenkins-bot [Tue, 25 Jul 2017 23:52:54 +0000 (23:52 +0000)]
Merge "RCFilters: Improve loading animation"
Reedy [Tue, 25 Jul 2017 23:47:58 +0000 (00:47 +0100)]
Add some output messages to populatePPSortKey
Change-Id: I8a78fd1575c6a79cd78288c4f1e53a35689d1205
jenkins-bot [Tue, 25 Jul 2017 23:47:48 +0000 (23:47 +0000)]
Merge "parserTests: Use "fallback" skin unless otherwise specified"
jenkins-bot [Tue, 25 Jul 2017 23:34:35 +0000 (23:34 +0000)]
Merge "addRFCandPMIDInterwiki.php: Add trailing . to skipped message"
Reedy [Tue, 25 Jul 2017 23:23:44 +0000 (00:23 +0100)]
addRFCandPMIDInterwiki.php: Add trailing . to skipped message
Change-Id: If7966d1356605ae18857055ac5e6f8364187c414
Roan Kattouw [Tue, 25 Jul 2017 23:20:37 +0000 (16:20 -0700)]
Follow-up
993ce4d: use pp_page for $lastPageValue, not pp_value
This caused the script to get in an infinite loop and never stop.
Change-Id: Ib28a033e82b76fd60005335b882a7f5d95ac6644
jenkins-bot [Tue, 25 Jul 2017 23:00:58 +0000 (23:00 +0000)]
Merge "Add a maintenance script for populating pp_sortkey"
Moriel Schottlender [Tue, 25 Jul 2017 19:50:39 +0000 (12:50 -0700)]
RCFilters: Improve loading animation
Bug: T165286
Bug: T171671
Change-Id: I78e23f85c3ba06cb32355859d426e9c19d69499c
Timo Tijhof [Mon, 17 Jul 2017 20:21:54 +0000 (15:21 -0500)]
Upgrade QUnit from v1.23.1 to v2.4.0
Source
https://code.jquery.com/qunit/qunit-2.4.0.js
https://code.jquery.com/qunit/qunit-2.4.0.css
Changelog
https://github.com/qunitjs/qunit/blob/2.4.0/History.md
This release makes 'moduleStack' private, which means we can no
longer use it to detect nested modules. Change the method of
detection to be a local 'nested' variable that we toggle in
a wrapped version of any 'executeNow' callback, in which nesting
happens.
Bug: T170515
Change-Id: Ib4ed386990125a6c713cb4351408c8f7ae7c070f
jenkins-bot [Tue, 25 Jul 2017 21:51:29 +0000 (21:51 +0000)]
Merge "SpecialUndelete: Don't try to add a form to the page unless it exists"
James D. Forrester [Mon, 24 Jul 2017 21:09:33 +0000 (14:09 -0700)]
SpecialUndelete: Don't try to add a form to the page unless it exists
Bug: T171523
Change-Id: I1083ce168797a698c76c3fdff4eac06edfb0ac6a
Fomafix [Fri, 30 Jun 2017 10:20:19 +0000 (12:20 +0200)]
Add tests for Sanitizer::escapeId
The tests are transfered from mediawiki.util.test.js.
Change-Id: I3fccfab3a2cdf5ad115fc426b3d45ce905e2e609
Fomafix [Fri, 30 Jun 2017 04:02:10 +0000 (06:02 +0200)]
Add parser tests for decoding of entities in indicator names
This change adds parser tests that test the current behavior of decoding
HTML entities in indicator names when generating the indicator IDs as
described in T104196.
The parser tests currently does not compare the generated HTML with
the ID.
With I88e8e2077e the tests get changed to the new behavior.
Change-Id: Id561c4a00ece09b4db381edfe0d5f98120cacf5e
Translation updater bot [Tue, 25 Jul 2017 19:58:01 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I6b3c261e8f61c25f86129b368993ba111cc8ad8c
Kunal Mehta [Thu, 20 Jul 2017 01:42:56 +0000 (18:42 -0700)]
parserTests: Use "fallback" skin unless otherwise specified
ParserOutput::getText() depends on the current skin to format edit
section links, which some (e.g. MinervaNeue) have customized. This
causes parser tests to fail when they expect the default edit section
link format.
Default to always using the built-in fallback skin when parsing, but
allow it to be overridden with a "skin=..." option.
We also have to override $wgOut in addition to the main RequestContext
since that's what ParserOutput uses.
Bug: T170880
Change-Id: Ib7f0bd15dd0a9255e1e5140907e800478b658b92