jenkins-bot [Mon, 25 Jan 2016 20:30:44 +0000 (20:30 +0000)]
Merge "SpecialWatchlist: Display actual number of days for the "all" option"
jenkins-bot [Mon, 25 Jan 2016 20:30:40 +0000 (20:30 +0000)]
Merge "Sync up with Parsoid parserTests."
jenkins-bot [Mon, 25 Jan 2016 20:26:00 +0000 (20:26 +0000)]
Merge "Handle static access in TestingAccessWrapper"
jenkins-bot [Mon, 25 Jan 2016 20:20:10 +0000 (20:20 +0000)]
Merge "Avoid races on null revision insertion"
Arlo Breault [Mon, 25 Jan 2016 20:03:07 +0000 (12:03 -0800)]
Sync up with Parsoid parserTests.
This now aligns with Parsoid commit
b04ce02432166128a295c0f00ac1d64c6a469a81
Change-Id: I9f27dc299b87aa265039c0e25084489810c0f7c8
jenkins-bot [Mon, 25 Jan 2016 20:13:30 +0000 (20:13 +0000)]
Merge "LocalFile: Ensure same timestamp for log entry and image revision"
jenkins-bot [Mon, 25 Jan 2016 20:11:18 +0000 (20:11 +0000)]
Merge "Use $wgSecureCookie to decide whether to actually mark secure cookies as 'secure'"
jenkins-bot [Mon, 25 Jan 2016 20:06:58 +0000 (20:06 +0000)]
Merge "SpecialWatchlist: Display 'wlnote' message even when showing "all" days"
Brad Jorsch [Mon, 25 Jan 2016 19:15:40 +0000 (14:15 -0500)]
Use $wgSecureCookie to decide whether to actually mark secure cookies as 'secure'
The pre-SessionManager code did this, and the change in combination with
the API not honoring forceHTTPS led to T124252.
Bug: T124252
Change-Id: Ic6a79fbb30491040facd7c200b1f47d6b99ce637
Bryan Davis [Mon, 25 Jan 2016 17:04:29 +0000 (10:04 -0700)]
Call session_cache_limiter() before starting a session
Call `session_cache_limiter( 'private, must-revalidate' );` before
starting a session to specify the cache control headers that PHP will
automatically emit. The calls are wrapped in MediaWiki\quietCall to
suppress "headers have already been sent" warnings that may come from PHP.
If not called explicitly PHP will default to using
the value of the session.cache_limiter ini setting. Some values of that
setting will cause PHP to add a "Pragma: no-cache" header to the
response. Certain user agents (e.g. Firefox) treat that particular
header as a signal to aggressively flush the response from local cache
to the point that back button navigation will not work.
The value used was present in `wfSetupSession` prior to
a73c5b7.
Bug: T124510
Change-Id: I942f8420c39c8cec5781ea8f6cc5619fd15f13cd
Bryan Davis [Mon, 25 Jan 2016 16:02:59 +0000 (09:02 -0700)]
Fix typo in cookie key
Fix typo in cookie key name introduced in I1098d05
Bug: T124641
Change-Id: Ib140aa61ba56844191304c4308052148c728bc64
jenkins-bot [Mon, 25 Jan 2016 15:12:47 +0000 (15:12 +0000)]
Merge "Improve wording and tense in some "page language" strings"
jenkins-bot [Mon, 25 Jan 2016 12:11:54 +0000 (12:11 +0000)]
Merge "Last caption wins in gallery"
jenkins-bot [Mon, 25 Jan 2016 12:07:41 +0000 (12:07 +0000)]
Merge "mw.Upload.BookletLayout: Rewrite some code to use promise chaining"
jenkins-bot [Mon, 25 Jan 2016 12:03:10 +0000 (12:03 +0000)]
Merge "Introduce ParserOutput::getRawText()"
jenkins-bot [Mon, 25 Jan 2016 11:23:42 +0000 (11:23 +0000)]
Merge "Fix incorrect Lojban name"
jenkins-bot [Mon, 25 Jan 2016 10:42:45 +0000 (10:42 +0000)]
Merge "Replace deprecated jQuery event aliases"
Gergő Tisza [Mon, 25 Jan 2016 04:16:40 +0000 (04:16 +0000)]
Handle static access in TestingAccessWrapper
Change-Id: Ia8ec6ee0a364807e78fc182c4ce99d782b921eda
Brad Jorsch [Sat, 23 Jan 2016 17:34:27 +0000 (12:34 -0500)]
SessionManager: Abstract forceHTTPS cookie setting
This allows CentralAuthSessionProvider to avoid doing craziness like
this all the time:
Set-Cookie: forceHTTPS=true; path=/; httponly
Set-Cookie: forceHTTPS=deleted; expires=Thu, 01-Jan-1970 00:00:01 GMT; Max-Age=0; path=/; httponly
Set-Cookie: forceHTTPS=true; path=/; domain=.wikipedia.org; httponly
Set-Cookie: forceHTTPS=true; path=/; httponly
Set-Cookie: forceHTTPS=deleted; expires=Thu, 01-Jan-1970 00:00:01 GMT; Max-Age=0; path=/; httponly
Set-Cookie: forceHTTPS=true; path=/; domain=.wikipedia.org; httponly
Bug: T124421
Change-Id: I7e02afd032a246df6850208c26d3447798bc0fc2
Tim Starling [Mon, 25 Jan 2016 03:44:36 +0000 (14:44 +1100)]
Introduce ParserOutput::getRawText()
Avoid polluting the parser cache with skin-dependent output from
Skin::doEditSectionLink() by introducing getRawText(), which provides
access to the uncooked text. Use this in
WikitextContent::fillParserOutput() which is the primary offender
judging by the debug logs (see referenced bug).
Bug: T124356
Change-Id: Ia9e1e4a6dc3a26f88eeebc64eed023ff20c53d58
Justin Du [Mon, 25 Jan 2016 01:57:57 +0000 (19:57 -0600)]
Fix incorrect Lojban name
Bug: T124600
Change-Id: I590e4d1fb60dc194c113f8304ef71d0f8be078a9
Brad Jorsch [Sat, 23 Jan 2016 16:13:11 +0000 (11:13 -0500)]
Move avoidance of setting deleted cookies into WebResponse
There's no reason this should be only in CookieSessionProvider when
we're already handling deduplication in WebResponse.
Further, this fixes the bug in the existing CookieSessionProvider
implementation that a setCookie() followed by a clearCookie() wouldn't
actually clear the cookie.
This reverts commit
1ce684fcef1ee69ca0921c05081cae47f90939e5.
Bug: T124252
Change-Id: I1098d054facacd59f03ebed7c747ec9ff6bf66e7
Depends-On: I61d14bf80fa7c857dec9cffb366dc3f84dbb4faf
Fomafix [Sun, 24 Jan 2016 20:51:05 +0000 (20:51 +0000)]
Replace deprecated jQuery event aliases
In jQuery 3.0 the deprecated event aliases .load, .unload and .error get removed.
They are deprecated since jQuery 1.8:
* https://api.jquery.com/load-event/
* https://api.jquery.com/unload/
* https://api.jquery.com/error/
See major changes of jQuery 3.0 beta:
* https://blog.jquery.com/2016/01/14/jquery-3-0-beta-released/
Change-Id: Ie77b2a12c1c03645b73124c2afe79113f6ea60b5
jenkins-bot [Sun, 24 Jan 2016 20:46:16 +0000 (20:46 +0000)]
Merge "WikiFilePage: Remove weird useless comments"
Bartosz Dziewoński [Sun, 24 Jan 2016 20:31:34 +0000 (21:31 +0100)]
LocalFile: Ensure same timestamp for log entry and image revision
For file patrolling, we rely on the timestamp of image revision
(`image` table) and log entry (`logging` table) being the same, but we
weren't actually making sure it is the same.
Note that the timestamp of page revision can still differ, but that
shouldn't matter and it's a more involved fix.
Change-Id: I8e1b75d744c4a96cb0bb636b153d6e8ea2ee1fcf
Bartosz Dziewoński [Sun, 24 Jan 2016 20:27:52 +0000 (21:27 +0100)]
WikiFilePage: Remove weird useless comments
Change-Id: I0902ab6ddbfcec54f3385bdcdd5062503b5f1b95
Translation updater bot [Sun, 24 Jan 2016 20:00:28 +0000 (21:00 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I45f66a54b9fc616f2593f54437cedecb0ad584c5
jenkins-bot [Sun, 24 Jan 2016 18:44:07 +0000 (18:44 +0000)]
Merge "Reword config-localsettings-badkey"
jenkins-bot [Sun, 24 Jan 2016 18:27:39 +0000 (18:27 +0000)]
Merge "Document tags-edit-revision-selected and add GENDER support for siteusers"
jenkins-bot [Sun, 24 Jan 2016 18:21:52 +0000 (18:21 +0000)]
Merge "Fix typo"
Arlo Breault [Sun, 24 Jan 2016 18:14:04 +0000 (10:14 -0800)]
Fix typo
Change-Id: Ifcea7b157dd1c22f45d03627c8bb0d42da548f79
Bartosz Dziewoński [Sun, 24 Jan 2016 16:06:22 +0000 (17:06 +0100)]
SpecialWatchlist: Display actual number of days for the "all" option
Bug: T120416
Change-Id: Icff5f9550ea27cde6d1c6ea42bb6ab89bf2b8616
Bartosz Dziewoński [Sun, 24 Jan 2016 16:02:59 +0000 (17:02 +0100)]
SpecialWatchlist: Display 'wlnote' message even when showing "all" days
Change-Id: Ib22ecd53c7765125cec08a39cecd4d4098d40b9a
jenkins-bot [Sun, 24 Jan 2016 15:22:34 +0000 (15:22 +0000)]
Merge "Fix another function casing"
jenkins-bot [Sun, 24 Jan 2016 14:41:20 +0000 (14:41 +0000)]
Merge "Clarify documentation of apihelp-query+categorymembers-paramvalue-prop-type"
IoannisKydonis [Sat, 23 Jan 2016 23:17:10 +0000 (01:17 +0200)]
Clarify documentation of apihelp-query+categorymembers-paramvalue-prop-type
Thread:
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Apihelp-query%2Bcategorymembers-paramvalue-prop-type/en
Change-Id: I67d9d7256330ed2ea0b16c22be463f855bc65f2d
Reedy [Sun, 24 Jan 2016 13:05:22 +0000 (13:05 +0000)]
Fix another function casing
Change-Id: Ib0905b97898195305bf4678bfd6acbb71ab36fb6
PranavK [Sun, 4 Jan 2015 07:20:45 +0000 (12:50 +0530)]
MWDebug: Add support for passing objects
Change-Id: I121acab012676e486e19b3f8b0fae50af3d3a567
Translation updater bot [Sat, 23 Jan 2016 21:11:37 +0000 (22:11 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I6c038372ab9058b5e59db7c00b5070dad16e8f6c
jenkins-bot [Sat, 23 Jan 2016 19:12:23 +0000 (19:12 +0000)]
Merge "rebuildrecentchanges.php: Don't create duplicate entries for upload logs"
jenkins-bot [Sat, 23 Jan 2016 15:03:35 +0000 (15:03 +0000)]
Merge "Improve documentation of foreign-structured-upload-form-label-own-work-message-local"
IoannisKydonis [Fri, 22 Jan 2016 09:43:57 +0000 (11:43 +0200)]
Improve documentation of foreign-structured-upload-form-label-own-work-message-local
Thread:
https://translatewiki.net/wiki/Thread:Translating_talk:MediaWiki/About_MediaWiki:Foreign-structured-upload-form-label-own-work-message-local/ksh
Change-Id: I4736ee55145070889f819c8c9bf07b43bfea648a
Gergő Tisza [Fri, 22 Jan 2016 22:29:40 +0000 (14:29 -0800)]
Only delete cookies which are actually set
Some API clients seem to be confused by cookie deletion.
Prevent cookie deletion on the first leg of the API login sequence
(for a client with an empty cookie jar) by only emitting deletion
headers for cookies which are set in the current request.
Bug: T124252
Change-Id: I180e094ea32f951e22adab2ec87d16e5de7cef97
Gergő Tisza [Fri, 22 Jan 2016 06:14:07 +0000 (22:14 -0800)]
Ignore auth cookies with value 'deleted'
'deleted' is the value PHP sets when it deletes a cookie (via the
Expires/Max-Age headers). Apparently some clients ignore the
expiration date and send 'deleted' back; these clients now cannot
login due to some slight changes in exactly when cookies are
set/deleted during the login process.
To keep those clients from breaking, ignore this special value.
Bug: T124252
Change-Id: Icd0e1bcd8efe0869da981352763d25e4f8075bf2
jenkins-bot [Fri, 22 Jan 2016 22:10:10 +0000 (22:10 +0000)]
Merge "mediawiki.util: Add JS-handler usage example for addPortletLink()"
jenkins-bot [Fri, 22 Jan 2016 21:40:52 +0000 (21:40 +0000)]
Merge "SessionManager: Kill getPersistedSessionId()"
Timo Tijhof [Fri, 22 Jan 2016 21:15:38 +0000 (21:15 +0000)]
mediawiki.util: Add JS-handler usage example for addPortletLink()
Makes it clear that the method returns the Element node which
can then be used to attach event handlers.
Change-Id: Id33d3dc24a439cc6fe86f2de5baafa0aa779b2c0
jenkins-bot [Fri, 22 Jan 2016 20:54:14 +0000 (20:54 +0000)]
Merge "Remove putrid remains of $wgAllowAsyncCopyUploads"
Niklas Laxström [Fri, 22 Jan 2016 08:01:21 +0000 (09:01 +0100)]
Add missing @since to new IdLookup classes
Follow up I49568358ec35fdfd0b9e53e441adabded5c7b80f
Change-Id: I9f2e9a7c9bb5dd8608cfc6678a3557d916f0b09f
jenkins-bot [Fri, 22 Jan 2016 19:54:32 +0000 (19:54 +0000)]
Merge "mw.Upload.BookletLayout: Don't explode when the API call fails with 'exception'"
Brad Jorsch [Fri, 22 Jan 2016 19:47:33 +0000 (14:47 -0500)]
SessionManager: Kill getPersistedSessionId()
It's not guaranteed that loadSessionFromStore() will succeed after
whatever alterations the SessionProvider might have made later in the
request.
So instead, let's make a new global object that stores the SessionId
of the persistent session that was loaded during Setup.php, if any. Then
we can check that when we need to know whether the session was
persisted.
Bug: T124468
Change-Id: I1e8e616c83b16aadd86b0a0a40826d40f6e8abe4
Bartosz Dziewoński [Thu, 24 Dec 2015 01:39:07 +0000 (02:39 +0100)]
mw.Upload.BookletLayout: Rewrite some code to use promise chaining
Allegedly this makes it clearer.
Follow-up to I0b2f53b91454f22e2001462397087da9e055b701.
Change-Id: Ie3a6c20452d8102d44b4268f92c55bbabfc5cd68
Bartosz Dziewoński [Tue, 8 Dec 2015 18:15:50 +0000 (19:15 +0100)]
mw.Upload.BookletLayout: Show an error rather than explode when uploads are disabled
Also, localise the error messages.
Bug: T119314
Change-Id: I0b2f53b91454f22e2001462397087da9e055b701
Arlo Breault [Fri, 22 Jan 2016 03:24:03 +0000 (19:24 -0800)]
Last caption wins in gallery
* Currently, for images:
[[File:Foobar.jpg|hi|alt=100|ho]]
caption: ho
but for galleries:
<gallery>
File:Foobar.jpg|hi|alt=100|ho
</gallery>
caption: hi|ho
* This patch brings some consistency to them.
Change-Id: I3b73189b27cc35fade4809477cf18779b953aa3b
Brad Jorsch [Fri, 22 Jan 2016 17:49:06 +0000 (12:49 -0500)]
User: Fix loading of user_touched
Always load user_touched from the row if present, don't gate it on
user_email being non-null.
Bug: T124414
Change-Id: I68fcbb560ddfa349b83126298534161971a88871
jenkins-bot [Fri, 22 Jan 2016 17:13:55 +0000 (17:13 +0000)]
Merge "Misc fixes for file patrol"
Brad Jorsch [Fri, 22 Jan 2016 16:09:32 +0000 (11:09 -0500)]
SessionManager: Add SessionBackend::setProviderMetadata()
Providers might need to update their metadata at times other than when
they're creating the SessionInfo.
Bug: T124409
Change-Id: Ia9d113c93726205de85df65bf85faef74c73c949
jenkins-bot [Fri, 22 Jan 2016 01:52:57 +0000 (01:52 +0000)]
Merge "UploadFromStash: Only remove stashed file on successful uploads"
Bartosz Dziewoński [Thu, 21 Jan 2016 22:45:10 +0000 (23:45 +0100)]
Remove putrid remains of $wgAllowAsyncCopyUploads
None of this works and it's been long begging for a mercy kill.
All it does is waste contributor time on updating deprecations
in the dead code. I imagine we wouldn't reuse much of this
code if we're ever going to reimplement it.
Bug: T119336
Change-Id: Ibd26a4bea621857aac77823017e9be9b7dc52cca
Bartosz Dziewoński [Thu, 21 Jan 2016 22:56:16 +0000 (23:56 +0100)]
UploadFromStash: Only remove stashed file on successful uploads
Also, makes code shorter!
Change-Id: I144d8a207c753bd9e38ac847a0fc61257f11e54d
Matthew Flaschen [Thu, 5 Nov 2015 16:13:17 +0000 (11:13 -0500)]
Fix comment; these are the least signifincant bits (LSBs), not MSBs
Change-Id: I0102e4969d95c6392a48d4a5b2f2bec096a828a5
IoannisKydonis [Thu, 21 Jan 2016 22:03:25 +0000 (00:03 +0200)]
Document tags-edit-revision-selected and add GENDER support for siteusers
Threads:
https://translatewiki.net/wiki/Thread:Support/About_a_MediaWiki:Tags-edit-revision-selected/el_parameter
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Siteusers/en
Change-Id: I1cf3cec3d7837c1a2f50435d48a913553b28a13d
Bartosz Dziewoński [Tue, 29 Dec 2015 01:16:10 +0000 (02:16 +0100)]
rebuildrecentchanges.php: Don't create duplicate entries for upload logs
There are a few cases where we generate both a page revision and a log
entry for a single action (upload; in the future, maybe also move,
protect), but only one recent changes entry (matching the log entry).
Bug: T116809
Change-Id: Ib95a6cb57a942a0758091ff2db9d29f3c0048598
Max Semenik [Thu, 21 Jan 2016 21:45:12 +0000 (21:45 +0000)]
Merge "Register a couple of test classes in autoloader"
jenkins-bot [Thu, 21 Jan 2016 20:48:18 +0000 (20:48 +0000)]
Merge "SessionManager: Notify AuthPlugin when auto-creating accounts"
Max Semenik [Thu, 21 Jan 2016 20:46:26 +0000 (12:46 -0800)]
Register a couple of test classes in autoloader
Bug: T59557
Change-Id: I98e00a321d8fecc4b13bbc84938f849b781209c9
Translation updater bot [Thu, 21 Jan 2016 20:40:18 +0000 (21:40 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I956981e2c3308a17770fe78d532f83dd72427e78
Brad Jorsch [Thu, 21 Jan 2016 20:20:44 +0000 (15:20 -0500)]
SessionManager: Notify AuthPlugin when auto-creating accounts
Bug: T74791
Change-Id: Iabb44d58a922051ca2d70a052d6c53734a4f8936
jenkins-bot [Thu, 21 Jan 2016 20:15:03 +0000 (20:15 +0000)]
Merge "Add checks of $wgEnableBotPasswords in more places"
Brad Jorsch [Thu, 21 Jan 2016 20:06:02 +0000 (15:06 -0500)]
Add checks of $wgEnableBotPasswords in more places
Bug: T124335
Change-Id: I3c13e7c7b84d5b72437f9ebdba35aad29b403b9c
jenkins-bot [Thu, 21 Jan 2016 19:08:52 +0000 (19:08 +0000)]
Merge "Properly escape \n and \r in IRCColourfulRCFeedFormatter"
jenkins-bot [Thu, 21 Jan 2016 17:39:57 +0000 (17:39 +0000)]
Merge "API: Add support for documenting dynamic parameters"
Brad Jorsch [Fri, 15 Jan 2016 21:38:31 +0000 (16:38 -0500)]
API: Add support for documenting dynamic parameters
This will be used by AuthManager's API modules to document the fact that
AuthenticationRequest fields are accepted by the module, and to inform
the user reading the documentation how to determine what those are at
any particular time.
Change-Id: Ic7351de0f9bd239db17d584196e52a77112ed978
IoannisKydonis [Thu, 21 Jan 2016 15:14:36 +0000 (17:14 +0200)]
Reword config-localsettings-badkey
Thread:
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Config-localsettings-badkey/en
Change-Id: I74d1cb755bf02c535f3a0abe161b4d3850c68b3c
jenkins-bot [Thu, 21 Jan 2016 15:12:18 +0000 (15:12 +0000)]
Merge "Do not raise a PHP warning when session write fails"
Gergő Tisza [Thu, 21 Jan 2016 12:24:43 +0000 (04:24 -0800)]
Do not raise a PHP warning when session write fails
Bug: T124126
Change-Id: I3482d8dba4a4d9fe92a39439df41c0e70bfef35d
Anomie [Tue, 22 Dec 2015 16:59:19 +0000 (16:59 +0000)]
Revert "Revert "API: Add a unit test to check all modules' i18n""
This reverts commit
7076a79e8649ad0478bd4bce4743f2919c5f3c69.
Change-Id: I21a606a810cecf2cf13a893dd92c15e5e026e2dc
Depends-On: Ieb790c466847dc06c9a73334ad020ab2c54b2976
Depends-On: I727458c5bf54cebd4bf684fc3f3c5ea31c1ebeeb
Tim Starling [Thu, 21 Jan 2016 05:35:59 +0000 (16:35 +1100)]
Improve wfTempDir() fallback sequence
Validate the return value of sys_get_temp_dir(), and use upload_tmp_dir
if that is not writable. If nothing is writable, throw an exception.
Bug: T119934
Change-Id: I27d784f55c47277bbab1192853e2e04a9d8bd39a
Kevin Israel [Fri, 20 Nov 2015 03:13:17 +0000 (22:13 -0500)]
updateCollation.php: Switch back to using cl_from index for now
Using the cl_sortkey index instead (to reduce disruption to a live
site), as currently implemented, seems to have two serious problems:
* MySQL / MariaDB filesorts all rows that "sort above the given row
[the last row of the previous batch]", not just a single category
at a time until the row limit is reached.
* The current approach to pagination is broken in that it does not
work with ENUM columns such as cl_type, causing 'file' rows to be
skipped, or rows of any type to be repeated. See T119173.
This reverts part of commit
a43f751cf6b6849e.
Bug: T58041
Change-Id: I619564e85b2122f249bdacc45d547b9ce1b3beb5
jenkins-bot [Thu, 21 Jan 2016 04:38:07 +0000 (04:38 +0000)]
Merge "In refreshLinks.php don't clear tag hooks"
Bartosz Dziewoński [Tue, 24 Nov 2015 21:55:24 +0000 (22:55 +0100)]
Preprocessor: Don't allow unclosed extension tags (matching until end of input)
I think it's saner to treat this as invalid syntax, and output the
mismatched tag code verbatim. The current behavior is particularly
annoying for <ref> tags, which often swallow everything afterwards.
This does not affect HTML tags, though. Assuming Tidy is enabled, they
are still auto-closed at the end of the page content.
Related to T17712 and T58306. I think this brings the PHP parser closer
to Parsoid's interpretation.
It reduces performance somewhat in the worst case, though. Testing with
https://phabricator.wikimedia.org/
F3245989 (a 1 MB page starting with
3000 opening tags of 15 different types), parsing time rises from
~0.2 seconds to ~1.1 seconds on my setup. We go from O(N) to O(kN),
where N is bytes of input and k is the number of types of tags present
on the page. Maximum k shouldn't exceed 30 or so in reasonable setups
(depends on installed extensions, it's 20 on English Wikipedia).
To consider:
* Should we keep previous behavior for unclosed <includeonly> /
<noinclude>? This would be particularly disruptive for these if
someone relied on the old behavior, and they're already
special-cased in places.
* Unclosed <pre> tags are now treated as HTML tags, and are still
displayed as preformatted text, but without suppressing wikitext
formatting.
Change-Id: Ia2f24dbfb3567c4b0778761585e6c0303d11ddd0
Alex Monk [Thu, 21 Jan 2016 00:36:11 +0000 (00:36 +0000)]
Allow UserInputWidget on mobile
Change-Id: I87699a93ca1b34c6d248456fcc060f584623d158
jenkins-bot [Thu, 21 Jan 2016 00:13:35 +0000 (00:13 +0000)]
Merge "HTMLForm: Don't limit width to 50em in OOUI mode"
jenkins-bot [Wed, 20 Jan 2016 22:08:07 +0000 (22:08 +0000)]
Merge "HTMLFormField: Use 'align' => 'top' when wrapping legacy stuff in OOUI FieldLayout"
jenkins-bot [Wed, 20 Jan 2016 22:07:58 +0000 (22:07 +0000)]
Merge "resourceloader: Change getLessCompiler() to not be static"
jenkins-bot [Wed, 20 Jan 2016 22:03:08 +0000 (22:03 +0000)]
Merge "SessionManager: Change behavior of getSessionById()"
jenkins-bot [Wed, 20 Jan 2016 21:43:25 +0000 (21:43 +0000)]
Merge "Only check LoggedOut timestamp on the user loaded from session"
Translation updater bot [Wed, 20 Jan 2016 19:44:42 +0000 (19:44 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Wed, 20 Jan 2016 19:38:57 +0000 (19:38 +0000)]
Merge "mw.widgets.CategorySelector: Don't lose namespace-like prefixes from category names"
jenkins-bot [Wed, 20 Jan 2016 19:38:46 +0000 (19:38 +0000)]
Merge "mw.Title: Implement #makeTitle for titles with predefined namespace"
Translation updater bot [Wed, 20 Jan 2016 19:35:40 +0000 (20:35 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I969ad7d6c565bfb99b1ba059a05288a43f7b34e6
cenarium [Wed, 13 Jan 2016 13:25:03 +0000 (14:25 +0100)]
Misc fixes for file patrol
This makes the following (minor) fixes to file patrol:
- If a documentation page for a file was recently created
before the file itself was uploaded, and the page creation
was patrolled, this now allows to patrol the file upload
from the file documentation footer.
- It attempts to retrieve a recent change for the latest
file upload, even if patrolled, so that this info can
be cached.
- It makes some extra code comments.
Change-Id: Ibdebcbbee7c081b99372c44ca64b5ddd86ae5ace
jenkins-bot [Wed, 20 Jan 2016 18:45:52 +0000 (18:45 +0000)]
Merge "SpecialMovepage: Use 'warningbox'/'errorbox' for warnings/errors"
Brad Jorsch [Wed, 20 Jan 2016 18:26:44 +0000 (13:26 -0500)]
Only check LoggedOut timestamp on the user loaded from session
This avoids infinite loops when trying to load other User objects, and
should still preserve the intent of the timestamp (that being as an
invalidation date for client-side caching).
Bug: T124143
Change-Id: Ie304cc3839fdc36a1cb2895e26f7700f4b725159
Brad Jorsch [Wed, 20 Jan 2016 17:40:04 +0000 (12:40 -0500)]
SessionManager: Change behavior of getSessionById()
It's easily possible for SessionManager::getSessionById() to not be
able to load the specified session and to not be able to create an empty
one by that ID, for example if the user's token changed. So change this
from an exceptional condition to an expected one, and adjust callers to
deal with it appropriately.
Let's also make the checks for invalid data structure when loading the
session from the store delete the bogus data entirely.
At the same time, let's change the silly "$noEmpty" parameter to
"$create" and make the default behavior be not to create an empty
session.
Bug: T124126
Change-Id: I085d2026d1b366b1af9fd0e8ca3d815fd8288030
Ryan Schmidt [Wed, 20 Jan 2016 17:06:45 +0000 (11:06 -0600)]
Properly escape \n and \r in IRCColourfulRCFeedFormatter
Right now it is possible to emit a raw \n or \r to the UDP feed by
encoding it as an HTML entity, e.g. This could be used for
arbitrary IRC command execution in bots which do not subsequently
perform their own escaping. This commit changes it so that entities are
decoded first before \n and \r are stripped.
Change-Id: I3f7005abded3fbafb586754d763a00a4018f0954
jenkins-bot [Wed, 20 Jan 2016 15:00:26 +0000 (15:00 +0000)]
Merge "Make redlink tooltip be content language to stop cache pollution."
Bartosz Dziewoński [Tue, 22 Dec 2015 18:01:12 +0000 (19:01 +0100)]
mw.widgets.CategorySelector: Don't lose namespace-like prefixes from category names
Also, handle queries which return non-category results.
Bug: T122221
Change-Id: I205d2fe52a10bd3adcf0235108005dd96811ae65
Bartosz Dziewoński [Tue, 22 Dec 2015 17:56:07 +0000 (18:56 +0100)]
mw.Title: Implement #makeTitle for titles with predefined namespace
Unlike #newFromText or the constructor, this function doesn't allow
the given `namespace` to be overridden by a namespace prefix in
`title`.
Name was chosen to match the PHP function Title::makeTitle().
(There's no need for a #makeTitleSafe variant, because #makeTitle is
already "safe" and checks title validity.)
Change-Id: Ib78dbcb0910bf1458b842b4d9ece6d204761b202
Bartosz Dziewoński [Fri, 27 Nov 2015 02:13:38 +0000 (03:13 +0100)]
SpecialMovepage: Use 'warningbox'/'errorbox' for warnings/errors
Matches the new form styling better.
Also, remove headings in warning messages. Yeah, I don't know
what was up with that, either.
Change-Id: I84ce4d32c50f91cd64d4a1502e33b4cdbadfc5f3