Only show css/js links for selected skin

diff --git a/includes/specials/SpecialPreferences.php b/includes/specials/SpecialPreferences.php
index f138f86..74a8ec8 100644 (file)
--- a/includes/specials/SpecialPreferences.php
+++ b/includes/specials/SpecialPreferences.php
@@ -868,14 +868,18 @@ class PreferencesForm {
                                $checked = $skinkey == $this->mSkin ? ' checked="checked"' : '';
                                $mplink = htmlspecialchars( $mptitle->getLocalURL( "useskin=$skinkey" ) );
                                $previewlink = "(<a target='_blank' href=\"$mplink\">$previewtext</a>)";
-                               $cssPage = Title::makeTitleSafe( NS_USER, $wgUser->getName().'/'.$skinkey.'.css' );
-                               $jsPage = Title::makeTitleSafe( NS_USER, $wgUser->getName().'/'.$skinkey.'.js' );
-                               $customCSS = $sk->makeLinkObj( $cssPage, wfMsgHtml('prefs-custom-css') );
-                               $customJS = $sk->makeLinkObj( $jsPage, wfMsgHtml('prefs-custom-js') ); 
+                               $extraLinks = '';
+                               if( $skinkey == $this->mSkin ) {
+                                       $cssPage = Title::makeTitleSafe( NS_USER, $wgUser->getName().'/'.$skinkey.'.css' );
+                                       $jsPage = Title::makeTitleSafe( NS_USER, $wgUser->getName().'/'.$skinkey.'.js' );
+                                       $customCSS = $sk->makeLinkObj( $cssPage, wfMsgHtml('prefs-custom-css') );
+                                       $customJS = $sk->makeLinkObj( $jsPage, wfMsgHtml('prefs-custom-js') );
+                                       $extraLinks = " ($customCSS) ($customJS)";
+                               }
                                if( $skinkey == $wgDefaultSkin )
                                        $sn .= ' (' . wfMsg( 'default' ) . ')';
                                $wgOut->addHTML( "<input type='radio' name='wpSkin' id=\"wpSkin$skinkey\" value=\"$skinkey\"$checked /> 
-                                       <label for=\"wpSkin$skinkey\">{$sn}</label> $previewlink ($customCSS) ($customJS)<br />\n" );
+                                       <label for=\"wpSkin$skinkey\">{$sn}</label> $previewlink{$extraLinks}<br />\n" );
                        }
                        $wgOut->addHTML( "</fieldset>\n\n" );
                }