Fix for r74950: use wfEscapeShellArg()

diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php
index 86444a5..c575b15 100644 (file)
--- a/includes/installer/Installer.php
+++ b/includes/installer/Installer.php
@@ -890,10 +890,7 @@ abstract class Installer {
                                        return $command;
                                }
 
-                               if ( wfIsWindows() ) {
-                                       $command = "\"$command\"";
-                               }
-                               $file = str_replace( '$1', $command, $versionInfo[0] );
+                               $file = str_replace( '$1', wfEscapeShellArg( $command ), $versionInfo[0] );
                                if ( strstr( wfShellExec( $file ), $versionInfo[1] ) !== false ) {
                                        return $command;
                                }