From f542a300803d91d2a045949cee9e574d277659de Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Wed, 22 Feb 2017 10:06:58 -0800 Subject: [PATCH] qunit: Remove obsolete jshint/jscs options Follows-up c0fb8a8836. Change-Id: I890e6e49b4801667b6eb463efec46a380a27d028 --- tests/qunit/data/generateJqueryMsgData.php | 1 - tests/qunit/data/mediawiki.jqueryMsg.data.js | 1 - tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js | 1 - tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js | 3 --- tests/qunit/suites/resources/mediawiki/mediawiki.Uri.test.js | 2 -- .../suites/resources/mediawiki/mediawiki.jqueryMsg.test.js | 3 --- 6 files changed, 11 deletions(-) diff --git a/tests/qunit/data/generateJqueryMsgData.php b/tests/qunit/data/generateJqueryMsgData.php index 5d1f1cd5b9..d02d476b70 100644 --- a/tests/qunit/data/generateJqueryMsgData.php +++ b/tests/qunit/data/generateJqueryMsgData.php @@ -133,7 +133,6 @@ class GenerateJqueryMsgData extends Maintenance { . "// languages, and parser modes. Intended for use by a unit test framework by looping\n" . "// through the object and comparing its parser return value with the 'result' property.\n" . '// Last generated with ' . basename( __FILE__ ) . ' at ' . gmdate( 'r' ) . "\n" - . "//jscs:disable\n" . "\n" . 'mediaWiki.libs.phpParserData = ' . FormatJson::encode( $phpParserData, true ) . ";\n"; diff --git a/tests/qunit/data/mediawiki.jqueryMsg.data.js b/tests/qunit/data/mediawiki.jqueryMsg.data.js index 498acc1956..db723b6318 100644 --- a/tests/qunit/data/mediawiki.jqueryMsg.data.js +++ b/tests/qunit/data/mediawiki.jqueryMsg.data.js @@ -2,7 +2,6 @@ // languages, and parser modes. Intended for use by a unit test framework by looping // through the object and comparing its parser return value with the 'result' property. // Last generated with generateJqueryMsgData.php at Fri, 10 Jul 2015 11:44:08 +0000 -//jscs:disable mediaWiki.libs.phpParserData = { "messages": { diff --git a/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js b/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js index 6f84945d48..f73d0195d3 100644 --- a/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js +++ b/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js @@ -245,7 +245,6 @@ $tr.appendTo( $thead ); for ( i = 0; i < data.length; i++ ) { - /*jshint loopfunc: true */ $tr = $( '' ); $.each( data[ i ], function ( j, str ) { var $td = $( '' ); diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js index ca151854e7..40fed08049 100644 --- a/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js +++ b/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js @@ -101,7 +101,6 @@ // testing custom / localized namespace 100: 'Penguins' }, - // jscs: disable requireCamelCaseOrUpperCaseIdentifiers wgNamespaceIds: { media: -2, special: -1, @@ -129,7 +128,6 @@ penguins: 100, antarctic_waterfowl: 100 }, - // jscs: enable requireCamelCaseOrUpperCaseIdentifiers wgCaseSensitiveNamespaces: [] } } ) ); @@ -140,7 +138,6 @@ title = new mw.Title( cases.valid[ i ] ); } for ( i = 0; i < cases.invalid.length; i++ ) { - /*jshint loopfunc:true */ title = cases.invalid[ i ]; assert.throws( function () { return new mw.Title( title ); diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.Uri.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.Uri.test.js index e20fc4c1d4..e56c93379a 100644 --- a/tests/qunit/suites/resources/mediawiki/mediawiki.Uri.test.js +++ b/tests/qunit/suites/resources/mediawiki/mediawiki.Uri.test.js @@ -132,7 +132,6 @@ } ); assert.equal( uri.toString(), 'http://example.com/bar/baz', 'normalize URI without protocol or // in loose mode' ); - /*jshint -W001 */ uri = new mw.Uri( 'http://example.com/index.php?key=key&hasOwnProperty=hasOwnProperty&constructor=constructor&watch=watch' ); assert.deepEqual( uri.query, @@ -144,7 +143,6 @@ }, 'Keys in query strings support names of Object prototypes (bug T114344)' ); - /*jshint +W001 */ } ); QUnit.test( 'Constructor( Object )', function ( assert ) { diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js index eff990c08c..049546940b 100644 --- a/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js +++ b/tests/qunit/suites/resources/mediawiki/mediawiki.jqueryMsg.test.js @@ -45,7 +45,6 @@ }, config: { wgArticlePath: '/wiki/$1', - // jscs:disable requireCamelCaseOrUpperCaseIdentifiers wgNamespaceIds: { template: 10, template_talk: 11, @@ -53,7 +52,6 @@ szablon: 10, dyskusja_szablonu: 11 }, - // jscs:enable requireCamelCaseOrUpperCaseIdentifiers wgFormattedNamespaces: { // Localised 10: 'Szablon', @@ -126,7 +124,6 @@ * that may be asynchronous. Invoke the callback parameter when done. */ function process( tasks ) { - /*jshint latedef:false */ function abort() { tasks.splice( 0, tasks.length ); next(); -- 2.20.1