From 98ef0a2f5d407f570e84ae1b59dd595d5105edd1 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Fri, 13 Mar 2015 20:22:02 +0100 Subject: [PATCH] Remove a hack, and a hack for the hack, for MediaWiki UI input fields Hack #1: We were ignoring the 'size' attribute of input fields when $wgUseMediaWikiUIEverywhere was true. Let's not do that. Hack #2: We were setting a min-width for MediaWiki UI input fields, because fields which were supposed to be full-line were becoming tiny because of hack #1. Let's not do that either. Bug: T92498 Change-Id: I1d2c6c9eb60b52a7267c122a719cfdaa1f74f815 --- includes/Html.php | 4 ---- resources/src/mediawiki.ui/components/inputs.less | 8 -------- 2 files changed, 12 deletions(-) diff --git a/includes/Html.php b/includes/Html.php index 879922516e..ed77729880 100644 --- a/includes/Html.php +++ b/includes/Html.php @@ -151,10 +151,6 @@ class Html { } else { $attrs['class'] = 'mw-ui-input'; } - - // Note that size can effect the desired width rendering of mw-ui-input elements - // so it is removed. Left intact when mediawiki ui not enabled. - unset( $attrs['size'] ); } return $attrs; } diff --git a/resources/src/mediawiki.ui/components/inputs.less b/resources/src/mediawiki.ui/components/inputs.less index 1992ccedc4..2f76131286 100644 --- a/resources/src/mediawiki.ui/components/inputs.less +++ b/resources/src/mediawiki.ui/components/inputs.less @@ -128,11 +128,3 @@ input.mw-ui-input-large { font-weight: bold; line-height: 1.25em; } - -// Tablet and desktop specific styling tweaks. -@media all and (min-width: 768px) { - // Make inline elements take up a sensible amount of the screen on wider devices. - .mw-ui-input-inline { - min-width: 320px; - } -} -- 2.20.1