From 965fec558e755df13b7fbdd8a3b30b48a7d4d4c1 Mon Sep 17 00:00:00 2001 From: Derk-Jan Hartman Date: Tue, 6 May 2014 13:25:57 +0200 Subject: [PATCH] mediawiki.action.edit.editWarning: Reuse jQuery collections Change-Id: I3084efe5962bb6a13700f95745c415fb074bc7bd --- .../mediawiki.action.edit.editWarning.js | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.editWarning.js b/resources/src/mediawiki.action/mediawiki.action.edit.editWarning.js index f8448e60a2..dcd2b0b696 100644 --- a/resources/src/mediawiki.action/mediawiki.action.edit.editWarning.js +++ b/resources/src/mediawiki.action/mediawiki.action.edit.editWarning.js @@ -2,16 +2,20 @@ * Javascript for module editWarning */ ( function ( mw, $ ) { + 'use strict'; + $( function () { + var savedWindowOnBeforeUnload, + $wpTextbox1 = $( '#wpTextbox1' ), + $wpSummary = $( '#wpSummary' ); // Check if EditWarning is enabled and if we need it - if ( $( '#wpTextbox1' ).length === 0 ) { + if ( $wpTextbox1.length === 0 ) { return true; } // Get the original values of some form elements - $( '#wpTextbox1, #wpSummary' ).each( function () { + $wpTextbox1.add( $wpSummary ).each( function () { $( this ).data( 'origtext', $( this ).val() ); } ); - var savedWindowOnBeforeUnload; $( window ) .on( 'beforeunload.editwarning', function () { var retval; @@ -20,8 +24,8 @@ // the original values if ( mw.config.get( 'wgAction' ) === 'submit' || - $( '#wpTextbox1' ).data( 'origtext' ) !== $( '#wpTextbox1' ).val() || - $( '#wpSummary' ).data( 'origtext' ) !== $( '#wpSummary' ).val() + $wpTextbox1.data( 'origtext' ) !== $wpTextbox1.val() || + $wpSummary.data( 'origtext' ) !== $wpSummary.val() ) { // Return our message retval = mw.msg( 'editwarning-warning' ); -- 2.20.1