From 8467a3dd4c57588573790480232fff913efbe07d Mon Sep 17 00:00:00 2001
From: Gabriel Wicke <gwicke@users.mediawiki.org>
Date: Thu, 15 Apr 2004 23:17:00 +0000
Subject: [PATCH] another warning

---
 includes/Skin.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/includes/Skin.php b/includes/Skin.php
index 806ef1591d..8ea26e8af3 100644
--- a/includes/Skin.php
+++ b/includes/Skin.php
@@ -220,7 +220,7 @@ class Skin {
 		  (!$wgTitle->isProtected() || $wgUser->isSysop()) ) {
 			$t = wfMsg( "editthispage" );
 			$oid = $red = "";
-			if ( $redirect ) { 
+			if ( !empty($redirect) ) { 
 				$red = "&redirect={$redirect}"; 
 			}
 			if ( !empty($oldid) && ! isset( $diff ) ) {
@@ -2544,7 +2544,7 @@ class Skin {
 		);
 		$toolbar ="<script type='text/javascript'>\n/*<![CDATA[*/\n";
 		
-		$toolbar.="document.writeln(\"<div id='toolbar' tabindex='4000000'>\");\n";
+		$toolbar.="document.writeln(\"<div id='toolbar'>\");\n";
 		foreach($toolarray as $tool) {
 
 			$image=$wgUploadPath."/".$tool["image"];
@@ -2566,7 +2566,7 @@ class Skin {
 		$toolbar.="addInfobox('" . addslashes( wfMsg( "infobox" ) ) . "','" . addslashes(wfMsg("infobox_alert")) . "');\n";
 		$toolbar.="document.writeln(\"</div>\");\n";
 		
-		$toolbar.="/*]]>*/</script>";
+		$toolbar.="/*]]>*/\n</script>";
 		return $toolbar;
 	}
 }
-- 
2.20.1