From 7dbc5b0fe63a10573ebf0f705d6857b3382288dd Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 1 Dec 2017 13:28:36 -0800 Subject: [PATCH] objectcache: Fix HashBagOStuffTest test in PHP 7.1 > There was 1 error: > > 1) HashBagOStuffTest::testEvictionAdd > A non-numeric value encountered > > tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php:106 This warning is new in PHP 7.1, however the behaviour is not new. This code was already not behaving as it should have. Concatenation preceeds addition/multiplication. As such, this was producing (int)-10 each time instead of (str)"key0" through (str)"key10". Change-Id: Ibb1a59e373740772f02dfec77ee7ebd9d181d852 --- tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php b/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php index b2278c3437..53d27c0afb 100644 --- a/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php +++ b/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php @@ -103,7 +103,7 @@ class HashBagOStuffTest extends PHPUnit_Framework_TestCase { for ( $i = 10; $i < 20; $i++ ) { $cache->set( "key$i", 1 ); $this->assertEquals( 1, $cache->get( "key$i" ) ); - $this->assertEquals( false, $cache->get( "key" . $i - 10 ) ); + $this->assertEquals( false, $cache->get( "key" . ( $i - 10 ) ) ); } } -- 2.20.1