From 56a0ce24b4fc01a630fb3118fd82664039bdbde5 Mon Sep 17 00:00:00 2001 From: Fomafix Date: Sun, 13 Jul 2014 14:59:10 +0000 Subject: [PATCH] mediawiki.util: Insert node before updating tooltip for accesskey updateTooltipAccessKeys() uses the native accessKeyLabel property which, in Firefox, isn't available until after the node is inserted into the document. Bug: 67946 Change-Id: I3b80174e2f5df1c9082d30607dbe9b63ede6b5b5 --- resources/src/mediawiki/mediawiki.util.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/resources/src/mediawiki/mediawiki.util.js b/resources/src/mediawiki/mediawiki.util.js index fe5f2b2376..3a06a02e40 100644 --- a/resources/src/mediawiki/mediawiki.util.js +++ b/resources/src/mediawiki/mediawiki.util.js @@ -286,7 +286,7 @@ } if ( tooltip ) { - $link.attr( 'title', tooltip ).updateTooltipAccessKeys(); + $link.attr( 'title', tooltip ); } if ( nextnode ) { @@ -313,6 +313,10 @@ $ul.append( $item ); } + // Update tooltip for the access key after inserting into DOM + // to get a localized access key label (bug 67946). + $link.updateTooltipAccessKeys(); + return $item[0]; }, -- 2.20.1