From 2d1c31d34741756ba2ba0478774e23bdd7f44cfa Mon Sep 17 00:00:00 2001 From: Alexandre Emsenhuber Date: Tue, 2 Apr 2013 16:14:09 +0200 Subject: [PATCH] Fixes to Special:PagesWithProp - Remove unneeded call to HTMLForm::setAction() - Call HTMLForm::setWrapperLegendMsg() instead of HTMLForm::setWrapperLegend() - Use Html::element() instead of Xml::span() Change-Id: I4bc90c223a89bd31ce2d93a959e9bdf4b546e6dd --- includes/specials/SpecialPagesWithProp.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/includes/specials/SpecialPagesWithProp.php b/includes/specials/SpecialPagesWithProp.php index dc6464a068..2f498032c7 100644 --- a/includes/specials/SpecialPagesWithProp.php +++ b/includes/specials/SpecialPagesWithProp.php @@ -70,9 +70,8 @@ class SpecialPagesWithProp extends QueryPage { ), ), $this->getContext() ); $form->setMethod( 'get' ); - $form->setAction( $this->getTitle()->getFullURL() ); $form->setSubmitCallback( array( $this, 'onSubmit' ) ); - $form->setWrapperLegend( $this->msg( 'pageswithprop-legend' ) ); + $form->setWrapperLegendMsg( 'pageswithprop-legend' ); $form->addHeaderText( $this->msg( 'pageswithprop-text' )->parseAsBlock() ); $form->setSubmitTextMsg( 'pageswithprop-submit' ); @@ -125,7 +124,7 @@ class SpecialPagesWithProp extends QueryPage { $ret = Linker::link( $title, null, array(), array(), array( 'known' ) ); if ( $result->pp_value !== '' ) { $value = $this->msg( 'parentheses' ) - ->rawParams( Xml::span( $result->pp_value, 'prop-value' ) ) + ->rawParams( Html::element( 'span', array( 'class' => 'prop-value' ), $result->pp_value ) ) ->escaped(); $ret .= " $value"; } -- 2.20.1