From 1b0bc2529a0aa4de7d0d05ca3896470cac45b92c Mon Sep 17 00:00:00 2001 From: Bryan Tong Minh Date: Thu, 29 Jul 2010 09:32:25 +0000 Subject: [PATCH] Follow-up r60277: Do not return BEFORE_PROCESSING, but void instead. --- includes/specials/SpecialUpload.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/includes/specials/SpecialUpload.php b/includes/specials/SpecialUpload.php index ac1fd456b4..df2585d712 100644 --- a/includes/specials/SpecialUpload.php +++ b/includes/specials/SpecialUpload.php @@ -432,7 +432,10 @@ class SpecialUpload extends SpecialPage { // Deprecated backwards compatibility hook if( !wfRunHooks( 'UploadForm:BeforeProcessing', array( &$this ) ) ) { wfDebug( "Hook 'UploadForm:BeforeProcessing' broke processing the file.\n" ); - return array( 'status' => UploadBase::BEFORE_PROCESSING ); + // Return without notifying the user of an error. This sucks, but + // this was the previous behaviour as well, and as this hook is + // deprecated we're not going to do anything about it. + return; } -- 2.20.1