From 12e608e3d5f5dc7ab7041939ec918091d7f41fa8 Mon Sep 17 00:00:00 2001 From: Antoine Musso Date: Tue, 10 Jul 2012 17:16:46 +0200 Subject: [PATCH] converts '@fixme' to '@todo FIXME' @fixme is simply not recognized by doxygen whereas @todo is used to generate a nice ... todo list!! Change-Id: If956c0a164373126ce48b791d45c56962034eecd --- includes/Cookie.php | 4 ++-- includes/HttpFunctions.php | 2 +- includes/Preferences.php | 2 +- includes/Skin.php | 2 +- includes/logging/LogEventsList.php | 2 +- includes/media/Bitmap.php | 2 +- includes/media/ExifBitmap.php | 3 ++- languages/Language.php | 2 +- maintenance/jsparse.php | 2 +- maintenance/rebuildImages.php | 2 +- tests/phpunit/includes/WikiPageTest.php | 2 +- tests/phpunit/includes/parser/NewParserTest.php | 2 +- 12 files changed, 14 insertions(+), 13 deletions(-) diff --git a/includes/Cookie.php b/includes/Cookie.php index 1ca02b5274..7984d63e34 100644 --- a/includes/Cookie.php +++ b/includes/Cookie.php @@ -80,8 +80,8 @@ class Cookie { * A better method might be to use a blacklist like * http://publicsuffix.org/ * - * @fixme fails to detect 3-letter top-level domains - * @fixme fails to detect 2-letter top-level domains for single-domain use (probably not a big problem in practice, but there are test cases) + * @todo fixme fails to detect 3-letter top-level domains + * @todo fixme fails to detect 2-letter top-level domains for single-domain use (probably not a big problem in practice, but there are test cases) * * @param $domain String: the domain to validate * @param $originDomain String: (optional) the domain the cookie originates from diff --git a/includes/HttpFunctions.php b/includes/HttpFunctions.php index 201a9e5a8d..66b6e729e9 100644 --- a/includes/HttpFunctions.php +++ b/includes/HttpFunctions.php @@ -156,7 +156,7 @@ class Http { * * file:// should not be allowed here for security purpose (r67684) * - * @fixme this is wildly inaccurate and fails to actually check most stuff + * @todo FIXME this is wildly inaccurate and fails to actually check most stuff * * @param $uri Mixed: URI to check for validity * @return Boolean diff --git a/includes/Preferences.php b/includes/Preferences.php index e798d3d90e..eaf781bb7f 100644 --- a/includes/Preferences.php +++ b/includes/Preferences.php @@ -939,7 +939,7 @@ class Preferences { if ( $wgEnableAPI ) { # Some random gibberish as a proposed default - // @fixme This should use CryptRand but we may not want to read urandom on every view + // @todo Fixme: this should use CryptRand but we may not want to read urandom on every view $hash = sha1( mt_rand() . microtime( true ) ); $defaultPreferences['watchlisttoken'] = array( diff --git a/includes/Skin.php b/includes/Skin.php index ac9da93862..f4960c1756 100644 --- a/includes/Skin.php +++ b/includes/Skin.php @@ -363,7 +363,7 @@ abstract class Skin extends ContextSource { * inside ->getOutput() is deprecated. The $out arg is kept * for compatibility purposes with skins. * @param $out OutputPage - * @delete + * @todo delete */ abstract function setupSkinUserCss( OutputPage $out ); diff --git a/includes/logging/LogEventsList.php b/includes/logging/LogEventsList.php index 4d01caab80..1244dd3cf1 100644 --- a/includes/logging/LogEventsList.php +++ b/includes/logging/LogEventsList.php @@ -359,7 +359,7 @@ class LogEventsList extends ContextSource { } /** - * @TODO: split up! + * @todo split up! * * @param $row * @param Title $title diff --git a/includes/media/Bitmap.php b/includes/media/Bitmap.php index 8cf30ab328..56c5842a7b 100644 --- a/includes/media/Bitmap.php +++ b/includes/media/Bitmap.php @@ -261,7 +261,7 @@ class BitmapHandler extends ImageHandler { * @param $params array Array with scaler params * @return ThumbnailImage * - * @fixme no rotation support + * @todo fixme: no rotation support */ protected function getClientScalingThumbnailImage( $image, $params ) { return new ThumbnailImage( $image, $image->getURL(), diff --git a/includes/media/ExifBitmap.php b/includes/media/ExifBitmap.php index 65575ece88..34a1f51156 100644 --- a/includes/media/ExifBitmap.php +++ b/includes/media/ExifBitmap.php @@ -199,7 +199,8 @@ class ExifBitmapHandler extends BitmapHandler { * * @param string $data * @return int 0, 90, 180 or 270 - * @fixme orientation can include flipping as well; see if this is an issue! + * @todo FIXME orientation can include flipping as well; see if this is an + * issue! */ protected function getRotationForExif( $data ) { if ( !$data ) { diff --git a/languages/Language.php b/languages/Language.php index b531f2a376..3ee959eb7a 100644 --- a/languages/Language.php +++ b/languages/Language.php @@ -3907,7 +3907,7 @@ class Language { /** * Decode an expiry (block, protection, etc) which has come from the DB * - * @FIXME: why are we returnings DBMS-dependent strings??? + * @todo FIXME: why are we returnings DBMS-dependent strings??? * * @param $expiry String: Database expiry String * @param $format Bool|Int true to process using language functions, or TS_ constant diff --git a/maintenance/jsparse.php b/maintenance/jsparse.php index da6798e192..2c38ed9d13 100644 --- a/maintenance/jsparse.php +++ b/maintenance/jsparse.php @@ -35,7 +35,7 @@ class JSParseHelper extends Maintenance { if ( $this->hasArg() ) { $files = $this->mArgs; } else { - $this->maybeHelp( true ); // @fixme this is a lame API :) + $this->maybeHelp( true ); // @todo fixme this is a lame API :) exit( 1 ); // it should exit from the above first... } diff --git a/maintenance/rebuildImages.php b/maintenance/rebuildImages.php index fe3b35c93c..7e3d8c4048 100644 --- a/maintenance/rebuildImages.php +++ b/maintenance/rebuildImages.php @@ -189,7 +189,7 @@ class ImageBuilder extends Maintenance { $filename = $altname; $this->output( "Estimating transcoding... $altname\n" ); } else { - # @FIXME: create renameFile() + # @todo FIXME: create renameFile() $filename = $this->renameFile( $filename ); } } diff --git a/tests/phpunit/includes/WikiPageTest.php b/tests/phpunit/includes/WikiPageTest.php index b72a5cd825..2949a3af8f 100644 --- a/tests/phpunit/includes/WikiPageTest.php +++ b/tests/phpunit/includes/WikiPageTest.php @@ -478,7 +478,7 @@ more stuff $this->assertEquals( $expected, $text ); } - /* @FIXME: fix this! + /* @todo FIXME: fix this! public function testGetUndoText() { global $wgDiff3; diff --git a/tests/phpunit/includes/parser/NewParserTest.php b/tests/phpunit/includes/parser/NewParserTest.php index d9b16710fd..11f9471d32 100644 --- a/tests/phpunit/includes/parser/NewParserTest.php +++ b/tests/phpunit/includes/parser/NewParserTest.php @@ -596,7 +596,7 @@ class NewParserTest extends MediaWikiTestCase { * Run a fuzz test series * Draw input from a set of test files * - * @todo @fixme Needs some work to not eat memory until the world explodes + * @todo fixme Needs some work to not eat memory until the world explodes * * @group ParserFuzz */ -- 2.20.1