lhc/web/wiklou.git
10 years agoMerge "Fix grammar in 'deleting-backlinks-warning' message"
jenkins-bot [Tue, 4 Mar 2014 07:57:41 +0000 (07:57 +0000)]
Merge "Fix grammar in 'deleting-backlinks-warning' message"

10 years agoUse a secondary db connection for Revsion::getParentLength in api
umherirrender [Sun, 2 Mar 2014 18:07:06 +0000 (19:07 +0100)]
Use a secondary db connection for Revsion::getParentLength in api

Getting api connection before the connection is set to the named
connection and store it in a local var to use it later.
Same comment as in Special:Contributions

Bug: 61982
Change-Id: Ia66c4a65a24876e2a528034e8e003aa535e6b689

10 years agoUpdate OOjs UI to v0.1.0-pre (f3bc5c6)
James D. Forrester [Tue, 4 Mar 2014 00:15:57 +0000 (16:15 -0800)]
Update OOjs UI to v0.1.0-pre (f3bc5c6)

New changes:
3372b3d Localisation updates from https://translatewiki.net.
d02bccd Localisation updates from https://translatewiki.net.
e01b627 Convert remaining browser-prefixed rules to LESS mixins
0e1cbd9 Allow focusing of inputs in booklet layouts without continuous pages
e87a54e Add maxrows option to OO.ui.TextInputWidget
f3bc5c6 Adjust the size when a textarea is inserted into the DOM

Change-Id: I166c49e69bf49bf1d76dee85355a406f557e6004

10 years agoMerge "Add Updater for Oracle"
jenkins-bot [Mon, 3 Mar 2014 23:53:36 +0000 (23:53 +0000)]
Merge "Add Updater for Oracle"

10 years agoMerge "Remove useless "src" param when wrapping doGetFileStatMulti()"
jenkins-bot [Mon, 3 Mar 2014 23:06:23 +0000 (23:06 +0000)]
Merge "Remove useless "src" param when wrapping doGetFileStatMulti()"

10 years agoAdd Updater for Oracle
csteipp [Mon, 3 Mar 2014 21:31:25 +0000 (13:31 -0800)]
Add Updater for Oracle

Bug: 61015
Change-Id: I748d7531be90155d8b99472d3459e46ce4855f07

10 years agoMerge "Allow configuration of periodic task interval"
jenkins-bot [Mon, 3 Mar 2014 21:26:43 +0000 (21:26 +0000)]
Merge "Allow configuration of periodic task interval"

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Mon, 3 Mar 2014 20:52:13 +0000 (20:52 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Iac95418170688f90f53dcc28f6c429f0e79b0ac4

10 years agoMerge "Make it possible for extensions to specify which version of MediaWiki they...
jenkins-bot [Mon, 3 Mar 2014 20:27:16 +0000 (20:27 +0000)]
Merge "Make it possible for extensions to specify which version of MediaWiki they support via Composer."

10 years agoMerge "Add getMessage tests with Short and Long Contexts"
Mwalker [Mon, 3 Mar 2014 19:45:04 +0000 (19:45 +0000)]
Merge "Add getMessage tests with Short and Long Contexts"

10 years agoRemove useless "src" param when wrapping doGetFileStatMulti()
Aaron Schulz [Mon, 3 Mar 2014 18:02:31 +0000 (10:02 -0800)]
Remove useless "src" param when wrapping doGetFileStatMulti()

Change-Id: I6008384ea872d71dcd2d183186a4aee5048b4dd4

10 years agoSpecial:Version: Treat AUTHORS.txt and CREDITS.txt as text, not wikitext
Brad Jorsch [Mon, 3 Mar 2014 17:53:55 +0000 (12:53 -0500)]
Special:Version: Treat AUTHORS.txt and CREDITS.txt as text, not wikitext

A review of existing extensions in git reveals that 3 of the 5
extensions that have a non-wikitext authors/credits file have this file
named AUTHORS.txt, while none of the 8 that have wikitext
authors/credits have a .txt extension. So let's fix the 2 that have
non-wikitext as "AUTHORS" and do this for the benefit of the other three
that presumably don't want to use wikitext in authors/credits.

Bug: 62153
Change-Id: Id95852ab9836fb284becd7e251374f672b69515f

10 years agoSplit the rest of Action.php into /actions/
addshore [Wed, 26 Feb 2014 19:49:12 +0000 (20:49 +0100)]
Split the rest of Action.php into /actions/

Change-Id: I071ac5778af63a5cffffd59d804c99b2c799d4e5

10 years agoMake it possible for extensions to specify which version of MediaWiki
jeroendedauw [Fri, 20 Dec 2013 22:34:49 +0000 (23:34 +0100)]
Make it possible for extensions to specify which version of MediaWiki
they support via Composer.

This change allows extensions to specify they depend on a specific
version or version range of MediaWiki. This is done by adding the
package mediawiki/mediawiki in their composer.json require section.

As MediaWiki itself is not a Composer package and is quite far away
from becoming one, a workaround was needed, which is provided by
this commit.

It works as follows. When "composer install" or "composer update"
is run, a Composer hook is invoked. This hook programmatically
indicates the root package provides MediaWiki, as it indeed does
when extensions are installed into MediaWiki. The package link
of type "provides" includes the MediaWiki version, which is read
from DefaultSettings.php.

This functionality has been tested and confirmed to work. One needs
a recent Composer version for it to have an effect. The upcoming
Composer alpha8 release will suffice. See
https://github.com/composer/composer/issues/2520

Tests are included. Composer independent tests will run always,
while the Composer specific ones are skipped when Composer is
not installed.

People that already have a composer.json file in their MediaWiki
root directory will need to make the same additions there as this
commit makes to composer-json.example. If this is not done, the
new behaviour will not work for them (though no existing behaviour
will break). The change to the json file has been made in such a
way to minimize the likelihood that any future modifications there
will be needed.

Thanks go to @beausimensen (Sculpin) and @seldaek (Composer) for
their support.

Change-Id: I8df66a92971146ab79cd4fcbd181e559115ca240

10 years agoi18n: use double-quotation for consistency
shirayuki [Mon, 3 Mar 2014 06:29:47 +0000 (15:29 +0900)]
i18n: use double-quotation for consistency

Change-Id: I6f5dd76db9db4467e6535254021d54b5d5f58f78

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sun, 2 Mar 2014 20:32:03 +0000 (20:32 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: I2dd97b0dda0af44be6ad3979d5934554a4d7e31c

10 years agoMerge "SpecialUserlogin: Normalize username before passing to User::newFromName"
jenkins-bot [Sat, 1 Mar 2014 22:13:40 +0000 (22:13 +0000)]
Merge "SpecialUserlogin: Normalize username before passing to User::newFromName"

10 years agoUpdate messages.inc and rebuild MessagesEn.php. Again.
Alexandre Emsenhuber [Sat, 1 Mar 2014 19:05:51 +0000 (20:05 +0100)]
Update messages.inc and rebuild MessagesEn.php. Again.

Follow-up Id5c0225431 (7d923a6).

Change-Id: I663c28aa05a42917ba3988a02c2609b6c4e9a438

10 years agoMerge "TableSorter: Fix column order when collecting headers"
jenkins-bot [Sat, 1 Mar 2014 17:06:59 +0000 (17:06 +0000)]
Merge "TableSorter: Fix column order when collecting headers"

10 years agoMerge "Provide direction hinting in the personal toolbar"
jenkins-bot [Sat, 1 Mar 2014 16:59:15 +0000 (16:59 +0000)]
Merge "Provide direction hinting in the personal toolbar"

10 years agomediawiki.user: Deprecate #bucket
Ori Livneh [Mon, 3 Feb 2014 19:20:00 +0000 (20:20 +0100)]
mediawiki.user: Deprecate #bucket

Rationale:
- On the Wikimedia cluster, it is only used by AFT, which is moribund.
- It's too complicated for what it is.
- Its usage leads to a proliferation of large, persistent cookies that
  degrade site performance.
- If it were rewritten to be simpler, more generic, and cookie-free,
  it would still be an odd fit for the user module.

Change-Id: I5a66e1a4fb60f6c67d1fb5312ccb629bb7964053

10 years agoAvoid API error/header leakage from jobs API
Aaron Schulz [Sat, 1 Mar 2014 05:32:08 +0000 (21:32 -0800)]
Avoid API error/header leakage from jobs API

* Also cleaned up some HTTP headers while at it

bug: 62092
Change-Id: Ia2c1643e47aae53916c107c901cca654dc438a16

10 years agoMerge "Fix for CLDR plural rule parser for old browsers without String.trim"
jenkins-bot [Sat, 1 Mar 2014 04:19:44 +0000 (04:19 +0000)]
Merge "Fix for CLDR plural rule parser for old browsers without String.trim"

10 years agoFix __toString method of DatabaseMysqli
Brian Wolff [Sat, 1 Mar 2014 03:55:00 +0000 (23:55 -0400)]
Fix __toString method of DatabaseMysqli

The superclass was casting mConn to string. For Mysql class this
is just the resource number. However for mysqli objects, that is
a fatal. thread_id seemed like the most convinenent id-ish number
to return instead.

Only really noticeable if you have $wgDebugTransactions = true;

Change-Id: I014bb7ab81d18c5bd07a267939b66a0a6161eb8d

10 years agoMerge "SpecialRecentchanges: Don't use nonexistent messages for filter selector"
jenkins-bot [Sat, 1 Mar 2014 02:27:24 +0000 (02:27 +0000)]
Merge "SpecialRecentchanges: Don't use nonexistent messages for filter selector"

10 years agoMerge "Update OOjs UI to v0.1.0-pre (51f922ba17)"
jenkins-bot [Sat, 1 Mar 2014 00:40:52 +0000 (00:40 +0000)]
Merge "Update OOjs UI to v0.1.0-pre (51f922ba17)"

10 years agoUpdate OOjs UI to v0.1.0-pre (51f922ba17)
James D. Forrester [Sat, 1 Mar 2014 00:33:29 +0000 (16:33 -0800)]
Update OOjs UI to v0.1.0-pre (51f922ba17)

New changes:
1ba6137 Make fieldsets and stack panels more compact
584ed14 Convert styles to LESS and implement grunt task
ad906c5 Add documentation for -1 tabIndex option, which disables tab indexing
3f962db Manage active state of BookletLayout pages
5f3ee83 Disable vertical scrolling in continuous layout mode
96ae071 Make text inputs gray when disabled
51f922b Refactor OutlineControlsWidget, add remove button

Note that 51f922b requires the addition of another message to resources/Resources.php
(eww): ooui-outline-control-remove.

Change-Id: If55f8a78f410f35e38f40a9884d7057c50a4610f

10 years agoMerge "Expand MWException tests"
Mwalker [Sat, 1 Mar 2014 00:06:02 +0000 (00:06 +0000)]
Merge "Expand MWException tests"

10 years agoMerge "Removed refreshLinks2 comment"
jenkins-bot [Fri, 28 Feb 2014 23:23:37 +0000 (23:23 +0000)]
Merge "Removed refreshLinks2 comment"

10 years agoRemove AdminSettings.php hint from Installer message
umherirrender [Fri, 28 Feb 2014 21:48:25 +0000 (22:48 +0100)]
Remove AdminSettings.php hint from Installer message

Message 'config-localsettings-connection-error' contains still a hint to
AdminSettings.php, but last parts was removed with
I522ef138d291cf7567250fef1de34bb41673bc6c

Change-Id: Ic34524cbf7b62a37ee6386322f51e4c4df8e425a

10 years agoFix for CLDR plural rule parser for old browsers without String.trim
Brion Vibber [Fri, 28 Feb 2014 21:13:02 +0000 (13:13 -0800)]
Fix for CLDR plural rule parser for old browsers without String.trim

This fixes MobileFrontend's "last modified" message on Kindle 3.4

Submitted upstream as https://github.com/santhoshtr/CLDRPluralRuleParser/pull/10

Bug: 62072
Change-Id: I350264847417f521c111e3cb81da46805608425a

10 years agoMerge "Update mw.api.watch according to new Watch API"
jenkins-bot [Fri, 28 Feb 2014 21:11:05 +0000 (21:11 +0000)]
Merge "Update mw.api.watch according to new Watch API"

10 years agoMerge "mw.log.deprecate: Use mw.log.warn instead of log.warn"
jenkins-bot [Fri, 28 Feb 2014 21:02:01 +0000 (21:02 +0000)]
Merge "mw.log.deprecate: Use mw.log.warn instead of log.warn"

10 years agoMerge "mw.log.deprecate: Simplify warning message"
jenkins-bot [Fri, 28 Feb 2014 21:01:59 +0000 (21:01 +0000)]
Merge "mw.log.deprecate: Simplify warning message"

10 years agomw.log.deprecate: Use mw.log.warn instead of log.warn
Timo Tijhof [Fri, 28 Feb 2014 20:15:06 +0000 (21:15 +0100)]
mw.log.deprecate: Use mw.log.warn instead of log.warn

In qunit/testrunner.js, freshConfigCopy() temporarily clears
mw.log.warn to avoid a flood of spurious deprecation warnings.

However, as of 89a8fe4, the console was once again flooded with
deprecated notices when in debug mode because in debug mode we
load mediawiki.log.js which redefines the mw.log object and as
such the local reference here kept pointing to the original.

Change-Id: I2b560aac9c0b929c82bb628760c194c0476fe1a9

10 years agomw.log.deprecate: Simplify warning message
Timo Tijhof [Fri, 28 Feb 2014 20:03:28 +0000 (21:03 +0100)]
mw.log.deprecate: Simplify warning message

* Remove odd MWDeprecationWarning prefix.
* Don't mention "property". All accessors targets are properties
  and saying so doesn't add much value (some of the targets are
  more thought of as constructors or methods), the name should
  be sufficient.

Change-Id: Ifc77d176fa830feccf13350b4fd9dbf8cb8d8046

10 years agoUpdate mw.api.watch according to new Watch API
eranroz [Fri, 28 Feb 2014 07:46:13 +0000 (09:46 +0200)]
Update mw.api.watch according to new Watch API

* Using titles instead of title which is deprecated
* Allow operation on multiple pages
Follow up of I820dcb64d469616b10741df013911197cc5bde29

Change-Id: Ic77b546c256fa70f253c7508defe4c0002258b2a

10 years agoresourceloader: Fix broken skinStyles loop in #getModifiedTime
Timo Tijhof [Fri, 28 Feb 2014 19:23:11 +0000 (20:23 +0100)]
resourceloader: Fix broken skinStyles loop in #getModifiedTime

The way we interpret the 'skinStyles' array in #getModifiedTime
is broken. For comparision, look at the loop in #getStyleFiles
which we use for the creation of the actual stylesheets (which
works fine).

It mixed up the logic causing it to always end up with an empty
array. So it's not so much that it fails to detect the files
having changed after an update, it never included mtimes of these
files in the first place. If there'd be a module with only
skinStyles resources, it would have timestamp 0 (1970).

Bug: 62068
Change-Id: I2e772a13183e66e4bfbf95057ebfd7f5e0d817ec

10 years agoSpecialRecentchanges: Don't use nonexistent messages for filter selector
Bartosz Dziewoński [Fri, 28 Feb 2014 18:29:11 +0000 (19:29 +0100)]
SpecialRecentchanges: Don't use nonexistent messages for filter selector

Extensions can defined additional filters, but don't need to define
the corresponding messages. If they don't exist, just fall back to
'show' and 'hide'.

This also fixes the double-escaping of selector link contents and adds
missing entries to the list of messages used here.

Follow-up to Ibbfc3cd0.

Bug: 58449
Change-Id: Id323e3b7daced1e7b6b1e1add4e9e1bf7df05e4e

10 years agoMerge "Add option to show only creations in Special:Contribs, API"
jenkins-bot [Fri, 28 Feb 2014 16:40:25 +0000 (16:40 +0000)]
Merge "Add option to show only creations in Special:Contribs, API"

10 years agoMerge "Fix number of parameters passed on recursive function call"
jenkins-bot [Fri, 28 Feb 2014 16:30:34 +0000 (16:30 +0000)]
Merge "Fix number of parameters passed on recursive function call"

10 years agoAdd option to show only creations in Special:Contribs, API
PiRSquared17 [Wed, 26 Feb 2014 20:57:58 +0000 (20:57 +0000)]
Add option to show only creations in Special:Contribs, API

* Add newOnly option to Special:Contributions
* Add to i18n files
* Add ucshow={new,!new,top,!top} to list=usercontribs
* Deprecated 'uctoponly' in favor of ucshow=top per Anomie.
* Add param 'newonly' to API action=feedcontributions
* Implementation: rev_parent_id=0

Bug: 42026
Change-Id: I07d597ef378d897690097804bf7c774fdadb654c

10 years agomediawiki.api: Remove misleading comment about JSONP
Bartosz Dziewoński [Sat, 1 Feb 2014 00:17:10 +0000 (01:17 +0100)]
mediawiki.api: Remove misleading comment about JSONP

The non-existent parameter this is discussing has been removed a long
time ago, but the comment somehow stayed.

Change-Id: I3cb4583646a8b85fd2383c7d0917de6f6c414049

10 years agoHandle some extra cases in triggerJobs()
Aaron Schulz [Fri, 28 Feb 2014 05:35:30 +0000 (21:35 -0800)]
Handle some extra cases in triggerJobs()

* $wgEnableAPI may be false, though it is a basic part of MediaWiki.
  This only disables api.php and not internal callers so just do that.
* Various socket functions may disabled. Though this is a terrible
  wack-a-mole security measure to handle MediaWiki exploits or
  non-authenticated services, it may still be in use, so work
  around it.

Change-Id: I54a209e003ffce1fe36a5898fe0da735cf5e32e4

10 years agoRemoved refreshLinks2 comment
Aaron Schulz [Fri, 28 Feb 2014 05:48:14 +0000 (21:48 -0800)]
Removed refreshLinks2 comment

bug: 58994
Change-Id: I28cd23478b00777125e5431db117e64b864c02ea

10 years agoMerge "mediawiki.less: Use less mixin to reduce code repetition in animation"
jenkins-bot [Fri, 28 Feb 2014 05:25:59 +0000 (05:25 +0000)]
Merge "mediawiki.less: Use less mixin to reduce code repetition in animation"

10 years agoRemove $wgDebugProfiling. It appears to be unused.
Brian Wolff [Fri, 28 Feb 2014 04:53:58 +0000 (00:53 -0400)]
Remove $wgDebugProfiling. It appears to be unused.

Not sure what happened to it, but grep suggests the option no
longer does anything.

Change-Id: I0d515551cd0d6cfd5b027be71ada714f6ebeb5ab

10 years agoMerge "Use inContentLanguage for dropdown messages in HTMLFormField"
jenkins-bot [Fri, 28 Feb 2014 02:19:02 +0000 (02:19 +0000)]
Merge "Use inContentLanguage for dropdown messages in HTMLFormField"

10 years agoUse inContentLanguage for dropdown messages in HTMLFormField
Marius Hoch [Fri, 28 Feb 2014 02:12:10 +0000 (03:12 +0100)]
Use inContentLanguage for dropdown messages in HTMLFormField

to restore b/c for now.

Bug: 61942
Change-Id: I2741ef940d83eeb564e89e20378fb4004cfe5b83

10 years agoFix number of parameters passed on recursive function call
Reedy [Thu, 27 Feb 2014 21:20:46 +0000 (21:20 +0000)]
Fix number of parameters passed on recursive function call

Error is from If4175332405d26c7ff2e8fbe100bcad61762ce6f

Change-Id: I2deabd42462e4009118ff5578e4da95cab51107a

10 years agoMerge "Make travis test php 5.3, 5.4 and 5.5"
jenkins-bot [Thu, 27 Feb 2014 20:24:33 +0000 (20:24 +0000)]
Merge "Make travis test php 5.3, 5.4 and 5.5"

10 years agoMerge "Moved job running via $wgJobRunRate to a special API"
jenkins-bot [Thu, 27 Feb 2014 19:17:59 +0000 (19:17 +0000)]
Merge "Moved job running via $wgJobRunRate to a special API"

10 years agoMerge "Fix incorrect @covers tags in LinksUpdateTest"
jenkins-bot [Thu, 27 Feb 2014 19:17:06 +0000 (19:17 +0000)]
Merge "Fix incorrect @covers tags in LinksUpdateTest"

10 years agoMoved job running via $wgJobRunRate to a special API
Aaron Schulz [Wed, 12 Feb 2014 22:43:14 +0000 (14:43 -0800)]
Moved job running via $wgJobRunRate to a special API

* A background internal HTTP request used to load the API.
  This handles job execution and related periodic tasks.
  It avoids blocking the main request or breaking it on fatals.
* This method avoids problems that shelling could have:
** Mismatched apache/cli PHP config or versions.
** Had to start a new process and could not use opcode cache.
** safe_mode and open_basedir restrictions required a fallback.
** Some wiki farms may not respect the --wiki parameter.
** wgMaxShellMemory applies to spawned PHP processes.
** Spawning processes is more prone to DOS due to a lack
   of proper limiting/pooling.

bug: 60208
bug: 60210
bug: 60698
bug: 60844
Change-Id: I78b0e709301ac4a0c7b7ed337d6969d7546674bf

10 years agoFix incorrect @covers tags in LinksUpdateTest
addshore [Thu, 27 Feb 2014 19:10:59 +0000 (20:10 +0100)]
Fix incorrect @covers tags in LinksUpdateTest

Change-Id: I6dd9be72b63a153c7ff51f45205ba302d9438dea

10 years agoMerge "Allow to disable specific groups in $wgDebugLogGroups"
jenkins-bot [Thu, 27 Feb 2014 17:40:16 +0000 (17:40 +0000)]
Merge "Allow to disable specific groups in $wgDebugLogGroups"

10 years agoMerge "jshintignore: Add jquery.fullscreen.js"
jenkins-bot [Thu, 27 Feb 2014 15:40:03 +0000 (15:40 +0000)]
Merge "jshintignore: Add jquery.fullscreen.js"

10 years agoMerge "SECURITY: API: Don't find links in the middle of api.php links"
jenkins-bot [Thu, 27 Feb 2014 14:47:18 +0000 (14:47 +0000)]
Merge "SECURITY: API: Don't find links in the middle of api.php links"

10 years agojshintignore: Add jquery.fullscreen.js
Timo Tijhof [Thu, 27 Feb 2014 14:29:23 +0000 (15:29 +0100)]
jshintignore: Add jquery.fullscreen.js

Follows-up 37835854c7. Though it passes out jshint config, it
won't pass jscs and even if it would, it's upstream so it doesn't
have to pass.

Change-Id: Ia67da79b74252065c348a932e700926700030722

10 years agoMerge "Make 'quotation-marks' message non-optional (again)"
jenkins-bot [Thu, 27 Feb 2014 14:34:16 +0000 (14:34 +0000)]
Merge "Make 'quotation-marks' message non-optional (again)"

10 years agoMerge "jquery.tablesorter.test: Re-organise variables"
jenkins-bot [Thu, 27 Feb 2014 14:32:08 +0000 (14:32 +0000)]
Merge "jquery.tablesorter.test: Re-organise variables"

10 years agoSECURITY: API: Don't find links in the middle of api.php links
Brad Jorsch [Fri, 14 Feb 2014 21:48:53 +0000 (16:48 -0500)]
SECURITY: API: Don't find links in the middle of api.php links

Bug: 61362
Change-Id: Idf985e4e69c2f11778a8a90503914678441cb3fb

10 years agoMerge "resourceloader: Add method to get the startup modules load url"
jenkins-bot [Thu, 27 Feb 2014 14:25:11 +0000 (14:25 +0000)]
Merge "resourceloader: Add method to get the startup modules load url"

10 years agoMerge "SECURITY: Make token comparison constant time"
jenkins-bot [Thu, 27 Feb 2014 14:20:31 +0000 (14:20 +0000)]
Merge "SECURITY: Make token comparison constant time"

10 years agoMake travis test php 5.3, 5.4 and 5.5
addshore [Thu, 27 Feb 2014 14:06:13 +0000 (15:06 +0100)]
Make travis test php 5.3, 5.4 and 5.5

Currently these are all set to be allowed to
fail as currently some tests do fail but having
this run will allow us to slowly fix them and
remove the versions from allow_failures

The jobs for 5.3 5.4 and 5.5 seem to take somewhere
between 6 and 9 mins compared to hhvm which takes
about 4 but this should be no problem

Change-Id: Ifee7f6476cfd41736aa595e92260a333b4c059ee

10 years agoSECURITY: Make token comparison constant time
csteipp [Fri, 14 Feb 2014 01:18:40 +0000 (17:18 -0800)]
SECURITY: Make token comparison constant time

It seems like our token comparison would be vulnerable to timing
attacks. This will take constant time.

Bug: 61346
Change-Id: I2a9e89120f7092015495e638c6fa9f67adc9b84f

10 years agoSECURITY: Disallow non-whitelisted namespaces
csteipp [Tue, 4 Feb 2014 00:49:48 +0000 (16:49 -0800)]
SECURITY: Disallow non-whitelisted namespaces

Disallow uploading non-whitelisted namespaces. Also disallow iframe
elements.

User will get an error including the namespace name if they use a non-
whitelisted namespace.

Bug: 60771
Change-Id: Id5c022543184b19b77ad32d9a8a0c2dbbc5e9038

10 years agoMerge "use --prefer-source for composer travis"
jenkins-bot [Thu, 27 Feb 2014 13:43:57 +0000 (13:43 +0000)]
Merge "use  --prefer-source for composer travis"

10 years agoFix grammar in 'deleting-backlinks-warning' message
Bartosz Dziewoński [Thu, 27 Feb 2014 13:41:30 +0000 (14:41 +0100)]
Fix grammar in 'deleting-backlinks-warning' message

transclude from → transclude

Change-Id: I95077e531bd4b15f57778c69a27bb4f5cd8f7b78

10 years agoMake 'quotation-marks' message non-optional (again)
Bartosz Dziewoński [Thu, 27 Feb 2014 13:35:44 +0000 (14:35 +0100)]
Make 'quotation-marks' message non-optional (again)

Follow-up to Iaf9e42ed. See I9282c787 for reasoning.

Change-Id: I43078741b9fd7a8a1f59bbc6b757682db9c3b48e

10 years agouse --prefer-source for composer travis
addshore [Thu, 27 Feb 2014 13:34:23 +0000 (14:34 +0100)]
use  --prefer-source for composer travis

This will avoid composer transport exceptions
which happen when travis hits the github api
too much

Change-Id: I3c7b209d9e4181dd1393f4e9f93587d05828bb4e

10 years agoUpdate messages.inc and rebuild MessagesEn.php
Alexandre Emsenhuber [Thu, 27 Feb 2014 13:18:06 +0000 (14:18 +0100)]
Update messages.inc and rebuild MessagesEn.php

Change-Id: If068c9b2946ca6fccc2fc37d31f456b12f9cc08b

10 years agoMerge "Make show/hide link in RC individually localizable"
jenkins-bot [Thu, 27 Feb 2014 12:50:05 +0000 (12:50 +0000)]
Merge "Make show/hide link in RC individually localizable"

10 years agoMake show/hide link in RC individually localizable
Douglas Gardner [Fri, 24 Jan 2014 13:25:19 +0000 (13:25 +0000)]
Make show/hide link in RC individually localizable

This commit concerns the filters on the [[Special:RecentChanges]] box.
Previously, "Show" and "Hide" in messages such as "Show anonymous users" were a
shared system message: now each filter can be assigned a verb individually.

For example:
* Argument $1 of `rcshowhideminor` used to come from `show` or `hide`.
* $1 now comes from `rcshowhideminor-show` or `rcshowhideminor-hide`.

In place of `show` and `hide`, the following system messages are affected:
* `rcshowhideminor` uses `rcshowhideminor-show` and `rcshowhideminor-hide`.
* `rcshowhidebots` uses `rcshowhidebots-show` and `rcshowhidebots-hide`.
* `rcshowhideanons` uses `rcshowhideanons-show` and `rcshowhideanons-hide`.
* `rcshowhidepatr` uses `rcshowhidepatr-show` and `rcshowhideanons-hide`.
* `rcshowhidemine` uses `rcshowhidemine-show` and `rcshowhidemine-hide`.

This change attempts to correct an issue encountered when localising into
Chechen (ce); previous behaviour made it impossible to translate the entire
sentence fragment correctly (as the verb is rendered slightly differently
depending on the rest of the sentence, and this was not possible with a shared
Show/Hide message).

Bug: 58449
Change-Id: Ibbfc3cd0477b029c8f22a3c812a891ac2109d660

10 years agominor LESS CSS fixes (zero units, dimensions)
S Page [Thu, 14 Nov 2013 23:14:24 +0000 (15:14 -0800)]
minor LESS CSS fixes (zero units, dimensions)

A few zero values included units, and some margin and padding dimensions
had redundant values on the end.  Regarding the latter, since CSS 1 "if
there are two or three, the missing values are taken from the opposite
side".  Leaving values off hurts clarity (I can never remember if the
order is top-left-bottom-right) but both Chromium and Firebug's CSS
inspector will display
   margin: 0 0 15px 0;
as
   margin: 0 0 15px;
anyway.

Bug: 57083
Change-Id: Ic51b2ac196a434857f19d51cd2a92686d53c4877

10 years agoAdd getMessage tests with Short and Long Contexts
addshore [Sat, 22 Feb 2014 11:43:10 +0000 (12:43 +0100)]
Add getMessage tests with Short and Long Contexts

Change-Id: Ib5a1a225b7244490fe9d3a5631d3757614174453

10 years agoExpand MWException tests
addshore [Wed, 26 Feb 2014 13:01:47 +0000 (14:01 +0100)]
Expand MWException tests

Change-Id: Ia6d579eff66c949f6d4318d09afb143ed78f3ac1

10 years agoCleanup search placeholder black/gray text mess
jrobson [Wed, 5 Feb 2014 20:09:36 +0000 (12:09 -0800)]
Cleanup search placeholder black/gray text mess

Document all these cryptic selectors
Drop -webkit support - not necessary
Follow up to: Ief9a5a178058eb01ab032cfae8639b0fc52c47a4
Note: For the record, I think all these rules should die
but if they are not going to they should at least be documented!
Change-Id: I3bb2d9fc4f8502cbf36356a9bc6e3034d2d47ab1

10 years agomediawiki.less: Use less mixin to reduce code repetition in animation
Prateek Saxena [Tue, 25 Feb 2014 14:01:43 +0000 (19:31 +0530)]
mediawiki.less: Use less mixin to reduce code repetition in animation

Adds an `animation` and `transform-rotate` mixin to help with the animation.
Also creates a mixin for the keyframes and uses them for webkit, moz and
opera specific declerations.

Change-Id: I167dc5e5a2f43f64c5029864e76d42fcc82af622

10 years agoMerge "Add tests for ArrayDiffFormatter and DiffOp"
jenkins-bot [Thu, 27 Feb 2014 00:31:25 +0000 (00:31 +0000)]
Merge "Add tests for ArrayDiffFormatter and DiffOp"

10 years agoresourceloader: Add method to get the startup modules load url
dr0ptp4kt [Tue, 17 Dec 2013 23:10:07 +0000 (15:10 -0800)]
resourceloader: Add method to get the startup modules load url

* Needed in order to incorporate this url in cache-optimizing
  things like cache manifests.

Change-Id: I17608e3fac9f8cb5b2764d8a22aa50ff59b23d2c

10 years agoAdd tests for ArrayDiffFormatter and DiffOp
addshore [Wed, 26 Feb 2014 21:47:40 +0000 (22:47 +0100)]
Add tests for ArrayDiffFormatter and DiffOp

This change also adds some tested getters to
the DiffOp class to improve testability of the class

Change-Id: I26eafd791b9892f565a18d0502474ef9c24f9a29

10 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Wed, 26 Feb 2014 21:50:53 +0000 (21:50 +0000)]
Localisation updates from https://translatewiki.net.

Change-Id: Ib7a816babb2751947fa72c22f34539f0c578862e

10 years agoMerge "Update OOjs UI to v0.1.0-pre (064484f9af)"
jenkins-bot [Wed, 26 Feb 2014 20:54:12 +0000 (20:54 +0000)]
Merge "Update OOjs UI to v0.1.0-pre (064484f9af)"

10 years agoAllow to disable specific groups in $wgDebugLogGroups
Alexandre Emsenhuber [Thu, 6 Feb 2014 22:00:43 +0000 (23:00 +0100)]
Allow to disable specific groups in $wgDebugLogGroups

So that they don't even appear in $wgDebugLogFile.

Change-Id: Ibf1a28fa566915d790e4d915354238441c3ff5c7

10 years agoUpdate OOjs UI to v0.1.0-pre (064484f9af)
James D. Forrester [Wed, 26 Feb 2014 20:12:16 +0000 (12:12 -0800)]
Update OOjs UI to v0.1.0-pre (064484f9af)

New changes:
2ebcd42 Localisation updates from https://translatewiki.net.
064484f Only pay attention to left mouse button events in PopupToolGroup

Change-Id: I56f6b6e5022a5651ea27b1eb73f53218b0fedf0d

10 years agoMerge "Support interwiki searches in API"
jenkins-bot [Wed, 26 Feb 2014 18:03:58 +0000 (18:03 +0000)]
Merge "Support interwiki searches in API"

10 years agoMerge "Put callback function within class in SiteConfigurationTest"
jenkins-bot [Wed, 26 Feb 2014 15:06:05 +0000 (15:06 +0000)]
Merge "Put callback function within class in SiteConfigurationTest"

10 years agoAllow configuration of periodic task interval
Nik Everett [Wed, 26 Feb 2014 14:07:29 +0000 (09:07 -0500)]
Allow configuration of periodic task interval

The redis job queue supports delayed jobs but it only checks for them
once every 10 pops or once every five minutes.  This is fine in production
but when running integration tests we want faster turn around time.  This
allows us to force the periodic task execution to one second in integration
tests which speeds them up substantially but leave the standard periodic
time calculation in production which is optimized for lower load.

Change-Id: I74cf3ca78660bd1ae7c1c88c278a15b4a56f6064

10 years agoMerge "Revert "DefaultSettings.php: Remove $wgPasswordSenderName""
jenkins-bot [Wed, 26 Feb 2014 09:40:51 +0000 (09:40 +0000)]
Merge "Revert "DefaultSettings.php: Remove $wgPasswordSenderName""

10 years agoMerge "Removed pointless cache bypass in Swift backend"
jenkins-bot [Wed, 26 Feb 2014 07:07:56 +0000 (07:07 +0000)]
Merge "Removed pointless cache bypass in Swift backend"

10 years agoRevert "DefaultSettings.php: Remove $wgPasswordSenderName"
TTO [Wed, 26 Feb 2014 06:06:17 +0000 (06:06 +0000)]
Revert "DefaultSettings.php: Remove $wgPasswordSenderName"

It seems that this variable is used by a whole
lot of extensions, so to remove it now would be
to break these other extensions.

This reverts commit acda2cc90aea519f41c8ae55bc4d05f02072df84.

Change-Id: I2bd3078508c0608ff58bae4c9ec456e57c617da8

10 years agoMerge "Add test for BadTitleError exception"
Mwalker [Wed, 26 Feb 2014 02:52:36 +0000 (02:52 +0000)]
Merge "Add test for BadTitleError exception"

10 years agoMerge "Add test for ThrottledError exception"
Mwalker [Wed, 26 Feb 2014 02:50:23 +0000 (02:50 +0000)]
Merge "Add test for ThrottledError exception"

10 years agoRemoved pointless cache bypass in Swift backend
Aaron Schulz [Wed, 26 Feb 2014 01:40:53 +0000 (17:40 -0800)]
Removed pointless cache bypass in Swift backend

* This was added by mistake in 2af7ad8 apparently

Change-Id: Ic4004428095953ce07e1e97da43748eba04f6639

10 years agoMerge "Add new Hook 'SendWatchlistEmailNotification'"
jenkins-bot [Wed, 26 Feb 2014 01:11:42 +0000 (01:11 +0000)]
Merge "Add new Hook 'SendWatchlistEmailNotification'"

10 years agoAdd new Hook 'SendWatchlistEmailNotification'
bsitu [Fri, 21 Feb 2014 01:40:29 +0000 (17:40 -0800)]
Add new Hook 'SendWatchlistEmailNotification'

Bug: 53569
Change-Id: I73d5eef9a18d59b022c353c4b7d2aee18bfa6591

10 years agoRemove STRAIGHT_JOIN from ApiQueryLogEvents
Brad Jorsch [Tue, 25 Feb 2014 15:04:30 +0000 (10:04 -0500)]
Remove STRAIGHT_JOIN from ApiQueryLogEvents

Per Sean Pringle:
> In all cases the STRAIGHT_JOIN forces an index scan on logging.times
> index, or more rarely a range access on logging.type_time index. Both
> query plans hit tens of millions of rows and take many minutes.
>
> Removing the STRAIGHT_JOIN allows the MariaDB query optimizer to
> choose a plan that takes seconds. Often it includes a filesort step,
> but more importantly it allows "index condition pushdown" which makes
> the filesort cheap.

Bug: 61889
Change-Id: Iad3905f29a2bdee1e3ebbfb2e1909b330faa8e81

10 years agoSupport interwiki searches in API
Chad Horohoe [Wed, 12 Feb 2014 17:30:22 +0000 (09:30 -0800)]
Support interwiki searches in API

Adds new SearchResult methods for getting namespace text

Bug: 60975
Change-Id: I381c8681cabfa9ff7a73cbe0286ed32d267a5990

10 years agoFix typo in MWExceptionHandlerTest
addshore [Tue, 25 Feb 2014 21:37:40 +0000 (22:37 +0100)]
Fix typo in MWExceptionHandlerTest

Change-Id: I9868155c05bc9ca708f72b0ede02d90612136db9