From: Timo Tijhof <krinklemail@gmail.com>
Date: Tue, 18 Jul 2017 19:59:24 +0000 (-0500)
Subject: maintenance: Add --dry-run option to deleteDefaultMessages.php
X-Git-Tag: 1.31.0-rc.0~2677^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/ajouter.php?a=commitdiff_plain;h=820446e2513c6e1306cef0eae806efd4941dbbb3;p=lhc%2Fweb%2Fwiklou.git

maintenance: Add --dry-run option to deleteDefaultMessages.php

For back-compat, keep the default as-is, because it is also
used as a post-update script by the installer.

But for convenience and safe manual use, do add a dry-run option.
(Ideally this would be a --delete option and dry-run by default.)

Change-Id: I3ca70f15f50b66f9d19fa705cef9a4aae2dd4e5c
---

diff --git a/maintenance/deleteDefaultMessages.php b/maintenance/deleteDefaultMessages.php
index 69f4f893fc..ba8662ac2e 100644
--- a/maintenance/deleteDefaultMessages.php
+++ b/maintenance/deleteDefaultMessages.php
@@ -35,6 +35,7 @@ class DeleteDefaultMessages extends Maintenance {
 		parent::__construct();
 		$this->addDescription( 'Deletes all pages in the MediaWiki namespace' .
 			' which were last edited by "MediaWiki default"' );
+		$this->addOption( 'dry-run', 'Perform a dry run, delete nothing' );
 	}
 
 	public function execute() {
@@ -52,14 +53,23 @@ class DeleteDefaultMessages extends Maintenance {
 		);
 
 		if ( $dbr->numRows( $res ) == 0 ) {
-			# No more messages left
+			// No more messages left
 			$this->output( "done.\n" );
+			return;
+		}
 
+		$dryrun = $this->hasOption( 'dry-run' );
+		if ( $dryrun ) {
+			foreach ( $res as $row ) {
+				$title = Title::makeTitle( $row->page_namespace, $row->page_title );
+				$this->output( "\n* [[$title]]" );
+			}
+			$this->output( "\n\nRun again without --dry-run to delete these pages.\n" );
 			return;
 		}
 
-		# Deletions will be made by $user temporarly added to the bot group
-		# in order to hide it in RecentChanges.
+		// Deletions will be made by $user temporarly added to the bot group
+		// in order to hide it in RecentChanges.
 		$user = User::newFromName( 'MediaWiki default' );
 		if ( !$user ) {
 			$this->error( "Invalid username", true );
@@ -67,7 +77,7 @@ class DeleteDefaultMessages extends Maintenance {
 		$user->addGroup( 'bot' );
 		$wgUser = $user;
 
-		# Handle deletion
+		// Handle deletion
 		$this->output( "\n...deleting old default messages (this may take a long time!)...", 'msg' );
 		$dbw = $this->getDB( DB_MASTER );