From: Aaron Schulz <aschulz@wikimedia.org>
Date: Sat, 9 Sep 2017 21:35:58 +0000 (-0700)
Subject: Deprecate IDatabase::implicitGroupby()
X-Git-Tag: 1.31.0-rc.0~2052^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/ajouter.php?a=commitdiff_plain;h=2b7230430607c90c889c6ee7c94648de14d127f3;p=lhc%2Fweb%2Fwiklou.git

Deprecate IDatabase::implicitGroupby()

Even newer mariadb versions default to only_full_group_by,
putting it in the same boat as mssql, postgres, and sqlite.

Change-Id: I465406e7c96ec2db1578c73d80c28ad41708c6a0
---

diff --git a/includes/libs/rdbms/database/IDatabase.php b/includes/libs/rdbms/database/IDatabase.php
index 0283c4b48a..78889e52e0 100644
--- a/includes/libs/rdbms/database/IDatabase.php
+++ b/includes/libs/rdbms/database/IDatabase.php
@@ -206,6 +206,7 @@ interface IDatabase {
 	 * Returns true if this database does an implicit sort when doing GROUP BY
 	 *
 	 * @return bool
+	 * @deprecated Since 1.30; only use grouped or aggregated fields in the SELECT
 	 */
 	public function implicitGroupby();