Throw an exception in ScopedCallback for invalid callbacks.
authorAaron Schulz <aschulz@wikimedia.org>
Fri, 31 May 2013 22:21:39 +0000 (15:21 -0700)
committerGerrit Code Review <gerrit@wikimedia.org>
Sat, 1 Jun 2013 07:06:32 +0000 (07:06 +0000)
Change-Id: I303dec64e55df0b1de73c6db6577bfb005cbe464

includes/ScopedCallback.php

index fa88c0e..ef22e0a 100644 (file)
@@ -31,8 +31,12 @@ class ScopedCallback {
 
        /**
         * @param callable $callback
+        * @throws MWException
         */
        public function __construct( $callback ) {
+               if ( !is_callable( $callback ) ) {
+                       throw new MWException( "Provided callback is not valid." );
+               }
                $this->callback = $callback;
        }